Skip to content

[BUG] ImageSpec NoOpBuilder should always return True while calling should_build function #3311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pingsutw merged 4 commits into from
Aug 16, 2025
Merged

[BUG] ImageSpec NoOpBuilder should always return True while calling should_build function #3311

pingsutw merged 4 commits into from
Aug 16, 2025

Conversation

@popojk
Copy link
Contributor

@popojk popojk commented Aug 11, 2025 •
edited by flyte-bot
Loading

Tracking issue

closes #6561

Why are the changes needed?

The NoOpBuilder should overrride should_build function in order to correctly trigger build_image function in an environment that docker daemon is not running.

What changes were proposed in this pull request?

Make NoOpBuilder override should_build function.

How was this patch tested?

Test workflow:

from flytekit.image_spec.noop_builder import NoOpBuilder
from flytekit import task, workflow, ImageSpec

image_spec = ImageSpec(
    name="test_image",
    builder="noop",
    base_image="localhost:30000/test_image:latest",
    registry="ghcr.io/not_exist_registry"
    
)

@task(container_image=image_spec)
def task_1(message: str) -> str:
    print(message)
    return message

@workflow
def wf() -> str:
    return task_1("hello")

We define a docker registry in image_spec that is not existed, and we expect that the SDK will still use the image user defined without actually communicating with the docker registry. After remote running the workflow, the SDK will use the user defined image as expected.
截圖 2025-08-11 上午11 44 59

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Summary by Bito

This pull request adds a new method, should_build, to the NoOpBuilder class, fixing a bug by ensuring it consistently returns True. It enhances the build_image method to function even when the Docker daemon is down and improves the testing suite to validate the NoOpBuilder's functionality across various environments, ensuring better reliability and behavior.

pingsutw
pingsutw previously approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

machichima
machichima reviewed Aug 14, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Aug 16, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.51%. Comparing base (eb5a67f) to head (a2919cb).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3311      +/-   ##
==========================================
+ Coverage   85.26%   92.51%   +7.25%     
==========================================
  Files         386        7     -379     
  Lines       30276      508   -29768     
  Branches     2969        0    -2969     
==========================================
- Hits        25814      470   -25344     
+ Misses       3615       38    -3577     
+ Partials      847        0     -847

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@popojk popojk requested a review from machichima August 16, 2025 04:12
machichima
machichima approved these changes Aug 16, 2025
View reviewed changes
Copy link
Member

@machichima machichima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pingsutw pingsutw merged commit fb52d88 into flyteorg:master Aug 16, 2025
228 of 230 checks passed
Atharva1723 pushed a commit to Atharva1723/flytekit that referenced this pull request Oct 5, 2025
@popojk @Atharva1723
[BUG] ImageSpec NoOpBuilder should always return True while calling s…
4c30e93 
…hould_build function (flyteorg#3311)

Signed-off-by: Alex Wu <[email protected]>
Signed-off-by: Atharva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pingsutw pingsutw pingsutw approved these changes

@machichima machichima machichima approved these changes

@wild-endeavor wild-endeavor Awaiting requested review from wild-endeavor wild-endeavor is a code owner

@kumare3 kumare3 Awaiting requested review from kumare3 kumare3 is a code owner

@eapolinario eapolinario Awaiting requested review from eapolinario

@cosmicBboy cosmicBboy Awaiting requested review from cosmicBboy cosmicBboy is a code owner

@samhita-alla samhita-alla Awaiting requested review from samhita-alla samhita-alla is a code owner

@davidmirror-ops davidmirror-ops Awaiting requested review from davidmirror-ops davidmirror-ops is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] ImageSpec NoOpBuilder should always return True while calling should_build function

3 participants

@popojk @pingsutw @machichima