Handle None in sorted bound_inputs conditionally #3317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
pingsutw
requested review from
cosmicBboy,
davidmirror-ops,
eapolinario,
kumare3,
samhita-alla and
wild-endeavor
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3317 +/- ##
==========================================
- Coverage 79.42% 75.77% -3.66%
==========================================
Files 215 215
Lines 22517 22517
Branches 2950 2950
==========================================
- Hits 17885 17062 -823
- Misses 3804 4596 +792
- Partials 828 859 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
wild-endeavor
approved these changes
Aug 21, 2025
Atharva1723
pushed a commit
to Atharva1723/flytekit
that referenced
this pull request
Oct 5, 2025
Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Atharva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#3292 (comment)
Why are the changes needed?
failed to compile if bound_inputs is none
What changes were proposed in this pull request?
Only sort the inputs when it's not none
How was this patch tested?
unit test
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This pull request enhances the workflow model by improving the handling of bound inputs, updating the flyteidl dependency for better flexibility, and refining the sorting logic for None values. A new unit test has been added to ensure correct behavior of ArrayNode without bound inputs.