Return nil if ResourceMeta is nil when deleting the node (#310)

pingsutw · web-flow · commit 1329476bf918 · 2023-03-01T10:19:08.000-06:00
* wip

Signed-off-by: Kevin Su &lt;pingsutw@apache.org&gt;

* wip

Signed-off-by: Kevin Su &lt;pingsutw@apache.org&gt;

* wip

Signed-off-by: Kevin Su &lt;pingsutw@apache.org&gt;

* transition to failed state if task isn't created

Signed-off-by: Kevin Su &lt;pingsutw@apache.org&gt;

* wip

Signed-off-by: Kevin Su &lt;pingsutw@apache.org&gt;

* nit

Signed-off-by: Kevin Su &lt;pingsutw@apache.org&gt;

* fix

Signed-off-by: Kevin Su &lt;pingsutw@apache.org&gt;

* fix

Signed-off-by: Kevin Su &lt;pingsutw@apache.org&gt;

---------

Signed-off-by: Kevin Su &lt;pingsutw@apache.org&gt;
diff --git a/go/tasks/plugins/webapi/databricks/plugin.go b/go/tasks/plugins/webapi/databricks/plugin.go
@@ -183,6 +183,9 @@ func (p Plugin) Get(ctx context.Context, taskCtx webapi.GetContext) (latest weba
 }
 
 func (p Plugin) Delete(ctx context.Context, taskCtx webapi.DeleteContext) error {
+	if taskCtx.ResourceMeta() == nil {
+		return nil
+	}
 	exec := taskCtx.ResourceMeta().(ResourceMetaWrapper)
 	req, err := buildRequest(post, nil, p.cfg.databricksEndpoint,
 		p.cfg.DatabricksInstance, exec.Token, exec.RunID, true)
diff --git a/go/tasks/plugins/webapi/snowflake/plugin.go b/go/tasks/plugins/webapi/snowflake/plugin.go
@@ -167,6 +167,9 @@ func (p Plugin) Get(ctx context.Context, taskCtx webapi.GetContext) (latest weba
 }
 
 func (p Plugin) Delete(ctx context.Context, taskCtx webapi.DeleteContext) error {
+	if taskCtx.ResourceMeta() == nil {
+		return nil
+	}
 	exec := taskCtx.ResourceMeta().(*ResourceMetaWrapper)
 	req, err := buildRequest(post, QueryInfo{}, p.cfg.snowflakeEndpoint,
 		exec.Account, exec.Token, exec.QueryID, true)

Original file line number	Diff line number	Diff line change
`@@ -183,6 +183,9 @@ func (p Plugin) Get(ctx context.Context, taskCtx webapi.GetContext) (latest weba`
`183`	`183`	`}`
`184`	`184`
`185`	`185`	`func (p Plugin) Delete(ctx context.Context, taskCtx webapi.DeleteContext) error {`
	`186`	`+ if taskCtx.ResourceMeta() == nil {`
	`187`	`+ return nil`
	`188`	`+ }`
`186`	`189`	`exec := taskCtx.ResourceMeta().(ResourceMetaWrapper)`
`187`	`190`	`req, err := buildRequest(post, nil, p.cfg.databricksEndpoint,`
`188`	`191`	`p.cfg.DatabricksInstance, exec.Token, exec.RunID, true)`
Original file line number	Diff line number	Diff line change
`@@ -167,6 +167,9 @@ func (p Plugin) Get(ctx context.Context, taskCtx webapi.GetContext) (latest weba`
`167`	`167`	`}`
`168`	`168`
`169`	`169`	`func (p Plugin) Delete(ctx context.Context, taskCtx webapi.DeleteContext) error {`
	`170`	`+ if taskCtx.ResourceMeta() == nil {`
	`171`	`+ return nil`
	`172`	`+ }`
`170`	`173`	`exec := taskCtx.ResourceMeta().(*ResourceMetaWrapper)`
`171`	`174`	`req, err := buildRequest(post, QueryInfo{}, p.cfg.snowflakeEndpoint,`
`172`	`175`	`exec.Account, exec.Token, exec.QueryID, true)`