Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Commit be833e2

Browse files
ByronHsubyhsu
andauthored
Remove chief!=0 or ps!=0 assertion in tensorflow (#327)
Signed-off-by: byhsu <byhsu@linkedin.com> Co-authored-by: byhsu <byhsu@linkedin.com>
1 parent 114645a commit be833e2

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

go/tasks/plugins/k8s/kfoperators/tensorflow/tensorflow.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,6 @@ func (tensorflowOperatorResourceHandler) BuildResource(ctx context.Context, task
7575
if workers == 0 {
7676
return nil, fmt.Errorf("number of worker should be more then 0")
7777
}
78-
if psReplicas == 0 && chiefReplicas == 0 {
79-
return nil, fmt.Errorf("either number of chief or parameter servers needs to be be more then 0")
80-
}
8178

8279
jobSpec := kubeflowv1.TFJobSpec{
8380
TFReplicaSpecs: map[commonOp.ReplicaType]*commonOp.ReplicaSpec{},

go/tasks/plugins/k8s/kfoperators/tensorflow/tensorflow_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,6 @@ func TestReplicaCounts(t *testing.T) {
383383
notContains []commonOp.ReplicaType
384384
}{
385385
{"NoWorkers", 1, 1, 0, true, nil, nil},
386-
{"NoChiefOrPS", 0, 0, 1, true, nil, nil},
387386
{"SingleChief", 1, 0, 1, false,
388387
[]commonOp.ReplicaType{kubeflowv1.TFJobReplicaTypeChief, kubeflowv1.TFJobReplicaTypeWorker},
389388
[]commonOp.ReplicaType{kubeflowv1.TFJobReplicaTypePS}},

0 commit comments

Comments
 (0)