Skip to content

Commit 1ed2ceb

Browse files
committed
fix verbosity plus additional debug output
1 parent a1eb45b commit 1ed2ceb

File tree

3 files changed

+24
-7
lines changed

3 files changed

+24
-7
lines changed

cmake/genjava-catkin-api.cmake.em

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,19 +30,35 @@ macro(generate_rosjava_messages)
3030
message(FATAL_ERROR "generate_rosjava_messages() called with unused arguments: ${ARG_UNPARSED_ARGUMENTS}")
3131
endif()
3232
catkin_rosjava_env_setup()
33+
message(STATUS "ROS_GRADLE_VERBOSE: ${ROS_GRADLE_VERBOSE}")
34+
message(STATUS "ROS_MAVEN_DEPLOYMENT_REPOSITORY: ${ROS_MAVEN_DEPLOYMENT_REPOSITORY}")
35+
message(STATUS "ROS_MAVEN_REPOSITORY: ${ROS_MAVEN_REPOSITORY}")
36+
message(STATUS "GRADLE_USER_HOME: ${GRADLE_USER_HOME}")
3337
set(ROS_GRADLE_VERBOSE $ENV{ROS_GRADLE_VERBOSE})
3438
if(ROS_GRADLE_VERBOSE)
3539
set(verbosity "--verbosity")
3640
else()
3741
set(verbosity "")
3842
endif()
43+
set(avoid_rebuilding "")
44+
#set(avoid_rebuilding "--avoid-rebuilding")
3945
string(REPLACE ";" " " package_list "${ARG_PACKAGES}")
4046

47+
message(STATUS "#### ${PROJECT_NAME}_generate_artifacts ####")
48+
message(STATUS "PROJECT_NAME: ${PROJECT_NAME}")
49+
message(STATUS "CATKIN_ENV: ${CATKIN_ENV}")
50+
message(STATUS "PYTHON_EXECUTABLE: ${PYTHON_EXECUTABLE}")
51+
message(STATUS "GENJAVA_MESSAGE_ARTIFACTS_BIN: ${GENJAVA_MESSAGE_ARTIFACTS_BIN}")
52+
message(STATUS "verbosity: ${verbosity}")
53+
message(STATUS "avoid_rebuilding: ${avoid_rebuilding}")
54+
message(STATUS "CMAKE_CURRENT_BINARY_DIR: ${CMAKE_CURRENT_BINARY_DIR}")
55+
message(STATUS "ARG_PACKAGES: ${ARG_PACKAGES}")
56+
message(STATUS "package_list: ${package_list}")
4157
add_custom_target(${PROJECT_NAME}_generate_artifacts
4258
ALL
4359
COMMAND ${CATKIN_ENV} ${PYTHON_EXECUTABLE} ${GENJAVA_MESSAGE_ARTIFACTS_BIN}
4460
${verbosity}
45-
--avoid-rebuilding
61+
${avoid_rebuilding}
4662
-o ${CMAKE_CURRENT_BINARY_DIR}
4763
-p ${ARG_PACKAGES} # this has to be a list argument so it separates each arg (not a single string!)
4864
DEPENDS

src/genjava/genjava_main.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ def main(argv):
7777
changed and so forth.
7878
'''
7979
args = parse_arguments(argv[1:])
80-
#print("genjava %s/%s" % (args.package, args.message))
80+
print("genjava.main %s" % (args))
8181
if not args.compile:
8282
gradle_project.create(args.package, args.output_dir)
8383
else:
@@ -88,7 +88,7 @@ def standalone_parse_arguments(argv):
8888
parser = argparse.ArgumentParser(description='Generate artifacts for any/all discoverable message packages.')
8989
parser.add_argument('-p', '--packages', action='store', nargs='*', default=[], help='a list of packages to generate artifacts for')
9090
parser.add_argument('-o', '--output-dir', action='store', default='build', help='output directory for the java code (e.g. build/foo_msgs)')
91-
parser.add_argument('-v', '--verbose', default=False, action='store_true', help='enable verbosity in debugging (false)')
91+
parser.add_argument('-v', '--verbosity', default=False, action='store_true', help='enable verbosity in debugging (false)')
9292
parser.add_argument('-f', '--fakeit', default=False, action='store_true', help='dont build, just list the packages it would build (false)')
9393
parser.add_argument('-a', '--avoid-rebuilding', default=False, action='store_true', help='avoid rebuilding if the working directory is already present (false)')
9494
parsed_arguments = parser.parse_args(argv)
@@ -102,7 +102,7 @@ def standalone_main(argv):
102102
generate artifacts for.
103103
'''
104104
args = standalone_parse_arguments(argv[1:])
105-
#print("genjava %s/%s/%s" % (args.package, args.output_dir, args.verbose))
105+
print("genjava.standalone_main %s" % (args))
106106

107107
sorted_package_tuples = rosjava_build_tools.catkin.index_message_package_dependencies_from_local_environment(package_name_list=args.packages)
108108

@@ -111,7 +111,7 @@ def standalone_main(argv):
111111
did_not_rebuild_these_packages = []
112112
if not args.fakeit:
113113
for unused_relative_path, p in sorted_package_tuples:
114-
result = gradle_project.standalone_create_and_build(p.name, args.output_dir, args.verbose, args.avoid_rebuilding)
114+
result = gradle_project.standalone_create_and_build(p.name, args.output_dir, args.verbosity, args.avoid_rebuilding)
115115
if not result:
116116
did_not_rebuild_these_packages.append(p.name)
117117
if did_not_rebuild_these_packages:

src/genjava/gradle_project.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,7 @@ def create(msg_pkg_name, output_dir):
152152
raise IOError("could not find %s among message packages. Does the that package have a <build_depend> on message_generation in its package.xml?" % msg_pkg_name)
153153

154154
msg_dependencies = create_dependency_string(msg_pkg_name, msg_package_index)
155+
print("msg_dependencies: %s" %msg_dependencies)
155156

156157
create_gradle_wrapper(genjava_gradle_dir)
157158
pkg_directory = os.path.abspath(os.path.dirname(msg_package_index[msg_pkg_name].filename))
@@ -171,7 +172,7 @@ def build(msg_pkg_name, output_dir, verbosity):
171172
cmd = ['./gradlew']
172173
if not verbosity:
173174
cmd.append('--quiet')
174-
#print("COMMAND........................%s" % cmd)
175+
print("COMMAND build ........................%s" % cmd)
175176
subprocess.call(cmd, stderr=subprocess.STDOUT,)
176177

177178

@@ -195,6 +196,6 @@ def standalone_create_and_build(msg_pkg_name, output_dir, verbosity, avoid_rebui
195196
cmd = [gradle_wrapper, '-p', working_directory]
196197
if not verbosity:
197198
cmd.append('--quiet')
198-
#print("COMMAND........................%s" % cmd)
199+
print("COMMAND standalone_create_and_build ........................%s" % cmd)
199200
subprocess.call(cmd, stderr=subprocess.STDOUT,)
200201
return True

0 commit comments

Comments
 (0)