Skip to content

Commit 8e677ae

Browse files
[9.1.0] Add deprecation warning to --build_python_zip (bazelbuild#28939)
Fork of bazelbuild#28527. Fixes bazelbuild#28528. <!-- Thank you for contributing to Bazel! Please read the contribution guidelines: https://bazel.build/contribute.html --> ### Description <!-- Please provide a brief summary of the changes in this PR. --> ### Motivation <!-- Why is this change important? Does it fix a specific bug or add a new feature? If this PR fixes an existing issue, please link it here (e.g. "Fixes bazelbuild#1234"). --> ### Build API Changes <!-- Does this PR affect the Build API? (e.g. Starlark API, providers, command-line flags, native rules) If yes, please answer the following: 1. Has this been discussed in a design doc or issue? (Please link it) 2. Is the change backward compatible? 3. If it's a breaking change, what is the migration plan? --> No ### Checklist - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). ### Release Notes <!-- If this is a new feature, please add 'RELNOTES[NEW]: <description>' here. If this is a breaking change, please add 'RELNOTES[INC]: <reason>' here. If this change should be mentioned in release notes, please add 'RELNOTES: <reason>' here. --> RELNOTES: None Commit bazelbuild@51c8fc7 Co-authored-by: Greg <gregestren@users.noreply.github.com>
1 parent 3518fef commit 8e677ae

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

src/main/java/com/google/devtools/build/lib/rules/python/PythonOptions.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,12 @@ public class PythonOptions extends FragmentOptions {
3535
@Option(
3636
name = "build_python_zip",
3737
defaultValue = "auto",
38-
documentationCategory = OptionDocumentationCategory.OUTPUT_PARAMETERS,
39-
effectTags = {OptionEffectTag.AFFECTS_OUTPUTS},
40-
help = "Build python executable zip; on on Windows, off on other platforms")
38+
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
39+
effectTags = {OptionEffectTag.NO_OP},
40+
deprecationWarning =
41+
"The '--no' prefix is no longer supported for this flag. Please use"
42+
+ " --build_python_zip=false instead.",
43+
help = "Deprecated. No-op.")
4144
public TriState buildPythonZip;
4245

4346
@Option(

0 commit comments

Comments
 (0)