Skip to content

Commit 86d615c

Browse files
Merge pull request openstack-k8s-operators#938 from bogdando/hugepages_config
Add standalone tripleo param to config hugepages
2 parents ebe7910 + 85a9c2a commit 86d615c

File tree

8 files changed

+35
-1
lines changed

8 files changed

+35
-1
lines changed

devsetup/Makefile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ HEAT_SERVICE_ENABLED ?= true
8080
EDPM_TOTAL_NODES ?= 1
8181
RH_REGISTRY_USER ?= ""
8282
RH_REGISTRY_PWD ?= ""
83+
EDPM_CONFIGURE_HUGEPAGES ?= false
8384
EDPM_COMPUTE_CEPH_ENABLED ?= true
8485
EDPM_COMPUTE_CELLS ?= 1
8586
EDPM_COMPUTE_CEPH_NOVA ?= true
@@ -493,6 +494,7 @@ tripleo_deploy: export COMPUTE_CELLS=${EDPM_COMPUTE_CELLS}
493494
tripleo_deploy: export REGISTRY_USER ?= ${RH_REGISTRY_USER}
494495
tripleo_deploy: export REGISTRY_PWD ?= ${RH_REGISTRY_PWD}
495496
tripleo_deploy: export COMPUTE_CEPH_ENABLED=${EDPM_COMPUTE_CEPH_ENABLED}
497+
tripleo_deploy: export CONFIGURE_HUGEPAGES=${EDPM_CONFIGURE_HUGEPAGES}
496498
tripleo_deploy: export COMPUTE_CEPH_NOVA=${EDPM_COMPUTE_CEPH_NOVA}
497499
tripleo_deploy: export TRIPLEO_NETWORKING=${EDPM_CONFIGURE_NETWORKING}
498500
tripleo_deploy: export TRIPLEO_ATTACH_EXTNET=${EDPM_ATTACH_EXTNET}
@@ -519,6 +521,7 @@ standalone_deploy: export MANILA_ENABLED=${MANILA_SERVICE_ENABLED}
519521
standalone_deploy: export HEAT_ENABLED=${HEAT_SERVICE_ENABLED}
520522
standalone_deploy: export CLOUD_DOMAIN=${DNS_DOMAIN}
521523
standalone_deploy: export COMPUTE_CEPH_ENABLED=${EDPM_COMPUTE_CEPH_ENABLED}
524+
standalone_deploy: export CONFIGURE_HUGEPAGES=${EDPM_CONFIGURE_HUGEPAGES}
522525
standalone_deploy: export COMPUTE_CEPH_NOVA=${EDPM_COMPUTE_CEPH_NOVA}
523526
standalone_deploy: export COMPUTE_SRIOV_ENABLED=${EDPM_COMPUTE_SRIOV_ENABLED}
524527
standalone_deploy: export COMPUTE_DHCP_AGENT_ENABLED=${EDPM_COMPUTE_DHCP_AGENT_ENABLED}

devsetup/scripts/standalone.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ CLEANUP_DIR_CMD=${CLEANUP_DIR_CMD:-"rm -Rf"}
4444
EDPM_COMPUTE_VCPUS=${COMPUTE_VCPUS:-8}
4545
EDPM_COMPUTE_RAM=${COMPUTE_RAM:-20}
4646
EDPM_COMPUTE_DISK_SIZE=${COMPUTE_DISK_SIZE:-70}
47+
EDPM_CONFIGURE_HUGEPAGES=${CONFIGURE_HUGEPAGES:-false}
4748
EDPM_COMPUTE_CEPH_ENABLED=${COMPUTE_CEPH_ENABLED:-true}
4849
EDPM_COMPUTE_CEPH_NOVA=${COMPUTE_CEPH_NOVA:-true}
4950
EDPM_COMPUTE_SRIOV_ENABLED=${COMPUTE_SRIOV_ENABLED:-true}
@@ -112,6 +113,7 @@ __EOF__
112113
export HOST_PRIMARY_RESOLV_CONF_ENTRY=${HOST_PRIMARY_RESOLV_CONF_ENTRY}
113114
export INTERFACE_MTU=${INTERFACE_MTU:-1500}
114115
export NTP_SERVER=${NTP_SERVER:-"pool.ntp.org"}
116+
export EDPM_CONFIGURE_HUGEPAGES=${EDPM_CONFIGURE_HUGEPAGES:-false}
115117
export EDPM_COMPUTE_CEPH_ENABLED=${EDPM_COMPUTE_CEPH_ENABLED:-true}
116118
export EDPM_COMPUTE_CEPH_NOVA=${EDPM_COMPUTE_CEPH_NOVA:-true}
117119
export CEPH_ARGS="${CEPH_ARGS:--e \$HOME/deployed_ceph.yaml -e /usr/share/openstack-tripleo-heat-templates/environments/cephadm/cephadm-rbd-only.yaml}"
@@ -230,6 +232,7 @@ scp $SSH_OPT ${MY_TMP_DIR}/net_config.yaml root@$IP:/tmp/net_config.yaml
230232
scp $SSH_OPT ${MY_TMP_DIR}/network_data.yaml root@$IP:/tmp/network_data.yaml
231233
scp $SSH_OPT ${MY_TMP_DIR}/deployed_network.yaml root@$IP:/tmp/deployed_network.yaml
232234
scp $SSH_OPT ${MY_TMP_DIR}/Standalone.yaml root@$IP:/tmp/Standalone.yaml
235+
scp $SSH_OPT ${SCRIPTPATH}/../standalone/hugepages.yaml root@$IP:hugepages.yaml
233236
[[ "$EDPM_COMPUTE_CEPH_ENABLED" == "true" ]] && scp $SSH_OPT standalone/ceph.sh root@$IP:/tmp/ceph.sh
234237
scp $SSH_OPT standalone/openstack.sh root@$IP:/tmp/openstack.sh
235238
scp $SSH_OPT standalone/post_config/ironic.sh root@$IP:/tmp/ironic_post.sh

devsetup/scripts/tripleo.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ MANILA_ENABLED=${MANILA_ENABLED:-true}
3838
OCTAVIA_ENABLED=${OCTAVIA_ENABLED:-false}
3939
TELEMETRY_ENABLED=${TELEMETRY_ENABLED:-true}
4040
TLSE_ENABLED=${TLSE_ENABLED:-false}
41+
EDPM_CONFIGURE_HUGEPAGES=${CONFIGURE_HUGEPAGES:-false}
4142

4243
if [[ ! -f $SSH_KEY_FILE ]]; then
4344
echo "$SSH_KEY_FILE is missing"
@@ -89,6 +90,7 @@ export INTERFACE_MTU=${INTERFACE_MTU:-1500}
8990
export NTP_SERVER=${NTP_SERVER:-"pool.ntp.org"}
9091
export IP=${IP}
9192
export GATEWAY=${GATEWAY}
93+
export EDPM_CONFIGURE_HUGEPAGES=${EDPM_CONFIGURE_HUGEPAGES:-false}
9294
export EDPM_COMPUTE_CEPH_ENABLED=${COMPUTE_CEPH_ENABLED:-false}
9395
export EDPM_COMPUTE_CEPH_NOVA=${COMPUTE_CEPH_NOVA:-false}
9496
export CEPH_ARGS="${CEPH_ARGS:--e \$HOME/deployed_ceph.yaml -e /usr/share/openstack-tripleo-heat-templates/environments/cephadm/cephadm-rbd-only.yaml}"
@@ -247,6 +249,7 @@ scp $SSH_OPT ${SCRIPTPATH}/../tripleo/hieradata_overrides_undercloud.yaml zuul@$
247249
scp $SSH_OPT ${SCRIPTPATH}/../tripleo/undercloud-parameter-defaults.yaml zuul@$IP:undercloud-parameter-defaults.yaml
248250
scp $SSH_OPT ${MY_TMP_DIR}/undercloud.conf zuul@$IP:undercloud.conf
249251
scp $SSH_OPT ${SCRIPTPATH}/../tripleo/nova_noceph.yaml zuul@$IP:nova_noceph.yaml
252+
scp $SSH_OPT ${SCRIPTPATH}/../tripleo/hugepages.yaml zuul@$IP:hugepages.yaml
250253
if [ $EDPM_COMPUTE_CELLS -gt 1 ]; then
251254
for cell in $(seq 0 $(( EDPM_COMPUTE_CELLS - 1))); do
252255
scp $SSH_OPT ${MY_TMP_DIR}/vips_data${cell}.yaml zuul@$IP:vips_data${cell}.yaml

devsetup/standalone/hugepages.yaml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
---
2+
parameter_defaults:
3+
NovaSchedulerEnabledFilters:
4+
- ComputeFilter
5+
- ComputeCapabilitiesFilter
6+
- ImagePropertiesFilter
7+
- ServerGroupAntiAffinityFilter
8+
- ServerGroupAffinityFilter
9+
- PciPassthroughFilter
10+
- NUMATopologyFilter
11+
StandaloneParameters:
12+
NovaReservedHugePages: ["node:0,size:2MB,count:1"]
13+
KernelArgsDeferReboot: true
14+
KernelArgs: "default_hugepagesz=2M hugepagesz=2M hugepages=258"

devsetup/standalone/openstack.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
# under the License.
1616
set -ex
1717

18+
EDPM_CONFIGURE_HUGEPAGES=${EDPM_CONFIGURE_HUGEPAGES:-false}
1819
EDPM_COMPUTE_CEPH_ENABLED=${EDPM_COMPUTE_CEPH_ENABLED:-true}
1920
EDPM_COMPUTE_SRIOV_ENABLED=${EDPM_COMPUTE_SRIOV_ENABLED:-true}
2021
EDPM_COMPUTE_DHCP_AGENT_ENABLED=${EDPM_COMPUTE_DHCP_AGENT_ENABLED:-true}
@@ -178,7 +179,10 @@ if [ "$EDPM_COMPUTE_SRIOV_ENABLED" = "true" ] ; then
178179
ENV_ARGS+=" -e /usr/share/openstack-tripleo-heat-templates/environments/services/neutron-ovn-sriov.yaml"
179180
ENV_ARGS+=" -e $HOME/sriov_template.yaml"
180181
fi
181-
182+
# NOTE: cannot use both TLSe and hugepages as the node with freeipa cannot survive required reboot
183+
if [ "$EDPM_CONFIGURE_HUGEPAGES" = "true" ] && [ "$TLSE_ENABLED" != "true" ] ; then
184+
ENV_ARGS+=" -e $HOME/hugepages.yaml"
185+
fi
182186
if [ "$SWIFT_REPLICATED" = "true" ]; then
183187
cat <<EOF >> standalone_parameters.yaml
184188
SwiftReplicas: 3

devsetup/standalone/role.j2

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
- OS::TripleO::Services::AodhListener
3838
- OS::TripleO::Services::AodhNotifier
3939
- OS::TripleO::Services::AuditD
40+
- OS::TripleO::Services::BootParams
4041
- OS::TripleO::Services::BarbicanApi
4142
- OS::TripleO::Services::BarbicanBackendDogtag
4243
- OS::TripleO::Services::BarbicanBackendKmip

devsetup/tripleo/hugepages.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
../standalone/hugepages.yaml

devsetup/tripleo/tripleo_install.sh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,11 @@ if [ "$TRIPLEO_ATTACH_EXTNET" = "false" ]; then
170170
sed -i "/subnet: external_subnet/d" $ROLES_FILE
171171
fi
172172

173+
# NOTE: cannot use both TLSe and hugepages as the node with freeipa cannot survive required reboot
174+
if [ "$EDPM_CONFIGURE_HUGEPAGES" = "true" ] && [ "$TLSE_ENABLED" != "true" ] ; then
175+
ENV_ARGS+=" -e $HOME/hugepages.yaml"
176+
fi
177+
173178
if [ "$TLSE_ENABLED" = "true" ]; then
174179
ENV_ARGS+=" -e /usr/share/openstack-tripleo-heat-templates/environments/ssl/tls-everywhere-endpoints-dns.yaml"
175180
ENV_ARGS+=" -e /usr/share/openstack-tripleo-heat-templates/environments/services/haproxy-public-tls-certmonger.yaml"

0 commit comments

Comments
 (0)