Skip to content

Commit 28665ef

Browse files
committed
Fixed indexed column grammar: sorting can be left unspecified
1 parent 18f2b5b commit 28665ef

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

dev/statement_serializer.h

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1833,14 +1833,12 @@ namespace sqlite_orm {
18331833
}
18341834
if (statement._order) {
18351835
switch (statement._order) {
1836-
case -1:
1837-
ss << " DESC";
1838-
break;
18391836
case 1:
18401837
ss << " ASC";
18411838
break;
1842-
default:
1843-
throw std::system_error{orm_error_code::incorrect_order};
1839+
case -1:
1840+
ss << " DESC";
1841+
break;
18441842
}
18451843
}
18461844
return ss.str();

include/sqlite_orm/sqlite_orm.h

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21217,14 +21217,12 @@ namespace sqlite_orm {
2121721217
}
2121821218
if (statement._order) {
2121921219
switch (statement._order) {
21220-
case -1:
21221-
ss << " DESC";
21222-
break;
2122321220
case 1:
2122421221
ss << " ASC";
2122521222
break;
21226-
default:
21227-
throw std::system_error{orm_error_code::incorrect_order};
21223+
case -1:
21224+
ss << " DESC";
21225+
break;
2122821226
}
2122921227
}
2123021228
return ss.str();

tests/schema/index_tests.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ TEST_CASE("index") {
1414
auto storage = make_storage({}, make_index("id_index", &User::id), table);
1515
REQUIRE_NOTHROW(storage.sync_schema());
1616
}
17+
SECTION("unspecified") {
18+
auto storage = make_storage({}, make_index("id_index", indexed_column(&User::id)), table);
19+
REQUIRE_NOTHROW(storage.sync_schema());
20+
}
1721
SECTION("asc") {
1822
auto storage = make_storage({}, make_index("id_index", indexed_column(&User::id).asc()), table);
1923
REQUIRE_NOTHROW(storage.sync_schema());

0 commit comments

Comments
 (0)