Add option to configure basic map type for Mapy.cz

Author: fnesveda

CHANGELOG.md

@@ -1,6 +1,11 @@
 Changelog
 =========
 
+[2.1.0](../../releases/tag/v2.1.0) - 2025-03-25
+-----------------------------------------------
+### Added
+- option to configure the basic map type for Mapy.cz
+
 [2.0.0](../../releases/tag/v2.0.0) - 2025-03-19
 -----------------------------------------------
 ### Added

src/_locales/cs/messages.json

@@ -2,6 +2,8 @@
 	"extension_name": {"message": "MapSwitcher"},
 	"extension_description": {"message": "Přidá do různých mapových služeb tlačítka pro otevření stejné pozice na mapě v jiných mapových službách."},
 	"visible_buttons_header": {"message": "Zobrazit tlačítka na přepínání do"},
+	"button_options_header": {"message": "Možnosti tlačítek"},
+	"mapy_cz_use_outdoor_for_basic": {"message": "Použít Turistickou mapu místo Základní mapy v Mapy.cz"},
 	"GOOGLE_MAPS": {"message": "Mapy Google"},
 	"MAPY_CZ": {"message": "Mapy.cz"},
 	"OPEN_STREET_MAP": {"message": "OpenStreetMap"}

src/_locales/en/messages.json

@@ -2,6 +2,8 @@
 	"extension_name": {"message": "MapSwitcher"},
 	"extension_description": {"message" :"Adds buttons to various map services for opening the same location in different map services."},
 	"visible_buttons_header": {"message": "Show buttons to switch to"},
+	"button_options_header": {"message": "Button options"},
+	"mapy_cz_use_outdoor_for_basic": {"message": "Use \"Outdoor\" instead of \"Basic\" map in Mapy.cz"},
 	"GOOGLE_MAPS": {"message": "Google Maps"},
 	"MAPY_CZ": {"message": "Mapy.cz"},
 	"OPEN_STREET_MAP": {"message": "OpenStreetMap"}

src/manifest.json

@@ -3,7 +3,7 @@
 	"name": "__MSG_extension_name__",
 	"description": "__MSG_extension_description__",
 	"default_locale": "en",
-	"version": "2.0.0",
+	"version": "2.1.0",
 	"browser_specific_settings": {
 		"gecko": {
 			"id": "{0516BC41-6FA3-4326-87FE-7EA9101412FE}"

src/pages/options.html

@@ -42,6 +42,13 @@
 					<span i18n-id="OPEN_STREET_MAP">OpenStreetMap</span>
 				</label>
 			</div>
+			<div class="options-group">
+				<div class="options-group-header" i18n-id="button_options_header">Button options</div>
+				<label>
+					<input type="checkbox" id="mapy-cz-use-outdoor-for-basic">
+					<span i18n-id="mapy_cz_use_outdoor_for_basic">Use "Outdoor" instead of "Basic" map in Mapy.cz</span>
+				</label>
+			</div>
 		</div>
 		<div id="google-maps-opera-warning">
 			If you want this to work on Google Maps in Opera, you need to enable "Allow access to search page results" for this extensions.

src/scripts/js/options.js

@@ -5,6 +5,7 @@ const defaultOptions = {
 		[MAP_SERVICE.MAPY_CZ]: true,
 		[MAP_SERVICE.OPEN_STREET_MAP]: false,
 	},
+	mapyCzUseOutdoorForBasic: true,
 };
 
 // Saves options to chrome.storage.sync, returns a promise to maybe let the user know when it's done
@@ -23,14 +24,17 @@ async function loadOptionsFromStorage() {
 	}
 	if (retrievedStorage.options.optionsVersion === '1.0') {
 		// migrate from version 1.0 to 2.0
-		const migratedOptions = {
-			optionsVersion: "2.0",
-			shownButtons: {
-				[MAP_SERVICE.GOOGLE_MAPS]: retrievedStorage.options.showGMapsButton,
-				[MAP_SERVICE.MAPY_CZ]: retrievedStorage.options.showMapyczButton,
-				[MAP_SERVICE.OPEN_STREET_MAP]: false,
+		const migratedOptions = Object.assign(
+			{},
+			structuredClone(defaultOptions),
+			{
+				shownButtons: {
+					[MAP_SERVICE.GOOGLE_MAPS]: retrievedStorage.options.showGMapsButton,
+					[MAP_SERVICE.MAPY_CZ]: retrievedStorage.options.showMapyczButton,
+					[MAP_SERVICE.OPEN_STREET_MAP]: false,
+				},
 			},
-		};
+		)
 		await chrome.storage.sync.set({ options: migratedOptions });
 		return migratedOptions;
 	}

src/scripts/js/pages/options.js

@@ -5,6 +5,7 @@ async function saveOptionsFromElements() {
 			key,
 			!!document.querySelector(`.show-button-checkbox[data-service="${key}"]`)?.checked,
 		])),
+		mapyCzUseOutdoorForBasic: document.querySelector("#mapy-cz-use-outdoor-for-basic")?.checked,
 	});
 }
 
@@ -18,6 +19,10 @@ async function loadOptionsToElements() {
 			checkbox.checked = !!options.shownButtons[key];
 		}
 	}
+	const mapyCzUseOutdoorForBasicCheckbox = document.querySelector("#mapy-cz-use-outdoor-for-basic");
+	if (mapyCzUseOutdoorForBasicCheckbox) {
+		mapyCzUseOutdoorForBasicCheckbox.checked = !!options.mapyCzUseOutdoorForBasic;
+	}
 }
 
 document.addEventListener("DOMContentLoaded", () => loadOptionsToElements());

src/scripts/js/urls/common.js

@@ -1,8 +1,17 @@
+let loadedOptions = structuredClone(defaultOptions);
+
 const converters = {};
-function registerConverter(service, converter) {
-	converters[service] = converter;
+function registerConverter(service, ConverterClass) {
+	converters[service] = new ConverterClass(loadedOptions);
 }
 
+loadOptionsFromStorage().then((options) => {
+	loadedOptions = options;
+	for (const converter of Object.values(converters)) {
+		converter.updateExtensionOptions(loadedOptions);
+	}
+});
+
 function getConverterForCurrentService() {
 	const service = detectCurrentMapService();
 	if (!service) throw new Error("No map service detected");
@@ -24,3 +33,21 @@ function getDestinationUrl(destination, mapInfo) {
 	if (!converter) return "";
 	return converter.universalToUrl(mapInfo);
 }
+
+class UrlConverter {
+	constructor(extensionOptions) {
+		this.extensionOptions = extensionOptions;
+	}
+	
+	updateExtensionOptions(extensionOptions) {
+		this.extensionOptions = extensionOptions;
+	}
+	
+	universalToUrl(universal) {
+		throw new Error("universalToUrl not implemented");
+	}
+	
+	urlToUniversal(url) {
+		throw new Error("urlToUniversal not implemented");
+	}
+}

src/scripts/js/urls/google_maps.js

@@ -1,5 +1,5 @@
-registerConverter(MAP_SERVICE.GOOGLE_MAPS, {
-	universalToUrl: function (universal) {
+class GoogleMapsUrlConverter extends UrlConverter{
+	universalToUrl(universal) {
 		let data = "";
 		let zoom = universal.zoom + "z";
 
@@ -14,8 +14,9 @@ registerConverter(MAP_SERVICE.GOOGLE_MAPS, {
 		const lat = universal.lat;
 
 		return `https://www.google.com/maps/@${lat},${lon},${zoom}/${data}`;
-	},
-	urlToUniversal: function (url) {
+	}
+	
+	urlToUniversal(url) {
 		// check if maps are in satellite mode, or not
 		// based on https://mstickles.wordpress.com/2015/06/12/gmaps-urls-options/
 		// the URL should be parsed more thoroughly if we wanted to do this properly, but this seems to work fine for our use case
@@ -68,5 +69,7 @@ registerConverter(MAP_SERVICE.GOOGLE_MAPS, {
 			lon: lon,
 			zoom: zoom,
 		};
-	},
-});
+	}
+}
+
+registerConverter(MAP_SERVICE.GOOGLE_MAPS, GoogleMapsUrlConverter);

src/scripts/js/urls/mapy_cz.js

@@ -1,18 +1,19 @@
-registerConverter(MAP_SERVICE.MAPY_CZ, {
-	universalToUrl: function (universal) {
+class MapyCzUrlConverter extends UrlConverter {
+	universalToUrl(universal) {
 		let lon = universal.lon;
 		let lat = universal.lat;
 		let zoom = Math.round(universal.zoom);
 
-		let type = "zakladni";
+		let type = this.extensionOptions.mapyCzUseOutdoorForBasic ? "turisticka" : "zakladni";
 		if (universal.type == "satellite") {
 			type = "letecka";
 		}
 
 		// put the URL together
 		return `https://www.mapy.cz/${type}?x=${lon}&y=${lat}&z=${zoom}&l=0`;
-	},
-	urlToUniversal: function (url) {
+	}
+	
+	urlToUniversal(url) {
 		// check if maps are in satellite mode, or not
 		let type = "basic";
 		if ((url.indexOf("base=ophoto") >= 0) || (url.indexOf("letecka") >= 0)) {
@@ -29,7 +30,7 @@ registerConverter(MAP_SERVICE.MAPY_CZ, {
 		let zoom = 1;
 
 		// parse the address parameters
-		for (field of addrFields) {
+		for (const field of addrFields) {
 			let par = field.split("=")[0];
 			let val = field.split("=")[1];
 
@@ -51,5 +52,7 @@ registerConverter(MAP_SERVICE.MAPY_CZ, {
 			lon: lon,
 			zoom: zoom,
 		};
-	},
-});
+	}
+}
+
+registerConverter(MAP_SERVICE.MAPY_CZ, MapyCzUrlConverter);