Skip to content

Commit 4ce9163

Browse files
author
Reed Allman
committed
nuke some TODO yey
1 parent 1811b4e commit 4ce9163

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

api/agent/agent.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,7 @@ import (
3232
// TODO herd launch prevention part deux
3333
// TODO storing logs / call can push call over the timeout
3434
// TODO all Datastore methods need to take unit of tenancy (app or route) at least (e.g. not just call id)
35-
// TODO limit the request body length when making calls
3635
// TODO discuss concrete policy for hot launch or timeout / timeout vs time left
37-
// TODO call env need to be map[string][]string to match headers behavior...
3836
// TODO it may be nice to have an interchange type for Dispatch that can have
3937
// all the info we need to build e.g. http req, grpc req, json, etc. so that
4038
// we can easily do e.g. http->grpc, grpc->http, http->json. ofc grpc<->http is
@@ -50,7 +48,6 @@ import (
5048
// end up that the client doesn't get a reply until long after the timeout (b/c of container removal, async it?)
5149
// TODO the call api should fill in all the fields
5250
// TODO the log api should be plaintext (or at least offer it)
53-
// TODO func logger needs to be hanged, dragged and quartered. in reverse order.
5451
// TODO we should probably differentiate ran-but-timeout vs timeout-before-run
5552
// TODO between calls, logs and stderr can contain output/ids from previous call. need elegant solution. grossness.
5653
// TODO if async would store requests (or interchange format) it would be slick, but

0 commit comments

Comments
 (0)