Fix filters again

Author: jepler

shared-bindings/audiofilters/Filter.c

@@ -73,7 +73,7 @@
 static mp_obj_t audiofilters_filter_make_new(const mp_obj_type_t *type, size_t n_args, size_t n_kw, const mp_obj_t *all_args) {
     enum { ARG_filter, ARG_mix, ARG_buffer_size, ARG_sample_rate, ARG_bits_per_sample, ARG_samples_signed, ARG_channel_count, };
     static const mp_arg_t allowed_args[] = {
-        { MP_QSTR_filter, MP_ARG_OBJ | MP_ARG_KW_ONLY, {.u_obj = MP_OBJ_NULL} },
+        { MP_QSTR_filter, MP_ARG_OBJ | MP_ARG_KW_ONLY, {.u_obj = MP_ROM_NONE } },
         { MP_QSTR_mix, MP_ARG_OBJ | MP_ARG_KW_ONLY,  {.u_obj = MP_ROM_INT(1)} },
         { MP_QSTR_buffer_size, MP_ARG_INT | MP_ARG_KW_ONLY, {.u_int = 512} },
         { MP_QSTR_sample_rate, MP_ARG_INT | MP_ARG_KW_ONLY, {.u_int = 8000} },

shared-module/audiofilters/Filter.c

@@ -185,9 +185,6 @@ audioio_get_buffer_result_t audiofilters_filter_get_buffer(audiofilters_filter_o
         channel = 0;
     }
 
-    // get the effect values we need from the BlockInput. These may change at run time so you need to do bounds checking if required
-    mp_float_t mix = MIN(1.0, MAX(synthio_block_slot_get(&self->mix), 0.0));
-
     // Switch our buffers to the other buffer
     self->last_buf_idx = !self->last_buf_idx;
 

tests/circuitpython/audiofilter_filter_blockbiquads.py

@@ -2,6 +2,7 @@
 from audiofilterhelper import synth_test, white8k
 from synthio import BlockBiquad, FilterMode
 
+
 @synth_test
 def basic_filter():
     effect = Filter(

tests/testlib/audiofilterhelper.py

@@ -7,7 +7,7 @@
 
 random.seed(41)
 
-whitedata = array.array('h', [random.randint(-32000, 32000) for i in range(600)])
+whitedata = array.array("h", [random.randint(-32000, 32000) for i in range(600)])
 white8k = RawSample(whitedata, sample_rate=8000)
 
 sinedata = array.array("h", [int(32767 * sin(i * 2 * pi / 600)) for i in range(600)])