chore: polishing

Author: zavakid

crates/http/src/codec/header/header_encoder.rs

@@ -13,7 +13,7 @@
 
 use crate::protocol::{PayloadSize, ResponseHead, SendError};
 
-use bytes::{BufMut, Bytes, BytesMut};
+use bytes::{BufMut, BytesMut};
 
 use http::{HeaderValue, Version, header};
 use std::io;
@@ -74,25 +74,27 @@ impl Encoder<(ResponseHead, PayloadSize)> for HeaderEncoder {
                 }
             },
 
-            PayloadSize::Chunked => match header.headers_mut().get_mut(header::TRANSFER_ENCODING) {
-                Some(value) => *value = unsafe { HeaderValue::from_maybe_shared_unchecked(Bytes::from_static("chunked".as_bytes())) },
-                None => {
-                    header.headers_mut().insert(header::TRANSFER_ENCODING, unsafe {
-                        HeaderValue::from_maybe_shared_unchecked(Bytes::from_static("chunked".as_bytes()))
-                    });
+            PayloadSize::Chunked => {
+                const CHUNKED: HeaderValue = HeaderValue::from_static("chunked");
+
+                match header.headers_mut().get_mut(header::TRANSFER_ENCODING) {
+                    Some(value) => *value = CHUNKED,
+                    None => {
+                        header.headers_mut().insert(header::TRANSFER_ENCODING, CHUNKED);
+                    }
                 }
             },
-            PayloadSize::Empty => match header.headers_mut().get_mut(header::CONTENT_LENGTH) {
-                Some(value) => *value = 0.into(),
-                None => {
-                    const ZERO_VALUE: HeaderValue = HeaderValue::from_static("0");
-                    header.headers_mut().insert(header::CONTENT_LENGTH, ZERO_VALUE);
-                }
+
+            PayloadSize::Empty => if let Some(value) = header.headers_mut().get_mut(header::CONTENT_LENGTH) {
+                *value = 0.into();
+            } else {
+                const ZERO_VALUE: HeaderValue = HeaderValue::from_static("0");
+                header.headers_mut().insert(header::CONTENT_LENGTH, ZERO_VALUE);
             },
         }
 
         // Write all headers
-        for (header_name, header_value) in header.headers().iter() {
+        for (header_name, header_value) in header.headers() {
             dst.put_slice(header_name.as_ref());
             dst.put_slice(b": ");
             dst.put_slice(header_value.as_ref());
@@ -103,7 +105,7 @@ impl Encoder<(ResponseHead, PayloadSize)> for HeaderEncoder {
     }
 }
 
-/// Fast writer implementation for writing to BytesMut.
+/// Fast writer implementation for writing to [`BytesMut`].
 ///
 /// This is an optimization to avoid unnecessary bounds checking when writing
 /// to the bytes buffer, since we've already reserved enough space.

crates/http/src/codec/response_encoder.rs

@@ -30,7 +30,7 @@ use std::io::ErrorKind;
 use tokio_util::codec::Encoder;
 use tracing::error;
 
-/// A encoder for HTTP responses that handles both headers and payload
+/// An encoder for HTTP responses that handles both headers and payload
 ///
 /// The encoder operates in two phases:
 /// 1. Header encoding: Encodes the response headers using [`HeaderEncoder`]
@@ -45,8 +45,9 @@ pub struct ResponseEncoder {
 
 impl ResponseEncoder {
     /// Creates a new `ResponseEncoder` instance
+    #[must_use]
     pub fn new() -> Self {
-        Default::default()
+        ResponseEncoder::default()
     }
 }
 
@@ -88,9 +89,7 @@ impl<D: Buf> Encoder<Message<(ResponseHead, PayloadSize), D>> for ResponseEncode
 
             Message::Payload(payload_item) => {
                 // Get the payload encoder, return error if it doesn't exist
-                let payload_encoder = if let Some(encoder) = &mut self.payload_encoder {
-                    encoder
-                } else {
+                let Some(payload_encoder) = &mut self.payload_encoder else {
                     error!("expect response header but receive payload item");
                     return Err(io::Error::from(ErrorKind::InvalidInput).into());
                 };