chore: using singleton handler

Author: zavakid

crates/http/benches/http_bench.rs

@@ -12,7 +12,6 @@ use std::{
     error::Error,
     io,
     pin::Pin,
-    sync::Arc,
     task::{Context, Poll},
 };
 use std::hint::black_box;
@@ -114,14 +113,14 @@ fn bench_response_encoder(c: &mut Criterion) {
 
 fn bench_http_connection(c: &mut Criterion) {
     let request = REQUEST.as_bytes();
-    let handler = Arc::new(make_handler(test_handler));
+    let handler = make_handler(test_handler);
 
     c.bench_function("process_simple_request", |b| {
         b.iter(|| {
             let mock_io = MockIO::new(request.to_vec());
             let (reader, writer) = (mock_io.clone(), mock_io);
             let connection = HttpConnection::new(reader, writer);
-            block_on(connection.process(handler.clone())).unwrap();
+            block_on(connection.process(&handler)).unwrap();
         });
     });
 }

crates/http/examples/server.rs

@@ -42,7 +42,7 @@ async fn main() {
         tokio::spawn(async move {
             let (reader, writer) = tcp_stream.into_split();
             let connection = HttpConnection::new(reader, writer);
-            match connection.process(handler).await {
+            match connection.process(handler.as_ref()).await {
                 Ok(_) => {
                     info!("finished process, connection shutdown");
                 }

crates/http/src/connection/http_connection.rs

@@ -1,7 +1,6 @@
 use bytes::Bytes;
 use std::error::Error;
 use std::fmt::{Debug, Display};
-use std::sync::Arc;
 
 use futures::StreamExt;
 use http::header::EXPECT;
@@ -54,7 +53,7 @@ where
         }
     }
 
-    pub async fn process<H>(mut self, mut handler: Arc<H>) -> Result<(), HttpError>
+    pub async fn process<H>(mut self, handler: &H) -> Result<(), HttpError>
     where
         H: Handler,
         H::RespBody: Body<Data = Bytes> + Unpin,
@@ -63,7 +62,7 @@ where
         loop {
             match self.framed_read.next().await {
                 Some(Ok(Message::Header((header, payload_size)))) => {
-                    self.do_process(header, payload_size, &mut handler).await?;
+                    self.do_process(header, payload_size, handler).await?;
                 }
 
                 Some(Ok(Message::Payload(PayloadItem::Eof))) => continue,
@@ -93,7 +92,7 @@ where
         }
     }
 
-    async fn do_process<H>(&mut self, header: RequestHeader, payload_size: PayloadSize, handler: &mut Arc<H>) -> Result<(), HttpError>
+    async fn do_process<H>(&mut self, header: RequestHeader, payload_size: PayloadSize, handler: &H) -> Result<(), HttpError>
     where
         H: Handler,
         H::RespBody: Body<Data = Bytes> + Unpin,

crates/http/src/lib.rs

@@ -64,7 +64,7 @@
 //!         tokio::spawn(async move {
 //!             let (reader, writer) = tcp_stream.into_split();
 //!             let connection = HttpConnection::new(reader, writer);
-//!             match connection.process(handler).await {
+//!             match connection.process(handler.as_ref()).await {
 //!                 Ok(_) => {
 //!                     info!("finished process, connection shutdown");
 //!                 }

crates/web/src/server.rs

@@ -169,7 +169,7 @@ impl Server {
                 tcp_stream.set_nodelay(true).unwrap();
                 let (reader, writer) = tcp_stream.into_split();
                 let connection = HttpConnection::new(reader, writer);
-                match connection.process(handler).await {
+                match connection.process(handler.as_ref()).await {
                     Ok(_) => {
                         info!("finished process, connection shutdown");
                     }