vim.diagnostic.goto_{next,prev} are deprecated

[verygitmuchhub]

Hey guys,

probably the wrong place to ask, but I hope someone is just smarter than I am.

:help deprecated reports both vim.diagnostic.goto_next and vim.diagnostic.goto_prev as deprecated. Users should go for vim.diagnostic.jump instead. Right.

In init.lua I have something like:

require('lazy').setup({
  -- ...
  {
    'neovim/nvim-lspconfig',
    -- config = function() ... end
    keys = {
      { '<leader>dk',  vim.diagnostic.goto_prev, desc = '[d]iagnostic goto_prev [k]' },
      { '<leader>dj',  vim.diagnostic.goto_next, desc = '[d]iagnostic goto_next [j]' },
    }
  },
  -- ...
})

I took those from the documentation of https://github.com/neovim/nvim-lspconfig repository. I cannot find any such thing there anymore.

The question is... How do I update these keybindings to use vim.diagnostic.jump function correctly? I tried like everything with two different results:

1. Errors in nvim/lua
2. Errors with Lazy and the keybindings are just absent and no longer exist.

-- e.g.
{ '<leader>dk',  vim.diagnostic.jump({count=-1, float=true}), desc = '[d]iagnostic goto_prev [k]' },

I looked in LazyVim as well where local diagnostic_goto uses goto_next and goto_prev respectively. (https://github.com/LazyVim/LazyVim/blob/main/lua/lazyvim/config/keymaps.lua#L123).

Any hint how to configure that correcty?

Thanks!

[vockers]

By using parentheses ({count=-1, float=true}) you're calling vim.diagnostic.jump and passing the return value instead of passing the function itself.
Wrapping the function call inside a lambda should fix your problem:

{ '<leader>dk', function() vim.diagnostic.jump({count=-1, float=true}) end, desc = '[d]iagnostic goto_prev [k]' },
{ '<leader>dj', function() vim.diagnostic.jump({count=1, float=true}) end, desc = '[d]iagnostic goto_next [j]' },

[verygitmuchhub]

Perfect. Thank you!, especially for the explanation.