fix some errors

Author: folosuru

CMakeLists.txt

@@ -1,6 +1,5 @@
+cmake_minimum_required(VERSION 3.10)
 project(stock_emu CXX)
-set(CMAKE_CXX_STANDARD 20)
-
 add_subdirectory(stock_emu_lib)
 add_subdirectory(test)
 add_subdirectory(preview)

stock_emu_lib/CMakeLists.txt

@@ -9,6 +9,7 @@ add_library(stock_emu_lib STATIC
 target_include_directories(stock_emu_lib PRIVATE ../)
 
 target_compile_options(stock_emu_lib PRIVATE
-    -Wall -O0 -g 
-)
+    -Wall -O0 -g  -Weverything
+    -Wno-c++98-compat -Wno-padded -Wno-exit-time-destructors -Wno-global-constructors
+) 
 

stock_emu_lib/Stock.hpp

@@ -1,4 +1,5 @@
 #pragma once
+#include <cstddef>
 #ifndef INCLUDE_STOCK_HPP_
 #define INCLUDE_STOCK_HPP_
 #include <format>
@@ -7,23 +8,26 @@
 #include <type_traits>
 
 struct StockCount;
-using StockId = int;
+using StockId = size_t;
 using StockCount_data_t = int;
 
 class StockPrice {
 public:
-    constexpr StockPrice(Price price) : price(price) {}
+    constexpr StockPrice(Price price_) : price(price_) {}
 
     constexpr StockPrice() : price(0) {}
 
-    constexpr Price operator*(int amount) const noexcept {
-        return price * amount;
-    }
+    constexpr StockPrice(const StockPrice& p) : price(p.price) {}
 
-    constexpr Price operator*(double amount) const noexcept {
+    constexpr Price operator*(int amount) const noexcept {
         return price * amount;
     }
 
+    /*
+        constexpr Price operator*(double amount) const noexcept {
+            return {price * amount};
+        }
+    */
     constexpr auto operator<=>(const StockPrice& rhs) const {
         return this->price <=> rhs.price;
     }
@@ -91,7 +95,7 @@ class StockHoldingCount {
 
     constexpr StockCount to_StockCount() const {
         return StockCount(value);
-    };
+    }
 
     constexpr StockCount_data_t getValue() const {
         return value;

stock_emu_lib/bot/trader/Trader.cpp

@@ -10,7 +10,7 @@ namespace bot::trader {
 namespace {
 std::random_device seed_gen;
 // std::default_random_engine engine(seed_gen());
-std::default_random_engine engine(64);
+std::default_random_engine engine{64};
 std::uniform_int_distribution<> action_dist(0, 2);
 std::uniform_real_distribution<> amount_dist(0.0, 1.0);
 
@@ -50,7 +50,7 @@ constexpr Money_data_t default_price_value = 100000;
 }  // namespace
 
 void Random::Trade(Trader &trader, StockMarketRef market) {
-    std::uniform_int_distribution<> stock_select(0, market->count() - 1);
+    std::uniform_int_distribution<StockId> stock_select(0, market->count() - 1);
     StockId stock = stock_select(engine);
     auto action = action_dist(engine);
     // auto amount = 0.05 / (amount_dist(engine) + 0.2);
@@ -77,12 +77,15 @@ void Random::Trade(Trader &trader, StockMarketRef market) {
                    // std::cout << "ignore \n" << std::endl;
             break;
         }
+        default: {
+            // unreachable
+        }
     }
 }
 
 void Fundamental::Trade(Trader &trader, StockMarketRef market) {
-    std::discrete_distribution stock_select(market->get_value_dondake_hanareteru().begin(),
-                                            market->get_value_dondake_hanareteru().end());
+    std::discrete_distribution<StockId> stock_select(market->get_value_dondake_hanareteru().begin(),
+                                                     market->get_value_dondake_hanareteru().end());
     StockId stock = stock_select(engine);
     auto board = market->get(stock);
 

stock_emu_lib/money.hpp

@@ -33,7 +33,7 @@ class Money {
 public:
     constexpr Money(Money_data_t value_) : value(value_) {}
 
-    constexpr Money() : value(0) {};
+    constexpr Money() : value(0) {}
 
     // moveする場合、全部受け渡し先に移動
     constexpr Money(Money&& other) : value(0) {
@@ -89,7 +89,7 @@ class Money {
     };
 
 public:
-    money_move_helper move(Price price) {
+    constexpr money_move_helper move(Price price) {
         return {price, *this};
     }
 };

stock_emu_lib/trade/Trade.cpp

@@ -5,12 +5,12 @@
 #include <cstdlib>
 #include <stock_emu_lib/Stock.hpp>
 
-void Trader::sell(StockPrice price, StockCount amount, StockId id, StockMarketRef ref) {
-    (*ref)[id]->LimitOrder_Sell(price, amount, *this);
+void Trader::sell(StockPrice price, StockCount amount, StockId stock_id, StockMarketRef ref) {
+    (*ref)[stock_id]->LimitOrder_Sell(price, amount, *this);
 }
 
-void Trader::buy(StockPrice price, StockCount amount, StockId id, StockMarketRef ref) {
-    (*ref)[id]->LimitOrder_Buy(price, amount, *this);
+void Trader::buy(StockPrice price, StockCount amount, StockId stock_id, StockMarketRef ref) {
+    (*ref)[stock_id]->LimitOrder_Buy(price, amount, *this);
 }
 
 bool TradeBoard::LimitOrder_Sell(StockPrice price, StockCount count, Trader& trader) {
@@ -125,7 +125,7 @@ void TradeBoard::tick() noexcept {
         limit.update_PriceLimit(latest_tick.end);
     }
 
-    sell.limit_queue.destruct(id);
+    sell.limit_queue.destruct();
     buy.limit_queue.destruct();
     if (auto l = getCurrentPrice().lower; l) {
         history.update_current_low(*l, *this);
@@ -145,7 +145,7 @@ void StockMarket::updatePricePerValue(const TradeBoard& ref) {
         std::abs(ref.getHistory().getCurrentPrice().latest.getValue() - ref.StockValue().getValue());
 }
 
-void TradeBoard::sell_limit_destruct::run(std::deque<SellTradeRequest>& q, StockId id) {
+void TradeBoard::sell_limit_destruct::run(std::deque<SellTradeRequest>& q) {
     for (auto& i : q) {
         i.reject();
     }

stock_emu_lib/trade/Trade.hpp

@@ -75,8 +75,8 @@ struct BuyTradeRequest {
     Money money;
     BuyTradeRequest** refer = nullptr;
 
-    BuyTradeRequest(StockCount amount_, Trader& trader_, Money&& money)
-        : amount(amount_), trader(trader_), money(std::move(money)) {}
+    BuyTradeRequest(StockCount amount_, Trader& trader_, Money&& money_)
+        : amount(amount_), trader(trader_), money(std::move(money_)) {}
 
     void reject() {
         money.move(money.as_Price()).to(trader.money);
@@ -150,31 +150,31 @@ struct TradeBoard {
         }
     }
 
-    const auto& getBuyBoard() const {
+    constexpr const auto& getBuyBoard() const {
         return buy;
     }
 
-    const auto& getSellBoard() const {
+    constexpr const auto& getSellBoard() const {
         return sell;
     }
 
-    const auto& StockValue() const {
+    constexpr const auto& StockValue() const {
         return stock_value;
     }
 
     void updateStockValue(StockPrice price, StockMarketRef market);
 
     void tick() noexcept;
 
-    const auto& getHistory() const noexcept {
+    constexpr const auto& getHistory() const noexcept {
         return history;
     }
 
-    const auto& getPriceLimit() const noexcept {
+    constexpr const auto& getPriceLimit() const noexcept {
         return limit;
     }
 
-    const auto& getCurrentPrice() const noexcept {
+    constexpr const auto& getCurrentPrice() const noexcept {
         return history.getCurrentPrice();
     }
 
@@ -199,7 +199,7 @@ struct TradeBoard {
         util::RingQueue<std::deque<Request_t>, 24, limit_destructor_t> limit_queue;
 
         template<class... Args>
-        void add(int expire, StockPrice price, Args&&... arg) {
+        void add(size_t expire, StockPrice price, Args&&... arg) {
             limit_queue.get(expire).emplace_back(std::forward<Args>(arg)...);
             auto* elem = &limit_queue.get(expire).back();
 
@@ -228,7 +228,7 @@ struct TradeBoard {
     };
 
     struct sell_limit_destruct {
-        static void run(std::deque<SellTradeRequest>&, StockId);
+        static void run(std::deque<SellTradeRequest>&);
     };
 
     TradeRequestBoard<BuyTradeRequest, buy_limit_destruct> buy;

stock_emu_lib/trade/TradeHistory.hpp

@@ -29,7 +29,7 @@ struct TradeBoard;
  */
 class TradeBoardHistory {
 public:
-    const auto& getCurrentPrice() const noexcept {
+    constexpr const auto& getCurrentPrice() const noexcept {
         return CurrentStockPrice;
     }