Draft
Conversation
Contributor
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="bcp47-picker")
julia> using Pluto |
pankgeorg
reviewed
Jan 15, 2024
| @@ -1,4 +1,6 @@ | |||
| @import url("https://cdn.jsdelivr.net/npm/dialog-polyfill@0.5.6/dist/dialog-polyfill.css"); | |||
| @import url("https://cdn.jsdelivr.net/npm/bcp47-picker@1.0.16/dist/bcp47-picker.css"); | |||
| @import url("https://cdn.jsdelivr.net/npm/bootstrap@5.1.3/dist/css/bootstrap.min.css"); | |||
Member
There was a problem hiding this comment.
this one is pretty big 🤔 (165kb)
Member
Author
There was a problem hiding this comment.
yeah i also don't want it. i wish bcp47 had a bundle that included all the styles that it needs, scoped to the element but i think we need to do that by hand. You can see I started working on this in this file
Member
Author
There was a problem hiding this comment.
this is one place where the PR got stuck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using https://github.com/OM-MediaWorks/bcp47-picker, a pretty cool custom component BCP47 picker! I really like like the balance between input validation & canonlization (does not allow "english", only "en", and turns "en-gb" into "en-GB", etc) and inclusivity (if you want to write "dutch, as spoken in Chile, written in Arabic", you can).
Fix #2718
Waiting on OM-MediaWorks/bcp47-picker#11 and maybe some other issues that I opened there