Rework segment_vf_collection

* better testing of italic/family relation, not just file names
* Update ital_axis.py
* fix error due to familyname in name space

(PR #4966)

Author: benkiel

Lib/fontbakery/checks/opentype/STAT/ital_axis.py

@@ -97,6 +97,8 @@ def segment_vf_collection(fonts):
     for font in fonts:
         if "-Italic[" in font.file:
             italics.append(font)
+        elif font.is_italic:
+            italics.append(font)
         else:
             non_italics.append(font)
 
@@ -109,6 +111,9 @@ def segment_vf_collection(fonts):
             if non_italic.file == suspected_roman:
                 found_roman = non_italic
                 break
+            if non_italic.family == italic.family:
+                found_roman = non_italic
+                break
 
         if found_roman:
             non_italics.remove(found_roman)

Lib/fontbakery/testable.py

@@ -86,6 +86,23 @@ def ttFont(self):
             font.ensureDecompiled()
         return font
 
+    @cached_property
+    def family(self):
+        from fontbakery.utils import get_name_entry_strings
+        from fontbakery.constants import NameID
+
+        ttFont = self.ttFont
+        familynames = get_name_entry_strings(ttFont, NameID.FONT_FAMILY_NAME)
+        typo_familynames = get_name_entry_strings(
+            ttFont, NameID.TYPOGRAPHIC_FAMILY_NAME
+        )
+        if not familynames:
+            return None
+
+        family = typo_familynames[0] if typo_familynames else familynames[0]
+
+        return family
+
     @cached_property
     def style(self):
         """Determine font style from canonical filename."""