Alternate solution

Author: jenskutilek

Lib/fontbakery/checks/vendorspecific/googlefonts/conditions.py

@@ -307,11 +307,11 @@ def rfn_exception(font):
     been published previously with an RFN, or fonts which benefit from
     an agreement with Google Fonts.
     """
-    from fontbakery.utils import get_resource_file_path
+    from fontbakery.utils import get_resource_file_contents
 
     rfn_exceptions_txt = "data/googlefonts/reserved_font_name_exceptions.txt"
-    filename = get_resource_file_path(rfn_exceptions_txt)
-    for exception in open(filename, "r", encoding="utf-8").readlines():
+    contents = get_resource_file_contents(rfn_exceptions_txt)
+    for exception in contents.splitlines():
         exception = exception.split("#")[0].strip()
         exception = exception.replace(" ", "")
         if exception == "":

Lib/fontbakery/checks/vendorspecific/googlefonts/family_name_compliance.py

@@ -26,7 +26,7 @@ def check_family_name_compliance(ttFont):
     """Check family name for GF Guide compliance."""
     import re
 
-    from fontbakery.utils import get_name_entries, get_resource_file_path
+    from fontbakery.utils import get_name_entries, get_resource_file_contents
 
     camelcase_exceptions_txt = "data/googlefonts/camelcased_familyname_exceptions.txt"
     abbreviations_exceptions_txt = (
@@ -45,8 +45,8 @@ def check_family_name_compliance(ttFont):
         known_exception = False
 
         # Process exceptions
-        filename = get_resource_file_path(camelcase_exceptions_txt)
-        for exception in open(filename, "r", encoding="utf-8").readlines():
+        contents = get_resource_file_contents(camelcase_exceptions_txt)
+        for exception in contents.splitlines():
             exception = exception.split("#")[0].strip()
             if exception == "":
                 continue
@@ -71,8 +71,8 @@ def check_family_name_compliance(ttFont):
         known_exception = False
 
         # Process exceptions
-        filename = get_resource_file_path(abbreviations_exceptions_txt)
-        for exception in open(filename, "r", encoding="utf-8").readlines():
+        contents = get_resource_file_contents(abbreviations_exceptions_txt)
+        for exception in contents.splitlines():
             exception = exception.split("#")[0].strip()
             if exception == "":
                 continue

Lib/fontbakery/checks/vendorspecific/googlefonts/utils.py

@@ -1,7 +1,7 @@
 import re
 from functools import lru_cache
 
-from fontbakery.utils import exit_with_install_instructions, get_resource_file_path
+from fontbakery.utils import exit_with_install_instructions, get_resource_file_contents
 
 
 @lru_cache(maxsize=1)
@@ -21,8 +21,7 @@ def registered_vendor_ids():
         exit_with_install_instructions("googlefonts")
 
     registered_vendor_ids = {}
-    CACHED = get_resource_file_path("data/fontbakery-microsoft-vendorlist.cache")
-    content = open(CACHED, encoding="utf-8").read()
+    content = get_resource_file_contents("data/fontbakery-microsoft-vendorlist.cache")
     # Strip all <A> HTML tags from the raw HTML. The current page contains a
     # closing </A> for which no opening <A> is present, which causes
     # beautifulsoup to silently stop processing that section from the error

Lib/fontbakery/utils.py

@@ -20,7 +20,7 @@
 import sys
 import traceback
 from copy import deepcopy
-from typing import TYPE_CHECKING, Optional
+from typing import Optional
 
 from fontTools.pens.basePen import BasePen
 from fontTools.ttLib import TTFont
@@ -33,11 +33,8 @@
     PANOSE_Family_Type,
 )
 
-if TYPE_CHECKING:
-    from pathlib import Path
 
-
-def get_resource_file_path(sub_file_path: str) -> Path:
+def get_resource_file_contents(sub_file_path: str) -> str:
     """Return the full file path of a resource file inside the fontbakery
     directory.
 
@@ -51,8 +48,9 @@ def get_resource_file_path(sub_file_path: str) -> Path:
     from importlib.resources import as_file, files
 
     with as_file(files("fontbakery").joinpath(sub_file_path)) as path:
-        file_path = path
-    return file_path
+        with open(path, encoding="utf-8") as f:
+            contents = f.read()
+    return contents
 
 
 def exit_with_install_instructions(profile_name):