Skip to content

Commit 5ea1533

Browse files
committed
disable legacy PNG encoding in image serialization
Add SK_DISABLE_LEGACY_PNG_WRITEBUFFER preprocessor define to remove PNG encoder dependency from SkWriteBuffer serialization code. This allows Windows DLL builds to succeed without requiring PNG encoder implementation, as DLLs must resolve all symbols at link time. This matches Chromium's approach (see chromium/src@c97e564) and aligns with Skia's Bazel build which already disables this by default.
1 parent c1d02ba commit 5ea1533

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

build_skia.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
"skia_enable_spirv_validation=false",
4545
"skia_use_lua=false",
4646
"skia_use_wuffs=false",
47+
'extra_cflags=["-DSK_DISABLE_LEGACY_PNG_WRITEBUFFER"]',
4748
]
4849
if sys.platform != "win32":
4950
# On Linux, I need this flag otherwise I get undefined symbol upon importing;

0 commit comments

Comments
 (0)