Make headers lower-case by convention and test some cors code-paths

Author: azimux

CHANGELOG.md

@@ -1,3 +1,7 @@
+## [0.0.21] - 2025-04-15
+
+- Fix incorrect content-type for help action 
+
 ## [0.0.20] - 2025-04-14
 
 - Handle more cors scenarios

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    foobara-http-command-connector (0.0.20)
+    foobara-http-command-connector (0.0.21)
       foobara (~> 0.0.88)
 
 GEM
@@ -21,20 +21,20 @@ GEM
     diff-lcs (1.6.1)
     docile (1.4.1)
     dotenv (3.1.8)
-    extract-repo (0.0.9)
-      foobara
-      foobara-sh-cli-connector
-    ffi (1.17.1)
-    ffi (1.17.1-aarch64-linux-gnu)
-    ffi (1.17.1-aarch64-linux-musl)
-    ffi (1.17.1-arm-linux-gnu)
-    ffi (1.17.1-arm-linux-musl)
-    ffi (1.17.1-arm64-darwin)
-    ffi (1.17.1-x86-linux-gnu)
-    ffi (1.17.1-x86-linux-musl)
-    ffi (1.17.1-x86_64-darwin)
-    ffi (1.17.1-x86_64-linux-gnu)
-    ffi (1.17.1-x86_64-linux-musl)
+    extract-repo (0.0.10)
+      foobara (~> 0.0.102)
+      foobara-sh-cli-connector (~> 0.0.1)
+    ffi (1.17.2)
+    ffi (1.17.2-aarch64-linux-gnu)
+    ffi (1.17.2-aarch64-linux-musl)
+    ffi (1.17.2-arm-linux-gnu)
+    ffi (1.17.2-arm-linux-musl)
+    ffi (1.17.2-arm64-darwin)
+    ffi (1.17.2-x86-linux-gnu)
+    ffi (1.17.2-x86-linux-musl)
+    ffi (1.17.2-x86_64-darwin)
+    ffi (1.17.2-x86_64-linux-gnu)
+    ffi (1.17.2-x86_64-linux-musl)
     foob (0.0.13)
       foobara (~> 0.0.99)
       foobara-command-generator (~> 0.0.1)
@@ -71,7 +71,7 @@ GEM
       foobara-files-generator
     foobara-dotenv-loader (0.0.3)
       dotenv
-    foobara-empty-ruby-project-generator (0.0.15)
+    foobara-empty-ruby-project-generator (0.0.17)
       extract-repo (~> 0.0.1)
       foobara (~> 0.0.94)
       foobara-files-generator (~> 0.0.1)
@@ -89,7 +89,7 @@ GEM
     foobara-organization-generator (0.0.2)
       foobara
       foobara-files-generator
-    foobara-rack-connector-generator (0.0.9)
+    foobara-rack-connector-generator (0.0.11)
       foobara
       foobara-files-generator
     foobara-redis-crud-driver-generator (0.0.4)
@@ -115,9 +115,9 @@ GEM
     foobara-type-generator (0.0.4)
       foobara
       foobara-files-generator
-    foobara-typescript-react-command-form-generator (0.0.11)
+    foobara-typescript-react-command-form-generator (0.0.12)
       foobara-typescript-remote-command-generator (~> 0.0.1)
-    foobara-typescript-remote-command-generator (0.0.17)
+    foobara-typescript-remote-command-generator (0.0.18)
       foobara-files-generator (~> 0.0.1)
     foobara-util (0.0.11)
     formatador (1.1.0)

spec/foobara/command_connectors_http/http_spec.rb

@@ -192,7 +192,7 @@ def execute
     end
   end
 
-  describe "#run_command" do
+  describe "#run" do
     before do
       if allowed_rules
         command_connector.allowed_rules(allowed_rules)
@@ -856,6 +856,33 @@ def execute
       end
     end
 
+    context "when handling cors stuff" do
+      let(:method) { "OPTIONS" }
+      let(:headers) do
+        { "access-control-request-headers" => "Content-Type" }
+      end
+
+      stub_env_vars(
+        "FOOBARA_HTTP_RESPONSE_HEADER_ACCESS_CONTROL_ALLOW_METHODS" => "GET, POST, PUT, PATCH, DELETE, OPTIONS",
+        "FOOBARA_HTTP_RESPONSE_HEADER_ACCESS_CONTROL_ALLOW_HEADERS" => "*",
+        "FOOBARA_HTTP_RESPONSE_HEADER_ACCESS_CONTROL_EXPOSE_HEADERS" => "X-Access-Token",
+        "FOOBARA_HTTP_RESPONSE_HEADER_ACCESS_CONTROL_ALLOW_CREDENTIALS" => "true",
+        "FOOBARA_HTTP_RESPONSE_HEADER_ACCESS_CONTROL_ALLOW_ORIGIN" => "http://localhost:3000",
+        "FOOBARA_HTTP_RESPONSE_HEADER_ACCESS_CONTROL_MAX_AGE" => "3600"
+      )
+
+      it "returns various cors headers" do
+        expect(response.headers).to eq(
+          "access-control-expose-headers" => "X-Access-Token",
+          "access-control-allow-credentials" => "true",
+          "access-control-allow-origin" => "http://localhost:3000",
+          "access-control-allow-methods" => "GET, POST, PUT, PATCH, DELETE, OPTIONS",
+          "access-control-allow-headers" => "Content-Type",
+          "access-control-max-age" => "3600"
+        )
+      end
+    end
+
     describe "#manifest" do
       context "when various transformers" do
         let(:query_string) { "bbaassee=#{base}" }

src/http/commands/get_options.rb

@@ -35,7 +35,7 @@ def set_allow_headers
             allow_headers = ENV.fetch("FOOBARA_HTTP_RESPONSE_HEADER_ACCESS_CONTROL_ALLOW_HEADERS", nil)
             if allow_headers
               if allow_headers == "*"
-                allow_headers = request.headers["HTTP_ACCESS_CONTROL_REQUEST_HEADERS"]
+                allow_headers = request.headers["access-control-request-headers"]
               end
               request.response_headers["access-control-allow-headers"] = allow_headers
             end

version.rb

@@ -1,6 +1,6 @@
 module Foobara
   module HttpCommandConnector
-    VERSION = "0.0.20".freeze
+    VERSION = "0.0.21".freeze
 
     local_ruby_version = File.read("#{__dir__}/.ruby-version").chomp
     local_ruby_version_minor = local_ruby_version[/\A(\d+\.\d+)\.\d+\z/, 1]