Add a SetInputFromCookie request mutator

Author: azimux

CHANGELOG.md

@@ -1,3 +1,7 @@
+## [0.0.16] - 2025-03-28
+
+- 
+
 ## [0.0.15] - 2025-03-28
 
 - Implement MoveAttributeToCookie response mutator

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    foobara-http-command-connector (0.0.15)
+    foobara-http-command-connector (0.0.16)
       foobara (~> 0.0.88)
 
 GEM
@@ -54,7 +54,7 @@ GEM
       foobara-type-generator
       foobara-typescript-react-command-form-generator
       foobara-typescript-remote-command-generator
-    foobara (0.0.88)
+    foobara (0.0.90)
       bigdecimal
       foobara-lru-cache (~> 0.0.2)
       foobara-util (~> 0.0.11)
@@ -88,9 +88,8 @@ GEM
     foobara-rack-connector-generator (0.0.9)
       foobara
       foobara-files-generator
-    foobara-redis-crud-driver-generator (0.0.3)
-      foobara
-      foobara-files-generator
+    foobara-redis-crud-driver-generator (0.0.4)
+      foobara-files-generator (~> 0.0.1)
     foobara-remote-imports-generator (0.0.3)
       foobara
       foobara-files-generator
@@ -103,11 +102,10 @@ GEM
     foobara-rubocop-rules (0.0.8)
       rubocop
       rubocop-rspec
-    foobara-sh-cli-connector (0.0.12)
-      foobara
-    foobara-sh-cli-connector-generator (0.0.3)
-      foobara
-      foobara-files-generator
+    foobara-sh-cli-connector (0.0.13)
+      foobara (~> 0.0.88)
+    foobara-sh-cli-connector-generator (0.0.4)
+      foobara-files-generator (~> 0.0.1)
     foobara-spec-helpers (0.0.4)
       foobara-util
     foobara-type-generator (0.0.4)
@@ -182,7 +180,7 @@ GEM
     rb-fsevent (0.11.2)
     rb-inotify (0.11.1)
       ffi (~> 1.0)
-    rdoc (6.13.0)
+    rdoc (6.13.1)
       psych (>= 4.0.0)
     regexp_parser (2.10.0)
     reline (0.6.0)

spec/foobara/command_connectors_http/set_input_from_cookie_spec.rb

@@ -0,0 +1,44 @@
+RSpec.describe Foobara::CommandConnectors::Http::SetInputFromCookie do
+  let(:command_class) do
+    stub_class(:SomeCommand, Foobara::Command) do
+      inputs foo: :string, bar: :string
+      result :duck
+
+      def execute
+        inputs
+      end
+    end
+  end
+
+  let(:request_mutator) do
+    described_class.for(:foo, "foo_cookie")
+  end
+
+  let(:command_connector) { Foobara::CommandConnectors::Http.new }
+  let(:response) { command_connector.run(path:, query_string:, cookies:) }
+  let(:query_string) { "bar=barvalue" }
+  let(:path) { "/run/#{command_class.full_command_name}" }
+  let(:cookies) do
+    { "foo_cookie" => "foovalue" }
+  end
+
+  before do
+    command_connector.connect(command_class, request_mutators: request_mutator)
+  end
+
+  it "moves the cookie to an input" do
+    expect(response.status).to eq(200)
+    expect(JSON.parse(response.body)).to eq("bar" => "barvalue", "foo" => "foovalue")
+  end
+
+  it "makes changes in the manifest" do
+    manifest = command_connector.foobara_manifest
+
+    expect(manifest[:command][:SomeCommand][:inputs_type]).to eq(
+      type: :attributes,
+      element_type_declarations: {
+        bar: { type: :string }
+      }
+    )
+  end
+end

src/http/request_mutators/set_input_from_cookie.rb

@@ -0,0 +1,40 @@
+module Foobara
+  module CommandConnectors
+    class Http < CommandConnector
+      class SetInputFromCookie < RequestMutator
+        class << self
+          attr_accessor :attribute_name, :cookie_name
+
+          def for(attribute_name, cookie_name = attribute_name)
+            subclass = Class.new(self)
+
+            subclass.attribute_name = attribute_name
+            subclass.cookie_name = cookie_name
+
+            subclass
+          end
+        end
+
+        attr_writer :attribute_name, :cookie_name
+
+        def inputs_type_from(inputs_type)
+          new_declaration = TypeDeclarations::Attributes.reject(inputs_type.declaration_data, attribute_name)
+          Domain.current.foobara_type_from_declaration(new_declaration)
+        end
+
+        def mutate(request)
+          cookie_value = request.cookies[cookie_name]
+          request.inputs[attribute_name] = cookie_value
+        end
+
+        def attribute_name
+          @attribute_name ||= self.class.attribute_name
+        end
+
+        def cookie_name
+          @cookie_name ||= self.class.cookie_name
+        end
+      end
+    end
+  end
+end

src/http/response_mutators/move_attribute_to_cookie.rb

@@ -19,15 +19,16 @@ def for(attribute_name, cookie_name = attribute_name, **cookie_opts)
         attr_writer :attribute_name, :cookie_name, :cookie_opts
 
         def result_type_from(result_type)
-          AttributesTransformers.reject(result_type.declaration_data)
           new_declaration = TypeDeclarations::Attributes.reject(result_type.declaration_data, attribute_name)
 
           Domain.current.foobara_type_from_declaration(new_declaration)
         end
 
         def mutate(response)
-          cookie_value = response.body.delete(attribute_name)
-          response.add_cookie(cookie_name, cookie_value, cookie_opts)
+          if response.command.success?
+            cookie_value = response.body.delete(attribute_name)
+            response.add_cookie(cookie_name, cookie_value, cookie_opts)
+          end
         end
 
         def attribute_name

version.rb

@@ -1,6 +1,6 @@
 module Foobara
   module HttpCommandConnector
-    VERSION = "0.0.15".freeze
+    VERSION = "0.0.16".freeze
 
     local_ruby_version = File.read("#{__dir__}/.ruby-version").chomp
     local_ruby_version_minor = local_ruby_version[/\A(\d+\.\d+)\.\d+\z/, 1]