Make sure manifest is generated in a detached context

Author: azimux

CHANGELOG.md

@@ -1,3 +1,7 @@
+## [0.0.14] - 2025-02-02
+
+- Put manifest into detached context by default
+
 ## [0.0.12] - 2025-01-28
 
 - Fix potential issue with default serializer inheritance/overriding

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    foobara-http-command-connector (0.0.12)
+    foobara-http-command-connector (0.0.14)
       foobara
 
 GEM
@@ -54,7 +54,7 @@ GEM
       foobara-type-generator
       foobara-typescript-react-command-form-generator
       foobara-typescript-remote-command-generator
-    foobara (0.0.51)
+    foobara (0.0.55)
       bigdecimal
       foobara-util
     foobara-autocrud-generator (0.0.1)
@@ -188,14 +188,14 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
     rspec-support (3.13.2)
-    rubocop (1.71.0)
+    rubocop (1.71.1)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.36.2, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
     rubocop-ast (1.38.0)
@@ -260,4 +260,4 @@ RUBY VERSION
    ruby 3.4.1p0
 
 BUNDLED WITH
-   2.6.2
+   2.6.3

spec/foobara/command_connectors_http/http_spec.rb

@@ -154,6 +154,21 @@ def compute
             expect(manifest[:organization].keys).to match_array(%i[SomeOrg global_organization])
             expect(manifest[:command][:"SomeOrg::SomeDomain::SomeCommand"][:description]).to eq("just some command")
           end
+
+          context "when generating manifest via Describe" do
+            let(:request) { described_class::Request.new(path: "/manifest") }
+
+            it "includes the organization" do
+              manifest = described_class::Commands::Describe.run!(
+                manifestable: command_connector,
+                request:,
+                detached: false
+              )
+
+              expect(manifest[:organization].keys).to match_array(%i[SomeOrg global_organization])
+              expect(manifest[:command][:"SomeOrg::SomeDomain::SomeCommand"][:description]).to eq("just some command")
+            end
+          end
         end
       end
     end
@@ -965,6 +980,8 @@ def transform(result)
 
     context "with describe path" do
       let(:path) { "/describe/ComputeExponent" }
+      let(:query_string) { "" }
+      let(:body) { "" }
 
       it "describes the command" do
         expect(response.status).to be(200)

src/http/commands/describe.rb

@@ -3,9 +3,33 @@ module CommandConnectors
     class Http < Foobara::CommandConnector
       module Commands
         class Describe < Foobara::CommandConnector::Commands::Describe
+          inputs do
+            manifestable :duck
+            request :duck
+            detached :boolean, default: true
+          end
+
           def stamp_request_metadata
             manifest[:metadata] = super.merge(url: request.url)
           end
+
+          def in_detached_context(&)
+            Thread.foobara_with_var("foobara_manifest_context", detached: true, &)
+          end
+
+          def build_manifest
+            if detached_context?
+              in_detached_context do
+                super
+              end
+            else
+              super
+            end
+          end
+
+          def detached_context?
+            detached
+          end
         end
       end
     end

version.rb

@@ -1,6 +1,6 @@
 module Foobara
   module HttpCommandConnector
-    VERSION = "0.0.12".freeze
+    VERSION = "0.0.14".freeze
 
     local_ruby_version = File.read("#{__dir__}/.ruby-version").chomp
     local_ruby_version_minor = local_ruby_version[/\A(\d+\.\d+)\.\d+\z/, 1]