Add set: request mutator sugar

Author: azimux

CHANGELOG.md

@@ -1,3 +1,7 @@
+## [1.1.3] - 2026-01-21
+
+- Add `set:` request mutator sugar
+
 ## [1.1.2] - 2025-12-18
 
 - Fix bug causing commands to cram together on help page

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    foobara-http-command-connector (1.1.2)
+    foobara-http-command-connector (1.1.3)
       foobara (>= 0.1.1, < 2.0.0)
 
 GEM
@@ -12,7 +12,8 @@ GEM
     ast (2.4.3)
     base64 (0.3.0)
     bigdecimal (4.0.1)
-    byebug (12.0.0)
+    byebug (13.0.0)
+      reline (>= 0.6.0)
     coderay (1.1.3)
     crack (1.0.1)
       bigdecimal
@@ -25,25 +26,24 @@ GEM
     extract-repo (1.0.0)
       foobara (< 2.0.0)
       foobara-sh-cli-connector (< 2.0.0)
-    ffi (1.17.2)
-    ffi (1.17.2-aarch64-linux-gnu)
-    ffi (1.17.2-aarch64-linux-musl)
-    ffi (1.17.2-arm-linux-gnu)
-    ffi (1.17.2-arm-linux-musl)
-    ffi (1.17.2-arm64-darwin)
-    ffi (1.17.2-x86-linux-gnu)
-    ffi (1.17.2-x86-linux-musl)
-    ffi (1.17.2-x86_64-darwin)
-    ffi (1.17.2-x86_64-linux-gnu)
-    ffi (1.17.2-x86_64-linux-musl)
-    foob (0.1.1)
+    ffi (1.17.3)
+    ffi (1.17.3-aarch64-linux-gnu)
+    ffi (1.17.3-aarch64-linux-musl)
+    ffi (1.17.3-arm-linux-gnu)
+    ffi (1.17.3-arm-linux-musl)
+    ffi (1.17.3-arm64-darwin)
+    ffi (1.17.3-x86-linux-gnu)
+    ffi (1.17.3-x86-linux-musl)
+    ffi (1.17.3-x86_64-darwin)
+    ffi (1.17.3-x86_64-linux-gnu)
+    ffi (1.17.3-x86_64-linux-musl)
+    foob (0.1.2)
       foobara (>= 0.3.0, < 2.0.0)
       foobara-command-generator (< 2.0.0)
       foobara-domain-generator (< 2.0.0)
       foobara-domain-mapper-generator (< 2.0.0)
       foobara-empty-ruby-project-generator (< 2.0.0)
       foobara-empty-typescript-react-project-generator (< 2.0.0)
-      foobara-foobify-rails-app (< 2.0.0)
       foobara-local-files-crud-driver-generator (< 2.0.0)
       foobara-mcp-connector-generator (< 2.0.0)
       foobara-organization-generator (< 2.0.0)
@@ -57,7 +57,8 @@ GEM
       foobara-type-generator (< 2.0.0)
       foobara-typescript-react-command-form-generator (< 2.0.0)
       foobara-typescript-remote-command-generator (< 2.0.0)
-    foobara (0.4.1)
+      foobify-rails-app (< 2.0.0)
+    foobara (0.4.4)
       bigdecimal
       foobara-lru-cache (< 2.0.0)
       foobara-util (< 2.0.0)
@@ -82,8 +83,6 @@ GEM
       foobara-files-generator (< 2.0.0)
     foobara-files-generator (0.1.1)
       foobara (>= 0.1.1, < 2.0.0)
-    foobara-foobify-rails-app (0.0.8)
-      foobara (>= 0.3.0, < 2.0.0)
     foobara-local-files-crud-driver-generator (0.0.3)
       foobara
       foobara-files-generator
@@ -108,7 +107,7 @@ GEM
     foobara-resque-scheduler-connector-generator (0.0.2)
       foobara
       foobara-files-generator
-    foobara-rubocop-rules (1.0.10)
+    foobara-rubocop-rules (1.0.11)
       rubocop
       rubocop-rspec
     foobara-sh-cli-connector (1.1.3)
@@ -124,20 +123,21 @@ GEM
     foobara-typescript-react-command-form-generator (1.1.1)
       foobara (>= 0.1.1, < 2.0.0)
       foobara-typescript-remote-command-generator (< 2.0.0)
-    foobara-typescript-remote-command-generator (1.2.0)
+    foobara-typescript-remote-command-generator (1.2.1)
       foobara (>= 0.1.16, < 2.0.0)
       foobara-files-generator (< 2.0.0)
-    foobara-util (1.0.6)
+    foobara-util (1.0.7)
+    foobify-rails-app (0.0.10)
+      foobara (>= 0.3.0, < 2.0.0)
     formatador (1.2.3)
       reline
-    guard (2.19.1)
+    guard (2.20.0)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
       logger (~> 1.6)
       lumberjack (>= 1.0.12, < 2.0)
       nenv (~> 0.1)
       notiffany (~> 0.0)
-      ostruct (~> 0.6)
       pry (>= 0.13.0)
       shellany (~> 0.0)
       thor (>= 0.18.1)
@@ -156,7 +156,8 @@ GEM
     json (2.18.0)
     language_server-protocol (3.17.0.5)
     lint_roller (1.1.0)
-    listen (3.9.0)
+    listen (3.10.0)
+      logger
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
     logger (1.7.0)
@@ -166,32 +167,32 @@ GEM
     notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    ostruct (0.6.3)
     parallel (1.27.0)
-    parser (3.3.10.0)
+    parser (3.3.10.1)
       ast (~> 2.4.1)
       racc
     pp (0.6.3)
       prettyprint
     prettyprint (0.2.0)
-    prism (1.7.0)
-    pry (0.15.2)
+    prism (1.8.0)
+    pry (0.16.0)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    pry-byebug (3.11.0)
-      byebug (~> 12.0)
-      pry (>= 0.13, < 0.16)
+      reline (>= 0.6.0)
+    pry-byebug (3.12.0)
+      byebug (~> 13.0)
+      pry (>= 0.13, < 0.17)
     psych (5.3.1)
       date
       stringio
-    public_suffix (7.0.0)
+    public_suffix (7.0.2)
     racc (1.8.1)
     rainbow (3.1.1)
     rake (13.3.1)
     rb-fsevent (0.11.2)
     rb-inotify (0.11.1)
       ffi (~> 1.0)
-    rdoc (7.0.1)
+    rdoc (7.1.0)
       erb
       psych (>= 4.0.0)
       tsort
@@ -215,7 +216,7 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
     rspec-support (3.13.6)
-    rubocop (1.82.0)
+    rubocop (1.82.1)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
@@ -226,13 +227,13 @@ GEM
       rubocop-ast (>= 1.48.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.48.0)
+    rubocop-ast (1.49.0)
       parser (>= 3.3.7.2)
-      prism (~> 1.4)
+      prism (~> 1.7)
     rubocop-rake (0.7.1)
       lint_roller (~> 1.1)
       rubocop (>= 1.72.1)
-    rubocop-rspec (3.8.0)
+    rubocop-rspec (3.9.0)
       lint_roller (~> 1.1)
       rubocop (~> 1.81)
     ruby-prof (1.7.2)
@@ -246,13 +247,12 @@ GEM
     simplecov-html (0.13.2)
     simplecov_json_formatter (0.1.4)
     stringio (3.2.0)
-    thor (1.4.0)
+    thor (1.5.0)
     tsort (0.2.0)
     unicode-display_width (3.2.0)
       unicode-emoji (~> 4.1)
     unicode-emoji (4.2.0)
-    vcr (6.3.1)
-      base64
+    vcr (6.4.0)
     webmock (3.26.1)
       addressable (>= 2.8.0)
       crack (>= 0.3.2)

lib/foobara/http_command_connector.rb

@@ -2,3 +2,15 @@
 require "foobara/command_connectors"
 
 Foobara::Util.require_directory "#{__dir__}/../../src"
+
+module Foobara
+  module HttpCommandConnector
+    class << self
+      def install!
+        CommandConnector.add_desugarizer CommandConnectors::Http::Desugarizers::SetInputToProcResult
+      end
+    end
+  end
+
+  project "http_command_connector", project_path: "#{__dir__}/../../"
+end

spec/foobara/command_connectors_http/set_input_desugarizer_spec.rb

@@ -0,0 +1,37 @@
+RSpec.describe Foobara::CommandConnectors::Http::Desugarizers::SetInputToProcResult do
+  let(:command_class) do
+    stub_class(:SomeCommand, Foobara::Command) do
+      inputs foo: :string, bar: :string
+      result :duck
+      def execute = inputs
+    end
+  end
+
+  let(:some_foo) { "Fooooooo" }
+
+  let(:command_connector) { Foobara::CommandConnectors::Http.new }
+  let(:response) { command_connector.run(path:, query_string:) }
+  let(:query_string) { "bar=barvalue" }
+  let(:path) { "/run/#{command_class.full_command_name}" }
+
+  before do
+    foo = some_foo
+    command_connector.connect(command_class, request: { set: { foo: -> { foo } } })
+  end
+
+  it "sets the input to the expected value" do
+    expect(response.status).to eq(200)
+    expect(JSON.parse(response.body)).to eq("bar" => "barvalue", "foo" => "Fooooooo")
+  end
+
+  it "makes changes in the manifest" do
+    manifest = command_connector.foobara_manifest
+
+    expect(manifest[:command][:SomeCommand][:inputs_type]).to eq(
+      type: :attributes,
+      element_type_declarations: {
+        bar: :string
+      }
+    )
+  end
+end

spec/foobara/command_connectors_http/set_input_to_proc_result_spec.rb

@@ -26,7 +26,7 @@ def execute
     command_connector.connect(command_class, request_mutators: request_mutator)
   end
 
-  it "moves the cookie to an input" do
+  it "sets the input to the expected value" do
     expect(response.status).to eq(200)
     expect(JSON.parse(response.body)).to eq("bar" => "barvalue", "foo" => "Fooooooo")
   end

src/http/desugarizers/set_input_to_proc_result.rb

@@ -0,0 +1,51 @@
+module Foobara
+  module CommandConnectors
+    class Http < CommandConnector
+      module Desugarizers
+        class SetInputToProcResult < Desugarizer
+          def applicable?(args_and_opts)
+            _args, opts = args_and_opts
+
+            return false unless opts.key?(:request_mutators)
+
+            mutators = opts[:request_mutators]
+            mutators = Util.array(mutators)
+
+            mutators.any? do |mutator|
+              mutator.is_a?(::Hash) && mutator.key?(:set)
+            end
+          end
+
+          def desugarize(args_and_opts)
+            args, opts = args_and_opts
+
+            mutators = opts[:request_mutators]
+            resulting_mutators = []
+
+            Util.array(mutators).map do |mutator|
+              if mutator.is_a?(::Hash) && mutator.key?(:set)
+                if mutator.size > 1
+                  # TODO: add test for this
+                  # :nocov:
+                  resulting_mutators << mutator.except(:set)
+                  # :nocov:
+                end
+
+                mutator[:set].each_pair do |input_name, proc|
+                  resulting_mutators << Http::SetInputToProcResult.for(input_name, &proc)
+                end
+              else
+                # TODO: add a test for this
+                # :nocov:
+                resulting_mutators << mutator
+                # :nocov:
+              end
+            end
+
+            [args, opts.merge(request_mutators: resulting_mutators)]
+          end
+        end
+      end
+    end
+  end
+end

src/http/request_mutators/set_input_to_proc_result.rb

@@ -3,6 +3,7 @@ module CommandConnectors
     class Http < CommandConnector
       # TODO: We don't really want to mutate the request. We just need access to the authenticated user.
       # consider changing inputs transformer to have access to the command/request somehow
+      # TODO: what does this have to do with HTTP? Shouldn't this be a generic mutator for all connectors?
       class SetInputToProcResult < RequestMutator
         class << self
           attr_accessor :attribute_name, :input_value_proc

version.rb

@@ -1,6 +1,6 @@
 module Foobara
   module HttpCommandConnector
-    VERSION = "1.1.2".freeze
+    VERSION = "1.1.3".freeze
     MINIMUM_RUBY_VERSION = ">= 3.4.0".freeze
   end
 end