Don't make use of Inputs for commands that don't have inputs

Author: azimux

CHANGELOG.md

@@ -1,3 +1,7 @@
+## [0.0.9] - 2025-04-08
+
+- Don't make use of inputs for commands that don't have inputs
+
 ## [0.0.8] - 2025-03-22
 
 - Use password inputs for sensitive types

Gemfile

@@ -11,7 +11,7 @@ gem "rake"
 # gem "foobara-typescript-remote-command-generator", path: "../typescript-remote-command-generator"
 
 group :development do
-  gem "foobara-rubocop-rules"
+  gem "foobara-rubocop-rules", "~> 0.0.1"
   gem "guard-rspec"
   gem "rubocop-rake"
   gem "rubocop-rspec"
@@ -23,7 +23,7 @@ group :development, :test do
 end
 
 group :test do
-  gem "foobara-spec-helpers"
+  gem "foobara-spec-helpers", "~> 0.0.1"
   gem "rspec"
   gem "rspec-its"
   gem "simplecov"

Gemfile.lock

@@ -1,25 +1,23 @@
 PATH
   remote: .
   specs:
-    foobara-typescript-react-command-form-generator (0.0.8)
-      foobara
-      foobara-files-generator
-      foobara-typescript-remote-command-generator
+    foobara-typescript-react-command-form-generator (0.0.9)
+      foobara-typescript-remote-command-generator (~> 0.0.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
     ast (2.4.3)
     bigdecimal (3.1.9)
-    byebug (11.1.3)
+    byebug (12.0.0)
     coderay (1.1.3)
-    diff-lcs (1.6.0)
+    diff-lcs (1.6.1)
     docile (1.4.1)
     ffi (1.17.1-x86_64-linux-gnu)
-    foobara (0.0.85)
+    foobara (0.0.95)
       bigdecimal
-      foobara-lru-cache
-      foobara-util
+      foobara-lru-cache (~> 0.0.2)
+      foobara-util (~> 0.0.11)
     foobara-files-generator (0.0.5)
       foobara
     foobara-lru-cache (0.0.2)
@@ -28,9 +26,9 @@ GEM
       rubocop-rspec
     foobara-spec-helpers (0.0.4)
       foobara-util
-    foobara-typescript-remote-command-generator (0.0.13)
-      foobara
-      foobara-files-generator
+    foobara-typescript-remote-command-generator (0.0.16)
+      foobara (~> 0.0.88)
+      foobara-files-generator (~> 0.0.1)
     foobara-util (0.0.11)
     formatador (1.1.0)
     guard (2.19.1)
@@ -55,7 +53,7 @@ GEM
     listen (3.9.0)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
-    logger (1.6.6)
+    logger (1.7.0)
     lumberjack (1.2.10)
     method_source (1.1.0)
     nenv (0.3.0)
@@ -64,15 +62,16 @@ GEM
       shellany (~> 0.0)
     ostruct (0.6.1)
     parallel (1.26.3)
-    parser (3.3.7.2)
+    parser (3.3.7.4)
       ast (~> 2.4.1)
       racc
-    pry (0.14.2)
+    prism (1.4.0)
+    pry (0.15.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    pry-byebug (3.10.1)
-      byebug (~> 11.0)
-      pry (>= 0.13, < 0.15)
+    pry-byebug (3.11.0)
+      byebug (~> 12.0)
+      pry (>= 0.13, < 0.16)
     racc (1.8.1)
     rainbow (3.1.1)
     rake (13.2.1)
@@ -96,19 +95,20 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
     rspec-support (3.13.2)
-    rubocop (1.74.0)
+    rubocop (1.75.2)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.38.0, < 2.0)
+      rubocop-ast (>= 1.44.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.41.0)
+    rubocop-ast (1.44.0)
       parser (>= 3.3.7.2)
+      prism (~> 1.4)
     rubocop-rake (0.7.1)
       lint_roller (~> 1.1)
       rubocop (>= 1.72.1)
@@ -132,8 +132,8 @@ PLATFORMS
   x86_64-linux
 
 DEPENDENCIES
-  foobara-rubocop-rules
-  foobara-spec-helpers
+  foobara-rubocop-rules (~> 0.0.1)
+  foobara-spec-helpers (~> 0.0.1)
   foobara-typescript-react-command-form-generator!
   guard-rspec
   pry

foobara-typescript-react-command-form-generator.gemspec

@@ -21,9 +21,7 @@ Gem::Specification.new do |spec|
   spec.metadata["source_code_uri"] = spec.homepage
   spec.metadata["changelog_uri"] = "#{spec.homepage}/blob/main/CHANGELOG.md"
 
-  spec.add_dependency "foobara"
-  spec.add_dependency "foobara-files-generator"
-  spec.add_dependency "foobara-typescript-remote-command-generator"
+  spec.add_dependency "foobara-typescript-remote-command-generator", "~> 0.0.1"
 
   spec.files = Dir[
     "lib/**/*",

src/typescript_react_command_form_generator.rb

@@ -77,6 +77,10 @@ def templates_dir
             "#{__dir__}/../templates"
           end
 
+          def empty_inputs?
+            inputs_type.empty?
+          end
+
           def inputs_class_name
             "#{command_name}Inputs"
           end

templates/CommandForm.tsx.erb

@@ -3,7 +3,9 @@ import React, { useState, JSX } from 'react'
 import { Outcome } from "<%= path_to_root %>/base/Outcome"
 
 import { <%= command_name %> } from "<%= path_to_root %><%= command_generator.import_path %>"
+<% unless empty_inputs? %>
 import <%= inputs_class_name %> from "<%= path_to_root %><%= command_generator.import_path %>/Inputs"
+<% end %>
 import <%= result_class_name %> from "<%= path_to_root %><%= command_generator.import_path %>/Result"
 import { Error as <%= error_class_name %> } from "<%= path_to_root %><%= command_generator.import_path %>/Errors"
 
@@ -37,9 +39,13 @@ export default function <%= command_name %>Form (): JSX.Element {
       }
     <% end %>
 
+    <% if empty_inputs? %>
+    const command = new <%= command_name %>()
+    <% else %>
     const inputs: <%= inputs_class_name %> = <%= populated_inputs_object %>
 
     const command = new <%= command_name %>(inputs)
+    <% end %>
 
     try {
       setResult("Thinking...")

version.rb

@@ -1,7 +1,7 @@
 module Foobara
   module Generators
     module TypescriptReactCommandFormGenerator
-      VERSION = "0.0.8".freeze
+      VERSION = "0.0.9".freeze
 
       local_ruby_version = File.read("#{__dir__}/.ruby-version").chomp
       local_ruby_version_minor = local_ruby_version[/\A(\d+\.\d+)\.\d+\z/, 1]