Skip to content

Commit 12620da

Browse files
committed
Support specififying a project directory so that we can run the linter in CI
1 parent b2b525f commit 12620da

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

spec/remote_generator/write_typescript_to_disk_spec.rb

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,22 +7,24 @@
77
let(:inputs) do
88
{
99
raw_manifest:,
10+
project_directory:,
1011
output_directory:,
1112
fail_if_does_not_pass_linter:
1213
}
1314
end
14-
let(:output_directory) { "#{__dir__}/../../tmp/domains" }
15+
let(:project_directory) { "#{__dir__}/../../tmp/test-app" }
16+
let(:output_directory) { "#{project_directory}/src/domains" }
1517
let(:test_app_directory) { "#{__dir__}/../../spec/fixtures/test-app" }
1618
let(:raw_manifest_json) { File.read("spec/fixtures/foobara-manifest.json") }
1719
let(:raw_manifest) { JSON.parse(raw_manifest_json) }
1820
let(:fail_if_does_not_pass_linter) { true }
1921

2022
before do
21-
FileUtils.cp_r(test_app_directory, output_directory)
23+
FileUtils.cp_r(test_app_directory, project_directory)
2224
end
2325

2426
after do
25-
FileUtils.rm_rf(output_directory)
27+
FileUtils.rm_rf(project_directory)
2628
end
2729

2830
it "contains base files" do

src/remote_generator/write_typescript_to_disk.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ def self.generator_key = "typescript-remote-commands"
99
raw_manifest :associative_array, :allow_nil
1010
manifest_url :string, :allow_nil
1111
# TODO: should be able to delete this and inherit it
12+
project_directory :string, :allow_nil, "This lets you specify a directory to run the linter or npm run build in"
1213
output_directory :string, default: "src/domains"
1314
fail_if_does_not_pass_linter :boolean, default: false
1415
end
@@ -50,7 +51,7 @@ def generate_typescript
5051
end
5152

5253
def run_post_generation_tasks
53-
Dir.chdir(output_directory) do
54+
Dir.chdir(project_directory || output_directory) do
5455
eslint_fix
5556
end
5657
end

0 commit comments

Comments
 (0)