-
Notifications
You must be signed in to change notification settings - Fork 38
Description
OS: Windows 10 Pro 64 bit
go version: go1.15.4 windows/amd64
Apologies if this is a GitHub issue vs. something specific to this repository. I'm still learning how the go module system interacts with git.
I have a simple go Echo app running that uses the default Echo templating engine. The app imports a number of modules successfully, e.g.-
import (
"log"
"net/http"
"os"
"os/signal"
"syscall"
"github.com/labstack/echo/v4"
"github.com/labstack/echo/v4/middleware"
"gitlab.com/colin_e_nhsd/eprom.git/backend"
)
this works fine.
However when I tried to add goview-v4 I was unable to access the repo. If I run-
go get github.com/foolin/goview-v4 as a first step in either a Powershell window (I'm on Windows) or the VSCode terminal I get two popup GitHub password prompts one after the other, then the download aborts after a lengthy timeout.
UPDATE
I think this error is a combination of a documentation issue on page- https://github.com/foolin/goview/tree/master/supports/echoview-v4 plus the fact that Github gives confusing errors about authentication failures when what it means is "repo or page not found".
On the supports/echoview-v4 doc page the first few lines say-
Install
go get -u github.com/foolin/goview-v4
go get -u github.com/foolin/goview/supports/echoview-v4
Example
package main
import (
"github.com/foolin/goview/supports/echoview"
"github.com/labstack/echo"
"github.com/labstack/echo/middleware"
"net/http"
)
the line go get -u github.com/foolin/goview-v4 fails because there is no such module or package. The following line go get -u github.com/foolin/goview/supports/echoview-v4 succeeds, but I assume that means thre will be unresolved dependencies.
Meanwhile, the imports don't seem to be consistent either with the module dependencies above (no -v4 suffix) nor the correct imports for Echo v4 itself, which is imported as-
"github.com/labstack/echo/v4"
"github.com/labstack/echo/v4/middleware"
Any chance of updating the documentation here? I'm not entirely clear if this package is module-aware, which is significant now Echo v4 is set up as modules.