@W-20161958: [MSDK 13.1][Android] Cannot login GUS using Welcome endpoint (Correct Coverage For startBrowserCustomTabAuthorization)

Author: JohnsonEricAtSalesforce

libs/SalesforceSDK/src/com/salesforce/androidsdk/ui/LoginActivity.kt

@@ -56,6 +56,7 @@ import android.provider.Settings.EXTRA_BIOMETRIC_AUTHENTICATORS_ALLOWED
 import android.security.KeyChain.choosePrivateKeyAlias
 import android.security.KeyChain.getCertificateChain
 import android.security.KeyChain.getPrivateKey
+import android.util.Log
 import android.view.KeyEvent
 import android.view.KeyEvent.KEYCODE_BACK
 import android.view.ViewGroup
@@ -1106,9 +1107,40 @@ open class LoginActivity : FragmentActivity() {
         singleServerCustomTabActivity: Boolean = viewModel.singleServerCustomTabActivity,
     ) {
         // Load the authorization URL in a browser custom tab if required and do nothing otherwise as the view model will load it in the web view.
-        // TODO: Coverage needed? ECJ20251210
-        if ((singleServerCustomTabActivity || isBrowserLoginEnabled) && !isUsingFrontDoorBridge /* UI front-door bridge bypasses the need for browser custom tab */) {
+        // TODO: Coverage needed - This one is challenging. ECJ20251210
+//        if (singleServerCustomTabActivity) {
+//            Log.i("WSC", "A.1")
+//        } else {
+//            Log.i("WSC", "A.2")
+//        }
+//        if (isBrowserLoginEnabled) {
+//            Log.i("WSC", "B.1")
+//        } else {
+//            Log.i("WSC", "B.2")
+//        }
+//
+//        if (!singleServerCustomTabActivity && isBrowserLoginEnabled) {
+//            Log.i("WSC", "B.3 Right Side")
+//        }
+
+        val useBrowserLogin = (singleServerCustomTabActivity || isBrowserLoginEnabled)
+
+//        if (isUsingFrontDoorBridge) {
+//            Log.i("WSC", "C.1")
+//        } else {
+//            Log.i("WSC", "C.2")
+//        }
+//
+//        if (useBrowserLogin && isBrowserLoginEnabled) {
+//            Log.i("WSC", "C.3 Right Side")
+//        }
+
+        val useBrowserLoginGuardAgainstFrontDoorBridge = useBrowserLogin && !isUsingFrontDoorBridge /* UI front-door bridge bypasses the need for browser custom tab */
+
+        if (useBrowserLoginGuardAgainstFrontDoorBridge) {
             loadLoginPageInCustomTab(authorizationUrl, activityResultLauncher)
+        } else {
+            Log.i("WSC", "X")
         }
     }