@W-20161958: [MSDK 13.1][Android] Cannot login GUS using Welcome endpoint (loginActivity_startsCorrectActivity_onStartDefaultLoginWithHintAndHost)

Author: JohnsonEricAtSalesforce

libs/SalesforceSDK/src/com/salesforce/androidsdk/ui/LoginActivity.kt

@@ -1616,7 +1616,8 @@ open class LoginActivity : FragmentActivity() {
          * @param loginHint The Salesforce Welcome login username hint
          * @param loginHost The Salesforce Welcome login host
          */
-        private fun startDefaultLoginWithHintAndHost(
+        @VisibleForTesting
+        internal fun startDefaultLoginWithHintAndHost(
             context: Context,
             loginHint: String,
             loginHost: String,

libs/test/SalesforceSDKTest/src/com/salesforce/androidsdk/ui/LoginActivityTest.kt

@@ -26,7 +26,9 @@
  */
 package com.salesforce.androidsdk.ui
 
+import android.content.Context
 import android.content.Intent
+import android.content.Intent.FLAG_ACTIVITY_SINGLE_TOP
 import android.net.Uri.parse
 import android.webkit.WebView
 import androidx.core.net.toUri
@@ -45,6 +47,9 @@ import com.salesforce.androidsdk.ui.LoginActivity.Companion.SALESFORCE_WELCOME_D
 import com.salesforce.androidsdk.ui.LoginActivity.Companion.SALESFORCE_WELCOME_DISCOVERY_MOBILE_URL_QUERY_PARAMETER_KEY_CLIENT_VERSION
 import com.salesforce.androidsdk.ui.LoginActivity.Companion.SALESFORCE_WELCOME_DISCOVERY_URL_PATH
 import com.salesforce.androidsdk.ui.LoginActivity.Companion.isSalesforceWelcomeDiscoveryMobileUrl
+import com.salesforce.androidsdk.ui.LoginActivity.Companion.startDefaultLoginWithHintAndHost
+import io.mockk.mockk
+import io.mockk.verify
 import org.junit.Assert.assertEquals
 import org.junit.Assert.assertFalse
 import org.junit.Assert.assertTrue
@@ -311,5 +316,28 @@ class LoginActivityTest {
         }
     }
 
+    @Test
+    fun loginActivity_startsCorrectActivity_onStartDefaultLoginWithHintAndHost() {
+
+        val context = mockk<Context>(relaxed = true)
+
+        startDefaultLoginWithHintAndHost(
+            context = context,
+            loginHint = "ExampleUser@Example.com", // IETF-Reserved Test Domain
+            loginHost = "https://login.example.com" // IETF-Reserved Test Domain
+        )
+
+        verify(exactly = 1) {
+            context.startActivity(
+                match {
+                    it.component?.className == LoginActivity::class.java.name
+                    it.getStringExtra(EXTRA_KEY_LOGIN_HINT) == "ExampleUser@Example.com"
+                    it.getStringExtra(EXTRA_KEY_LOGIN_HOST) == "https://login.example.com"
+                    it.flags == FLAG_ACTIVITY_SINGLE_TOP
+                }
+            )
+        }
+    }
+
     // endregion
 }