Skip to content

Leverage Category in OSLog for SFSDKLogger#290

Open
TheAlmightyBob wants to merge 8 commits intoforcedotcom:devfrom
TheAlmightyBob:OSLogBeyond
Open

Leverage Category in OSLog for SFSDKLogger#290
TheAlmightyBob wants to merge 8 commits intoforcedotcom:devfrom
TheAlmightyBob:OSLogBeyond

Conversation

@TheAlmightyBob
Copy link
Copy Markdown
Contributor

This is a follow-up to #271 that takes things a bit further.

The original implementation created an OSLogger per-component, which was being used as the OSLog "category" attribute (since that can only be set when creating a logger).

But components are fairly heavy... if you want your logs going together in the same file, you probably aren't initting a lot of different loggers with different components.

Meanwhile, the log functions also take a class, which was added to the message text in the old TTY logger. This class seems like it might be a useful attribute to display and filter by.

So, the change here is to keep one file logger per component, but create a new console logger per tag (which is a combination of component and class).

This does mean that console loggers are created on-demand rather than via init. This applies to the TTY logger mode as well, even though that doesn't really benefit, just for consistency/simplicity.

Before

image

After

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant