Leverage Category in OSLog for SFSDKLogger#290
Open
TheAlmightyBob wants to merge 8 commits intoforcedotcom:devfrom
Open
Leverage Category in OSLog for SFSDKLogger#290TheAlmightyBob wants to merge 8 commits intoforcedotcom:devfrom
TheAlmightyBob wants to merge 8 commits intoforcedotcom:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #271 that takes things a bit further.
The original implementation created an OSLogger per-component, which was being used as the OSLog "category" attribute (since that can only be set when creating a logger).
But components are fairly heavy... if you want your logs going together in the same file, you probably aren't initting a lot of different loggers with different components.
Meanwhile, the log functions also take a class, which was added to the message text in the old TTY logger. This class seems like it might be a useful attribute to display and filter by.
So, the change here is to keep one file logger per component, but create a new console logger per tag (which is a combination of component and class).
This does mean that console loggers are created on-demand rather than via
init. This applies to the TTY logger mode as well, even though that doesn't really benefit, just for consistency/simplicity.Before
After