Merge pull request #3752 from bbirman/test-failure-notification

Fix testNotificationTransformNonRSASecret failure

Author: bbirman

libs/SalesforceSDKCore/SalesforceSDKCoreTests/SFSDKEncryptedPushNotificationTests.m

@@ -190,7 +190,13 @@ - (void)testNotificationTransformNonRSASecret {
     NSError *nonRSASecretError = nil;
     BOOL result = [SFSDKPushNotificationDecryption decryptNotificationContent:notifContent error:&nonRSASecretError];
     XCTAssertFalse(result);
-    XCTAssertEqual(nonRSASecretError.code, SFSDKPushNotificationErrorSecretDecryptionFailed);
+    if (@available(iOS 17.4, *)) {
+        // As of 17.4, decrypting a bad key with PKCS1 returns data instead of nil, so the secret decryption doesn't fail
+        // at the same point as before but using it later to decrypt the content still fails
+        XCTAssertEqual(nonRSASecretError.code, SFSDKPushNotificationErrorContentDecryptionFailed);
+    } else {
+        XCTAssertEqual(nonRSASecretError.code, SFSDKPushNotificationErrorSecretDecryptionFailed);
+    }
 }
 
 - (void)testNotificationTransformMalformedContent {