Review cleanup

Author: randi274

packages/code-analyzer-eslint-engine/src/base-config.ts

@@ -113,14 +113,7 @@ export class BaseConfigFactory {
         //todo: Should this need to be updated now to take CSS into consideration?
         return sldsEslintPlugin.configs['flat/recommended'].map(conf => ({
             ...conf,
-            files: this.engineConfig.file_extensions.html.map(ext => `**/*${ext}`),
-            languageOptions: {
-                    ... (conf.languageOptions ?? {}),
-                    parserOptions: {
-                        ... (conf.languageOptions?.parserOptions ?? {}),
-                        projectService: true
-                    }
-                }
+            files: this.engineConfig.file_extensions.html.map(ext => `**/*${ext}`)
         }));
     }
 

packages/code-analyzer-eslint-engine/test/test-data/workspaceWithFlatConfigCjs/eslint.config.cjs

@@ -1,6 +1,4 @@
-const { defineConfig } = require("eslint/config");
-
-module.exports = defineConfig([
+module.exports = [
     {
         rules: {
             "array-callback-return": ["error"],
@@ -9,4 +7,4 @@ module.exports = defineConfig([
             "no-useless-escape": [0]
         },
     },
-]);
+];

packages/code-analyzer-eslint-engine/test/test-data/workspaceWithFlatConfigJs/a-config-file-that-uses-ignores.js

@@ -1,9 +1,7 @@
-const { defineConfig } = require("eslint/config");
-
-module.exports = defineConfig([
+module.exports = [
     {
         // Should globally ignore js files - making the base js and lwc config not applicable
         // See https://eslint.org/docs/latest/use/configure/configuration-files#globally-ignoring-files-with-ignores
         ignores: ["**/*.js"]
     }
-]);
+];

packages/code-analyzer-eslint-engine/test/test-data/workspaceWithFlatConfigMjs/eslint.config.mjs

@@ -1,12 +1,6 @@
-import { defineConfig } from "eslint/config";
-
-export default defineConfig([
-    {
-        rules: {
-            "array-callback-return": ["error"],
-            "no-unused-vars": ["error", { argsIgnorePattern: "^_" }],
-            "no-useless-backreference": ["warn"],
-            "no-useless-escape": [0]
-        },
-    },
-]);
+export const rules = {
+    "array-callback-return": ["error"],
+    "no-unused-vars": ["error", { argsIgnorePattern: "^_" }],
+    "no-useless-backreference": ["warn"],
+    "no-useless-escape": [0]
+};