NEW @W-19374413@ Added test that should fail on Windows

Author: jfeingold35

.gitattributes

@@ -2,4 +2,6 @@
 # We do not wish to have GitHub add carriage returns for these files on windows.
 # So we forcefully set any file that ends in .goldfile.<ext> to only have \n characters:
 # See https://help.github.com/articles/dealing-with-line-endings/
-*.goldfile.*    text eol=lf
+*.goldfile.*    text eol=lf
+
+*.lf.* text eol=lf

packages/code-analyzer-regex-engine/test/engine.test.ts

@@ -39,7 +39,7 @@ const SAMPLE_CUSTOM_RULES: RegexRules = {
     NoTalkingAboutFightClub: {
         regex: '/fight club/gi',
         description: "The first rule of Fight Club is do not talk about Fight Club",
-        file_extensions: [".abc-def.xyz"],
+        file_extensions: [".abc-def.xyz", ".lf.cls"],
         violation_message: "The second rule of Fight Club is DO NOT. TALK. ABOUT FIGHT CLUB.",
         severity: DEFAULT_SEVERITY_LEVEL,
         tags: ['PopCulture']
@@ -783,6 +783,34 @@ describe('Tests for runRules', () => {
         }
     });
 
+    it('When workspace contains files that use \\n instead of \\r\\n, violations are right regardless of OS', async () => {
+        const runOptions: RunOptions = createRunOptions(
+            new Workspace('id', [path.resolve(__dirname, "test-data", "workspaceWithLfNewlines")]));
+        const runResults: EngineRunResults = await engine.runRules(['NoTalkingAboutFightClub'], runOptions);
+
+        const expectedViolations: Violation[] = [
+            {
+                ruleName: "NoTalkingAboutFightClub",
+                message: "The second rule of Fight Club is DO NOT. TALK. ABOUT FIGHT CLUB.",
+                primaryLocationIndex: 0,
+                codeLocations: [
+                    {
+                        file: path.resolve(__dirname, "test-data", "workspaceWithLfNewlines", "testClass.lf.cls"),
+                        startLine: 3,
+                        startColumn: 87,
+                        endLine: 3,
+                        endColumn: 97
+                    }
+                ]
+            }
+        ];
+
+        expect(runResults.violations).toHaveLength(expectedViolations.length);
+        for (const expectedViolation of expectedViolations) {
+            expect(runResults.violations).toContainEqual(expectedViolation);
+        }
+    });
+
     it("When running all rules compared to some rules, then output correctly returns what the correct violations according to specified rules", async () => {
         const runOptions: RunOptions = createRunOptions(
             new Workspace('id', [path.resolve(__dirname, "test-data", "sampleWorkspace")]));

packages/code-analyzer-regex-engine/test/test-data/workspaceWithLfNewlines/testClass.lf.cls

@@ -0,0 +1,6 @@
+public class TestClass {
+    public static boolean doTheThing() {
+        List<String> strings = new List<String>{'THis is fine', 'THis is also fine', 'fight club', 'OH NO, that last string was bad!'};
+        return false;
+    }
+}