Update rule mappings

Author: randi274

packages/code-analyzer-eslint-engine/src/rule-mappings.ts

@@ -1601,15 +1601,15 @@ export const RULE_MAPPINGS: Record<string, {severity: SeverityLevel, tags: strin
     //   SLDS/HTML BASE RULES - @salesforce-ux/eslint-plugin-slds
     // =================================================================================================================
     "@salesforce-ux/slds/enforce-bem-usage": {
-        severity: SeverityLevel.High,
-        tags: [COMMON_TAGS.RECOMMENDED, COMMON_TAGS.LANGUAGES.HTML] //TODO: are there other tags?
-    },
-    "@salesforce-ux/slds/no-deprecated-classes-slds2": {
-        severity: SeverityLevel.High,
-        tags: [COMMON_TAGS.RECOMMENDED, COMMON_TAGS.LANGUAGES.HTML]
+        severity: SeverityLevel.Low,
+        tags: [COMMON_TAGS.RECOMMENDED, COMMON_TAGS.CATEGORIES.BEST_PRACTICES, COMMON_TAGS.LANGUAGES.HTML] //TODO: are there other tags?
     },
     "@salesforce-ux/slds/modal-close-button-issue": {
+        severity: SeverityLevel.Moderate,
+        tags: [COMMON_TAGS.RECOMMENDED, COMMON_TAGS.CATEGORIES.BEST_PRACTICES, COMMON_TAGS.LANGUAGES.HTML]
+    },
+    "@salesforce-ux/slds/no-deprecated-classes-slds2": {
         severity: SeverityLevel.High,
-        tags: [COMMON_TAGS.RECOMMENDED, COMMON_TAGS.LANGUAGES.HTML]
+        tags: [COMMON_TAGS.RECOMMENDED, COMMON_TAGS.CATEGORIES.ERROR_PRONE, COMMON_TAGS.LANGUAGES.HTML]
     }
 }

packages/code-analyzer-eslint-engine/test/test-data/rules_OnlySldsBaseConfig.goldfile.json

@@ -5,9 +5,10 @@
     "resourceUrls": [
       "https://developer.salesforce.com/docs/platform/slds-linter/guide/reference-rules.html#enforce-bem-usage"
     ],
-    "severityLevel": 2,
+    "severityLevel": 4,
     "tags": [
       "Recommended",
+      "BestPractices",
       "HTML"
     ]
   },
@@ -17,9 +18,10 @@
     "resourceUrls": [
       "https://developer.salesforce.com/docs/platform/slds-linter/guide/reference-rules.html#modal-close-button-issue"
     ],
-    "severityLevel": 2,
+    "severityLevel": 3,
     "tags": [
       "Recommended",
+      "BestPractices",
       "HTML"
     ]
   },
@@ -32,6 +34,7 @@
     "severityLevel": 2,
     "tags": [
       "Recommended",
+      "ErrorProne",
       "HTML"
     ]
   }