NEW: @W-19276297@: Update dependencies to latest where possible (#352)

stephen-carter-at-sf · web-flow · commit 606c6327de4c · 2025-09-16T15:48:22.000-04:00
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -23,10 +23,10 @@
   "devDependencies": {
     "cross-env": "^10.0.0",
     "husky": "^9.1.7",
-    "jest": "^30.0.5",
+    "jest": "^30.1.3",
     "rimraf": "^6.0.1",
     "semver": "^7.7.2",
-    "ts-jest": "^29.4.1"
+    "ts-jest": "^29.4.2"
   },
   "jest": {
     "testTimeout": 60000,
diff --git a/packages/ENGINE-TEMPLATE/package.json b/packages/ENGINE-TEMPLATE/package.json
@@ -17,14 +17,14 @@
     "@salesforce/code-analyzer-engine-api": "0.29.0-SNAPSHOT"
   },
   "devDependencies": {
-    "@eslint/js": "^9.32.0",
+    "@eslint/js": "^9.35.0",
     "@types/jest": "^30.0.0",
-    "eslint": "^9.32.0",
-    "jest": "^30.0.5",
+    "eslint": "^9.35.0",
+    "jest": "^30.1.3",
     "rimraf": "^6.0.1",
-    "ts-jest": "^29.4.1",
+    "ts-jest": "^29.4.2",
     "typescript": "^5.9.2",
-    "typescript-eslint": "^8.37.0"
+    "typescript-eslint": "^8.44.0"
   },
   "engines": {
     "node": ">=20.0.0"
@@ -60,4 +60,4 @@
       "!src/index.ts"
     ]
   }
-}
+}
diff --git a/packages/code-analyzer-core/package.json b/packages/code-analyzer-core/package.json
@@ -22,22 +22,22 @@
     "js-yaml": "^4.1.0",
     "semver": "^7.7.2",
     "xmlbuilder": "^15.1.1",
-    "tmp": "^0.2.3"
+    "tmp": "^0.2.5"
   },
   "devDependencies": {
-    "@eslint/js": "^9.32.0",
+    "@eslint/js": "^9.35.0",
     "@types/js-yaml": "^4.0.9",
     "@types/jest": "^30.0.0",
     "@types/sarif": "^2.1.7",
     "@types/semver": "^7.7.1",
     "@types/tmp": "^0.2.6",
     "cross-env": "^10.0.0",
-    "eslint": "^9.32.0",
-    "jest": "^30.0.5",
+    "eslint": "^9.35.0",
+    "jest": "^30.1.3",
     "rimraf": "^6.0.1",
-    "ts-jest": "^29.4.1",
+    "ts-jest": "^29.4.2",
     "typescript": "^5.9.2",
-    "typescript-eslint": "^8.37.0"
+    "typescript-eslint": "^8.44.0"
   },
   "engines": {
     "node": ">=20.0.0"
@@ -74,4 +74,4 @@
       "!src/index.ts"
     ]
   }
-}
+}
diff --git a/packages/code-analyzer-engine-api/package.json b/packages/code-analyzer-engine-api/package.json
@@ -19,14 +19,14 @@
     "@types/node": "^20.0.0"
   },
   "devDependencies": {
-    "@eslint/js": "^9.32.0",
+    "@eslint/js": "^9.35.0",
     "@types/jest": "^30.0.0",
-    "eslint": "^9.32.0",
-    "jest": "^30.0.5",
+    "eslint": "^9.35.0",
+    "jest": "^30.1.3",
     "rimraf": "^6.0.1",
-    "ts-jest": "^29.4.1",
+    "ts-jest": "^29.4.2",
     "typescript": "^5.9.2",
-    "typescript-eslint": "^8.37.0"
+    "typescript-eslint": "^8.44.0"
   },
   "engines": {
     "node": ">=20.0.0"
@@ -63,4 +63,4 @@
       "!src/utils/index.ts"
     ]
   }
-}
+}
diff --git a/packages/code-analyzer-eslint-engine/package.json b/packages/code-analyzer-eslint-engine/package.json
@@ -13,33 +13,33 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "dependencies": {
-    "@eslint/js": "^9.32.0",
+    "@eslint/js": "^9.35.0",
     "@lwc/eslint-plugin-lwc": "^3.2.0",
     "@lwc/eslint-plugin-lwc-platform": "^6.1.0",
-    "@salesforce-ux/eslint-plugin-slds": "^0.5.0",
+    "@salesforce-ux/eslint-plugin-slds": "^0.5.3",
     "@salesforce/code-analyzer-engine-api": "0.29.0-SNAPSHOT",
     "@salesforce/code-analyzer-eslint8-engine": "0.6.0-SNAPSHOT",
     "@salesforce/eslint-config-lwc": "^4.0.0",
     "@salesforce/eslint-plugin-lightning": "^2.0.0",
     "@types/node": "^20.0.0",
-    "@typescript-eslint/eslint-plugin": "^8.39.0",
-    "@typescript-eslint/parser": "^8.33.1",
-    "eslint": "^9.32.0",
+    "@typescript-eslint/eslint-plugin": "^8.44.0",
+    "@typescript-eslint/parser": "^8.44.0",
+    "eslint": "^9.35.0",
     "eslint-plugin-import": "^2.32.0",
     "eslint-plugin-jest": "^29.0.1",
-    "globals": "^16.3.0",
+    "globals": "^16.4.0",
     "semver": "^7.7.2",
     "typescript": "^5.9.2",
-    "typescript-eslint": "^8.37.0"
+    "typescript-eslint": "^8.44.0"
   },
   "devDependencies": {
     "@types/jest": "^30.0.0",
     "@types/semver": "^7.7.1",
     "@types/unzipper": "^0.10.11",
     "cross-env": "^10.0.0",
-    "jest": "^30.0.5",
+    "jest": "^30.1.3",
     "rimraf": "^6.0.1",
-    "ts-jest": "^29.4.1",
+    "ts-jest": "^29.4.2",
     "unzipper": "^0.12.3"
   },
   "engines": {
@@ -76,4 +76,4 @@
       "!src/index.ts"
     ]
   }
-}
+}
diff --git a/packages/code-analyzer-eslint-engine/src/rule-mappings.ts b/packages/code-analyzer-eslint-engine/src/rule-mappings.ts
@@ -749,6 +749,10 @@ export const RULE_MAPPINGS: Record<string, {severity: SeverityLevel, tags: strin
         severity: SeverityLevel.Moderate,
         tags: [/* NOT RECOMMENDED */    COMMON_TAGS.CATEGORIES.BEST_PRACTICES, COMMON_TAGS.LANGUAGES.JAVASCRIPT, COMMON_TAGS.LANGUAGES.TYPESCRIPT]
     },
+    "preserve-caught-error": {
+        severity: SeverityLevel.Low,
+        tags: [/* NOT RECOMMENDED */    COMMON_TAGS.CATEGORIES.BEST_PRACTICES, COMMON_TAGS.LANGUAGES.JAVASCRIPT, COMMON_TAGS.LANGUAGES.TYPESCRIPT]
+    },
     "radix": {
         severity: SeverityLevel.Moderate,
         tags: [/* NOT RECOMMENDED */    COMMON_TAGS.CATEGORIES.BEST_PRACTICES, COMMON_TAGS.LANGUAGES.JAVASCRIPT, COMMON_TAGS.LANGUAGES.TYPESCRIPT]
diff --git a/packages/code-analyzer-eslint-engine/test/test-data/rules_OnlyJavaScriptBaseConfig.goldfile.json b/packages/code-analyzer-eslint-engine/test/test-data/rules_OnlyJavaScriptBaseConfig.goldfile.json
@@ -2398,6 +2398,19 @@
       "TypeScript"
     ]
   },
+  {
+    "description": "Disallow losing originally caught error when re-throwing custom errors",
+    "name": "preserve-caught-error",
+    "resourceUrls": [
+      "https://eslint.org/docs/latest/rules/preserve-caught-error"
+    ],
+    "severityLevel": 4,
+    "tags": [
+      "BestPractices",
+      "JavaScript",
+      "TypeScript"
+    ]
+  },
   {
     "description": "Enforce the consistent use of the radix argument when using `parseInt()`",
     "name": "radix",
diff --git a/packages/code-analyzer-eslint-engine/test/test-data/rules_OnlyTypeScriptBaseConfig.goldfile.json b/packages/code-analyzer-eslint-engine/test/test-data/rules_OnlyTypeScriptBaseConfig.goldfile.json
@@ -3420,6 +3420,19 @@
       "TypeScript"
     ]
   },
+  {
+    "description": "Disallow losing originally caught error when re-throwing custom errors",
+    "name": "preserve-caught-error",
+    "resourceUrls": [
+      "https://eslint.org/docs/latest/rules/preserve-caught-error"
+    ],
+    "severityLevel": 4,
+    "tags": [
+      "BestPractices",
+      "JavaScript",
+      "TypeScript"
+    ]
+  },
   {
     "description": "Enforce the consistent use of the radix argument when using `parseInt()`",
     "name": "radix",
diff --git a/packages/code-analyzer-eslint8-engine/package.json b/packages/code-analyzer-eslint8-engine/package.json
@@ -35,9 +35,9 @@
     "@types/jest": "^30.0.0",
     "@types/unzipper": "^0.10.11",
     "cross-env": "^10.0.0",
-    "jest": "^30.0.5",
+    "jest": "^30.1.3",
     "rimraf": "^6.0.1",
-    "ts-jest": "^29.4.1",
+    "ts-jest": "^29.4.2",
     "unzipper": "^0.12.3"
   },
   "engines": {
@@ -75,4 +75,4 @@
       "!src/index.ts"
     ]
   }
-}
+}
diff --git a/packages/code-analyzer-flow-engine/package.json b/packages/code-analyzer-flow-engine/package.json
@@ -19,14 +19,14 @@
     "semver": "^7.7.2"
   },
   "devDependencies": {
-    "@eslint/js": "^9.32.0",
+    "@eslint/js": "^9.35.0",
     "@types/jest": "^30.0.0",
-    "eslint": "^9.32.0",
-    "jest": "^30.0.5",
+    "eslint": "^9.35.0",
+    "jest": "^30.1.3",
     "rimraf": "^6.0.1",
-    "ts-jest": "^29.4.1",
+    "ts-jest": "^29.4.2",
     "typescript": "^5.9.2",
-    "typescript-eslint": "^8.37.0"
+    "typescript-eslint": "^8.44.0"
   },
   "engines": {
     "node": ">=20.0.0"
@@ -63,4 +63,4 @@
       "!src/index.ts"
     ]
   }
-}
+}
diff --git a/packages/code-analyzer-pmd-engine/gradle/libs.versions.toml b/packages/code-analyzer-pmd-engine/gradle/libs.versions.toml
@@ -7,8 +7,8 @@
 
 [versions]
 hamcrest = "3.0"
-junit-jupiter = "5.12.2"
-pmd = "7.16.0" # !!! IMPORTANT !!! KEEP THIS IN SYNC WITH PMD_VERSION INSIDE OF: src/constants.ts
+junit-jupiter = "5.13.4"
+pmd = "7.17.0" # !!! IMPORTANT !!! KEEP THIS IN SYNC WITH PMD_VERSION INSIDE OF: src/constants.ts
 
 # For the following: Keep in sync with whatever pmd-core pulls in. Basically, we don't want duplicates in our java-lib folder.
 # To see pmd-core's dependencies, go to https://mvnrepository.com/artifact/net.sourceforge.pmd/pmd-core
diff --git a/packages/code-analyzer-pmd-engine/package.json b/packages/code-analyzer-pmd-engine/package.json
@@ -19,14 +19,14 @@
     "semver": "^7.7.2"
   },
   "devDependencies": {
-    "@eslint/js": "^9.32.0",
+    "@eslint/js": "^9.35.0",
     "@types/jest": "^30.0.0",
-    "eslint": "^9.32.0",
-    "jest": "^30.0.5",
+    "eslint": "^9.35.0",
+    "jest": "^30.1.3",
     "rimraf": "^6.0.1",
-    "ts-jest": "^29.4.1",
+    "ts-jest": "^29.4.2",
     "typescript": "^5.9.2",
-    "typescript-eslint": "^8.37.0"
+    "typescript-eslint": "^8.44.0"
   },
   "engines": {
     "node": ">=20.0.0"
@@ -71,4 +71,4 @@
       "!src/index.ts"
     ]
   }
-}
+}
diff --git a/packages/code-analyzer-pmd-engine/pmd-rules/src/test/resources/sfca/rulesets/appexchange_apex/xml/AvoidGlobalInstallUninstallHandlers.xml b/packages/code-analyzer-pmd-engine/pmd-rules/src/test/resources/sfca/rulesets/appexchange_apex/xml/AvoidGlobalInstallUninstallHandlers.xml
@@ -16,6 +16,7 @@ global class PackageInstallHandler implements InstallHandler {
 }
         ]]></code>
     </test-code>
+    
     <test-code>
         <description>When the InstallHandler interface is extended on a public class, then do not report a violation</description>
         <expected-problems>0</expected-problems>
@@ -26,6 +27,8 @@ public class PackageInstallHandler implements InstallHandler{
     }
 }
         ]]></code>
+    </test-code>
+
     <test-code>
         <description>When the UninstallHandler interface is extended on a global class, then report a violation</description>
         <expected-problems>1</expected-problems>
@@ -38,7 +41,6 @@ global with sharing class PackageUninstallHandler implements UninstallHandler{
 }
         ]]></code>
     </test-code>
-    </test-code>
 
     <test-code>
         <description>When the UninstallHandler interface is extended on a public class, then do not report a violation</description>
diff --git a/packages/code-analyzer-pmd-engine/src/constants.ts b/packages/code-analyzer-pmd-engine/src/constants.ts
@@ -1,5 +1,5 @@
 // !!! IMPORTANT !!! KEEP THIS IN SYNC WITH gradle/libs.versions.toml
-export const PMD_VERSION: string = '7.16.0';
+export const PMD_VERSION: string = '7.17.0';
 
 export const PMD_ENGINE_NAME: string = "pmd";
 export const CPD_ENGINE_NAME: string = "cpd";
diff --git a/packages/code-analyzer-pmd-engine/src/pmd-rule-mappings.ts b/packages/code-analyzer-pmd-engine/src/pmd-rule-mappings.ts
@@ -16,6 +16,10 @@ export const RULE_MAPPINGS: Record<string, {severity: SeverityLevel, tags: strin
     // =================================================================================================================
     //   PMD-APEX RULES
     // =================================================================================================================
+    "AnnotationsNamingConventions": {
+        severity: SeverityLevel.Low,
+        tags: [COMMON_TAGS.RECOMMENDED, COMMON_TAGS.CATEGORIES.CODE_STYLE,     COMMON_TAGS.LANGUAGES.APEX]
+    },
     "ApexAssertionsShouldIncludeMessage": {
         severity: SeverityLevel.Moderate,
         tags: [/* NOT RECOMMENDED */    COMMON_TAGS.CATEGORIES.BEST_PRACTICES, COMMON_TAGS.LANGUAGES.APEX]
diff --git a/packages/code-analyzer-pmd-engine/test/pmd-engine.test.ts b/packages/code-analyzer-pmd-engine/test/pmd-engine.test.ts
@@ -19,7 +19,6 @@ import path from "node:path";
 import {Language, PMD_VERSION} from "../src/constants";
 import {DEFAULT_PMD_ENGINE_CONFIG, PMD_AVAILABLE_LANGUAGES, PmdEngineConfig} from "../src/config";
 import {PmdCpdEnginesPlugin} from "../src";
-import os from "node:os";
 
 changeWorkingDirectoryToPackageRoot();
 
diff --git a/packages/code-analyzer-pmd-engine/test/test-data/pmdGoldfiles/rules_apexOnly.goldfile.json b/packages/code-analyzer-pmd-engine/test/test-data/pmdGoldfiles/rules_apexOnly.goldfile.json
@@ -1,4 +1,17 @@
 [
+  {
+    "name": "AnnotationsNamingConventions",
+    "severityLevel": 4,
+    "tags": [
+      "Recommended",
+      "CodeStyle",
+      "Apex"
+    ],
+    "description": "Apex, while case-insensitive, benefits from a consistent code style to improve readability and maintainability. Enforcing PascalCase for annotations aligns with the established conventions and reduces ambiguity - promoting a unified coding standard.",
+    "resourceUrls": [
+      "https://docs.pmd-code.org/pmd-doc-{{PMD_VERSION}}/pmd_rules_apex_codestyle.html#annotationsnamingconventions"
+    ]
+  },
   {
     "name": "ApexAssertionsShouldIncludeMessage",
     "severityLevel": 3,
diff --git a/packages/code-analyzer-regex-engine/package.json b/packages/code-analyzer-regex-engine/package.json
@@ -19,14 +19,14 @@
     "p-limit": "^3.1.0"
   },
   "devDependencies": {
-    "@eslint/js": "^9.32.0",
+    "@eslint/js": "^9.35.0",
     "@types/jest": "^30.0.0",
-    "eslint": "^9.32.0",
-    "jest": "^30.0.5",
+    "eslint": "^9.35.0",
+    "jest": "^30.1.3",
     "rimraf": "^6.0.1",
-    "ts-jest": "^29.4.1",
+    "ts-jest": "^29.4.2",
     "typescript": "^5.9.2",
-    "typescript-eslint": "^8.37.0"
+    "typescript-eslint": "^8.44.0"
   },
   "engines": {
     "node": ">=20.0.0"
@@ -62,4 +62,4 @@
       "!src/index.ts"
     ]
   }
-}
+}
diff --git a/packages/code-analyzer-retirejs-engine/package.json b/packages/code-analyzer-retirejs-engine/package.json
diff --git a/packages/code-analyzer-sfge-engine/gradle/libs.versions.toml b/packages/code-analyzer-sfge-engine/gradle/libs.versions.toml
diff --git a/packages/code-analyzer-sfge-engine/package.json b/packages/code-analyzer-sfge-engine/package.json
