Skip to content

Commit 665351d

Browse files
authored
FIX @W-18212468@ Fixed ambiguous HTML text (#321)
1 parent e71236b commit 665351d

File tree

5 files changed

+13
-5
lines changed

5 files changed

+13
-5
lines changed

packages/code-analyzer-core/output-templates/html-template-0.0.11.txt renamed to packages/code-analyzer-core/output-templates/html-template-0.0.12.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,9 @@
258258
}
259259
updateSummary(data2) {
260260
const uniqueFiles = new Set(data2.map((v) => v.file));
261-
(this.summary.textContent = `Found ${data2.length} violation${1 !== data2.length ? "s" : ""} across ${uniqueFiles.size} file${1 !== uniqueFiles.size ? "s" : ""}`),
261+
0 === data2.length
262+
? (this.summary.textContent = "Found 0 violations")
263+
: (this.summary.textContent = `Found ${data2.length} violation${1 !== data2.length ? "s" : ""} across ${uniqueFiles.size} file${1 !== uniqueFiles.size ? "s" : ""}`),
262264
this.violationsTable.classList.toggle("hidden", 0 === data2.length);
263265
}
264266
updateBoxes(data2) {

packages/code-analyzer-core/src/output-formats/results/html-run-results-format.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
toJsonResultsOutput
99
} from "./json-run-results-format";
1010

11-
const HTML_TEMPLATE_VERSION: string = '0.0.11';
11+
const HTML_TEMPLATE_VERSION: string = '0.0.12';
1212
const HTML_TEMPLATE_FILE: string = path.resolve(__dirname, '..', '..', '..', 'output-templates', `html-template-${HTML_TEMPLATE_VERSION}.txt`);
1313

1414
/**

packages/code-analyzer-core/test/test-data/expectedOutputFiles/multipleViolations.goldfile.html

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,9 @@
258258
}
259259
updateSummary(data2) {
260260
const uniqueFiles = new Set(data2.map((v) => v.file));
261-
(this.summary.textContent = `Found ${data2.length} violation${1 !== data2.length ? "s" : ""} across ${uniqueFiles.size} file${1 !== uniqueFiles.size ? "s" : ""}`),
261+
0 === data2.length
262+
? (this.summary.textContent = "Found 0 violations")
263+
: (this.summary.textContent = `Found ${data2.length} violation${1 !== data2.length ? "s" : ""} across ${uniqueFiles.size} file${1 !== uniqueFiles.size ? "s" : ""}`),
262264
this.violationsTable.classList.toggle("hidden", 0 === data2.length);
263265
}
264266
updateBoxes(data2) {

packages/code-analyzer-core/test/test-data/expectedOutputFiles/unexpectedEngineErrorViolation.goldfile.html

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,9 @@
258258
}
259259
updateSummary(data2) {
260260
const uniqueFiles = new Set(data2.map((v) => v.file));
261-
(this.summary.textContent = `Found ${data2.length} violation${1 !== data2.length ? "s" : ""} across ${uniqueFiles.size} file${1 !== uniqueFiles.size ? "s" : ""}`),
261+
0 === data2.length
262+
? (this.summary.textContent = "Found 0 violations")
263+
: (this.summary.textContent = `Found ${data2.length} violation${1 !== data2.length ? "s" : ""} across ${uniqueFiles.size} file${1 !== uniqueFiles.size ? "s" : ""}`),
262264
this.violationsTable.classList.toggle("hidden", 0 === data2.length);
263265
}
264266
updateBoxes(data2) {

packages/code-analyzer-core/test/test-data/expectedOutputFiles/zeroViolations.goldfile.html

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,9 @@
258258
}
259259
updateSummary(data2) {
260260
const uniqueFiles = new Set(data2.map((v) => v.file));
261-
(this.summary.textContent = `Found ${data2.length} violation${1 !== data2.length ? "s" : ""} across ${uniqueFiles.size} file${1 !== uniqueFiles.size ? "s" : ""}`),
261+
0 === data2.length
262+
? (this.summary.textContent = "Found 0 violations")
263+
: (this.summary.textContent = `Found ${data2.length} violation${1 !== data2.length ? "s" : ""} across ${uniqueFiles.size} file${1 !== uniqueFiles.size ? "s" : ""}`),
262264
this.violationsTable.classList.toggle("hidden", 0 === data2.length);
263265
}
264266
updateBoxes(data2) {

0 commit comments

Comments
 (0)