Skip to content

Commit 68e0bcd

Browse files
CHANGE: @W-19604190@ Remove unneeded stylelint and T-E-M-P-L-A-T-E workspaces
1 parent 8a6dc78 commit 68e0bcd

26 files changed

+25
-1091
lines changed

.github/workflows/verify-pr/identify-affected-workspaces.mjs

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ function main() {
1919
displayList('THE FOLLOWING FILES WERE CHANGED:', changedFiles);
2020

2121
const changedPackages = identifyChangedPackages(changedFiles);
22+
2223
if (changedPackages.length === 0) {
2324
console.log(`No package-level changes. Using empty workspace arg to test all packages.`);
2425
fs.writeFileSync(tmpFilePath, '');
@@ -34,7 +35,17 @@ function main() {
3435
console.log(`NO PACKAGES HAVE DEPENDENCIES ON CHANGED PACKAGES.\n`);
3536
}
3637

37-
const affectedPackages = [...(new Set([...changedPackages, ...dependentPackages]).keys())];
38+
const undeletedChangedPackages = changedPackages.filter(pkgLocation => {
39+
const packageName = pkgLocation.replace("packages","").replace("/","").replace("\\","");
40+
if(fs.existsSync(getPackageJsonFile(packageName))) {
41+
return true;
42+
} else {
43+
console.log(`Removing package '${packageName}' from list of workspaces since it seems to have been deleted.`);
44+
}
45+
});
46+
47+
48+
const affectedPackages = [...(new Set([...undeletedChangedPackages, ...dependentPackages]).keys())];
3849
displayList('BASED ON THE ABOVE, THE FOLLOWING PACKAGES ARE AFFECTED BY CHANGES, AND WILL REQUIRE TESTING:', affectedPackages);
3950

4051
const correspondingWorkspaceArgs = affectedPackages.map(name => `--workspace ${name}`);
@@ -100,8 +111,12 @@ function getAllPackageJsons() {
100111
return packagesDir.filter(f => fs.statSync(path.join(pathToRoot, 'packages', f)).isDirectory()).map(getPackageJson);
101112
}
102113

114+
function getPackageJsonFile(packageName) {
115+
return path.join(pathToRoot, 'packages', packageName, 'package.json');
116+
}
117+
103118
function getPackageJson(packageName) {
104-
const packageJsonPath = path.join(pathToRoot, 'packages', packageName, 'package.json');
119+
const packageJsonPath = getPackageJsonFile(packageName);
105120
return JSON.parse(fs.readFileSync(packageJsonPath, 'utf-8'));
106121
}
107122

.node-scripts/validate-changed-package-versions.js

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,15 @@ function isFileInTestFolder(changedFile) {
7575

7676
function identifyIncorrectlyVersionedPackages(changedPackages) {
7777
const incorrectlyVersionedPackages = [];
78+
7879
for (const changedPackage of changedPackages) {
79-
const packageVersion = getPackageVersion(changedPackage);
80+
81+
const packageJsonPath = path.join(changedPackage, 'package.json');
82+
if (!fs.existsSync(packageJsonPath)) {
83+
continue; // This means the package was deleted, so we ignore this package
84+
}
85+
const packageVersion = JSON.parse(fs.readFileSync(packageJsonPath, 'utf-8')).version;
86+
8087
if (!packageVersion.endsWith('-SNAPSHOT')) {
8188
incorrectlyVersionedPackages.push(`${changedPackage} (currently versioned as ${packageVersion}) lacks a trailing "-SNAPSHOT"`);
8289
continue;
@@ -102,9 +109,4 @@ function getLatestReleasedVersion(changedPackage) {
102109
}
103110
}
104111

105-
function getPackageVersion(changedPackage) {
106-
const packageJsonPath = path.join(changedPackage, 'package.json');
107-
return JSON.parse(fs.readFileSync(packageJsonPath, 'utf-8')).version;
108-
}
109-
110112
main();

0 commit comments

Comments
 (0)