Review cleanup

Author: randi274

packages/code-analyzer-eslint-engine/src/base-config.ts

@@ -110,7 +110,6 @@ export class BaseConfigFactory {
     }
 
     private createSldsConfigArray(): Linter.Config[] {
-        //todo: Should this need to be updated now to take CSS into consideration?
         return sldsEslintPlugin.configs['flat/recommended'].map(conf => ({
             ...conf,
             files: this.engineConfig.file_extensions.html.map(ext => `**/*${ext}`)

packages/code-analyzer-eslint-engine/src/rule-mappings.ts

@@ -1602,7 +1602,7 @@ export const RULE_MAPPINGS: Record<string, {severity: SeverityLevel, tags: strin
     // =================================================================================================================
     "@salesforce-ux/slds/enforce-bem-usage": {
         severity: SeverityLevel.Low,
-        tags: [COMMON_TAGS.RECOMMENDED, COMMON_TAGS.CATEGORIES.BEST_PRACTICES, COMMON_TAGS.LANGUAGES.HTML] //TODO: are there other tags?
+        tags: [COMMON_TAGS.RECOMMENDED, COMMON_TAGS.CATEGORIES.BEST_PRACTICES, COMMON_TAGS.LANGUAGES.HTML]
     },
     "@salesforce-ux/slds/modal-close-button-issue": {
         severity: SeverityLevel.Moderate,

packages/code-analyzer-eslint-engine/test/plugin.test.ts

@@ -288,6 +288,17 @@ describe('Tests for the ESLintEnginePlugin', () => {
                 'engines.eslint.file_extensions', '.js', '["javascript","typescript"]'));
     });
 
+    it('When a supported extension is listed under other language in file_extensions, then createEngineConfig errors', async () => {
+        const userProvidedOverrides: ConfigObject = {
+            file_extensions: {
+                other: ['.html']
+            }
+        };
+        await expect(callCreateEngineConfig(plugin, userProvidedOverrides)).rejects.toThrow(
+            getMessage('InvalidFileExtensionDueToItBeingListedTwice',
+                'engines.eslint.file_extensions', '.html', '["html","other"]'));
+    });
+
     it('When createEngine is passed an invalid engine name, then an error is thrown', async () => {
         await expect(plugin.createEngine('oops', DEFAULT_CONFIG)).rejects.toThrow(
             getMessage('UnsupportedEngineName' ,'oops'));

packages/code-analyzer-eslint-engine/test/test-data/workspaceWithFlatConfigMjs/eslint.config.mjs

@@ -1,7 +1,6 @@
 export default [
     {
         rules: {
-            "array-callback-return": ["error"],
             "array-callback-return": ["error"],
             "no-unused-vars": ["error", { argsIgnorePattern: "^_" }],
             "no-useless-backreference": ["warn"],