@W-17311830@ FlowTest no longer makes log files

Author: jfeingold35

packages/code-analyzer-flowtest-engine/FlowTest/flowtest/__main__.py

@@ -176,6 +176,8 @@ def parse_args(my_args: list[str], default: str = None) -> argparse.Namespace:
                         type=check_not_exist)
 
     parser.add_argument("--debug", action='store_true', help="whether to set logging level to debug")
+    parser.add_argument("--no_log", action='store_true', help="disables logging")
+
 
     """
         Options for crawl-spec generation
@@ -248,12 +250,16 @@ def main(argv: list[str] = None) -> str | None:
         return
 
     # logging
-    if args.debug is True:
-        log_level = logging.DEBUG
+    if args.no_log is True:
+        logging.getLogger().setLevel(logging.CRITICAL + 1)
     else:
-        log_level = logging.WARNING
+        if args.debug is True:
+            log_level = logging.DEBUG
+
+        else:
+            log_level = logging.WARNING
 
-    setup_logger(level=log_level, log_file=args.log_file)
+        setup_logger(level=log_level, log_file=args.log_file)
 
     if args.query_path is not None and args.query_class is None:
         raise argparse.ArgumentTypeError("A query_class must be provided if a query_path is set")

packages/code-analyzer-flowtest-engine/FlowTest/flowtest/version.py

@@ -1,5 +1,5 @@
-# Store the version here so:
+1# Store the version here so:
 # 1) we don't load dependencies by storing it in __init__.py
 # 2) we can import it in setup.py for the same reason
 # 3) we can import it into your module
-__version__ = '0.7.0-ALPHA'
+__version__ = '0.7.1'

packages/code-analyzer-flowtest-engine/package.json

@@ -17,6 +17,7 @@
     "@types/node": "^20.0.0",
     "@types/semver": "^7.5.8",
     "@types/tmp": "^0.2.6",
+    "fast-glob": "^3.3.2",
     "semver": "^7.6.3",
     "tmp": "^0.2.3"
   },

packages/code-analyzer-flowtest-engine/src/python/FlowTestCommandWrapper.ts

@@ -48,6 +48,7 @@ export class RunTimeFlowTestCommandWrapper implements FlowTestCommandWrapper {
         const pythonArgs: string[] = [
             '-m',
             'flowtest',
+            '--no_log',
             '-j',
             tmpFile,
             '-d',

packages/code-analyzer-flowtest-engine/test/python/FlowTestCommandWrapper.test.ts

@@ -2,6 +2,7 @@ import fs from 'node:fs/promises';
 import path from 'node:path';
 import {FlowTestExecutionResult, RunTimeFlowTestCommandWrapper} from "../../src/python/FlowTestCommandWrapper";
 import {PythonCommandExecutor} from '../../src/python/PythonCommandExecutor';
+import * as fg from 'fast-glob';
 
 const PYTHON_COMMAND = 'python3';
 const PATH_TO_GOLDFILES = path.join(__dirname, '..', 'test-data', 'goldfiles', 'FlowTestCommandWrapper.test.ts');
@@ -20,6 +21,7 @@ describe('FlowTestCommandWrapper implementations', () => {
                 };
 
                 beforeAll(async () => {
+                    console.log(process.cwd());
                     results = await wrapper.runFlowTestRules(path.join(PATH_TO_WORKSPACES, 'contains-multiple-flows'), statusProcessorFunction);
                     // The `counter` property is irrelevant to us, and causes problems across platforms. So delete it.
                     for (const queryName of Object.keys(results.results)) {
@@ -55,6 +57,11 @@ describe('FlowTestCommandWrapper implementations', () => {
                 it('Correctly parses status updates from stdout', () => {
                     expect(completionPercentages).toEqual([0, 25, 50, 75]);
                 });
+
+                it('Generates no log file', async () => {
+                    const flowLogFiles = await fg.glob('./**/.flowtest_log_*.log');
+                    expect(flowLogFiles).toHaveLength(0);
+                });
             });
 
             describe('Failure Modes', () => {