CHANGE: @W-19348414@ Finalize new SLDS rule tags (#329)

Author: randi274

packages/code-analyzer-eslint-engine/src/rule-mappings.ts

@@ -1,7 +1,8 @@
 import {COMMON_TAGS, SeverityLevel} from "@salesforce/code-analyzer-engine-api";
 
-// Convenience tag to apply to the LWC rules
+// Convenience tag to apply to framework specific rules
 const LWC = "LWC";
+const SLDS = "SLDS";
 
 /**
  * The following is a list of the base rules that we have reviewed where we have designated the rule tags and
@@ -1601,15 +1602,15 @@ export const RULE_MAPPINGS: Record<string, {severity: SeverityLevel, tags: strin
     //   SLDS/HTML BASE RULES - @salesforce-ux/eslint-plugin-slds
     // =================================================================================================================
     "@salesforce-ux/slds/enforce-bem-usage": {
-        severity: SeverityLevel.Low,
-        tags: [COMMON_TAGS.RECOMMENDED, COMMON_TAGS.CATEGORIES.BEST_PRACTICES, COMMON_TAGS.LANGUAGES.HTML]
+        severity: SeverityLevel.Moderate,
+        tags: [COMMON_TAGS.RECOMMENDED, SLDS, COMMON_TAGS.CATEGORIES.BEST_PRACTICES, COMMON_TAGS.LANGUAGES.HTML]
     },
     "@salesforce-ux/slds/modal-close-button-issue": {
-        severity: SeverityLevel.Moderate,
-        tags: [COMMON_TAGS.RECOMMENDED, COMMON_TAGS.CATEGORIES.BEST_PRACTICES, COMMON_TAGS.LANGUAGES.HTML]
+        severity: SeverityLevel.High,
+        tags: [COMMON_TAGS.RECOMMENDED, SLDS, COMMON_TAGS.CATEGORIES.ERROR_PRONE, COMMON_TAGS.LANGUAGES.HTML]
     },
     "@salesforce-ux/slds/no-deprecated-classes-slds2": {
         severity: SeverityLevel.High,
-        tags: [COMMON_TAGS.RECOMMENDED, COMMON_TAGS.CATEGORIES.ERROR_PRONE, COMMON_TAGS.LANGUAGES.HTML]
+        tags: [COMMON_TAGS.RECOMMENDED, SLDS, COMMON_TAGS.CATEGORIES.ERROR_PRONE, COMMON_TAGS.LANGUAGES.HTML]
     }
 }

packages/code-analyzer-eslint-engine/test/test-data/rules_OnlySldsBaseConfig.goldfile.json

@@ -5,9 +5,10 @@
     "resourceUrls": [
       "https://developer.salesforce.com/docs/platform/slds-linter/guide/reference-rules.html#enforce-bem-usage"
     ],
-    "severityLevel": 4,
+    "severityLevel": 3,
     "tags": [
       "Recommended",
+      "SLDS",
       "BestPractices",
       "HTML"
     ]
@@ -18,10 +19,11 @@
     "resourceUrls": [
       "https://developer.salesforce.com/docs/platform/slds-linter/guide/reference-rules.html#modal-close-button-issue"
     ],
-    "severityLevel": 3,
+    "severityLevel": 2,
     "tags": [
       "Recommended",
-      "BestPractices",
+      "SLDS",
+      "ErrorProne",
       "HTML"
     ]
   },
@@ -34,6 +36,7 @@
     "severityLevel": 2,
     "tags": [
       "Recommended",
+      "SLDS",
       "ErrorProne",
       "HTML"
     ]