@W-17330636@ Fixing error in release process

Author: jfeingold35

.github/workflows/publish-package-to-npm.yml

@@ -112,19 +112,14 @@ jobs:
       - name: Strip '-SNAPSHOT' from to-be-released package versions
         run: |
           PACKAGE_LIST=(${{ needs.validate-packages-as-releasable.outputs.packages-to-release }})
-          for PACKAGE_NAME in "${PACKAGE_LIST[@]}"
-          do
-            cd ./packages/${PACKAGE_NAME}
-            npm --no-git-tag-version version patch # Increments X.Y.Z-SNAPSHOT to X.Y.Z, which is what we want.
-            cd ../..
-          done
+          node ./.github/workflows/publish-package-to-npm/update-versions-in-released-packages "$PACKAGE_LIST"
       - name: Update inter-package dependencies
         run: |
           RELEASABLE_PACKAGES=${{ needs.validate-packages-as-releasable.outputs.packages-to-release }}
           cd packages
           ALL_PACKAGES=`ls`
           cd ..
-          node ./.github/workflows/publish-package-to-npm/update-dependencies-on-released-pacakges.js "$RELEASABLE_PACKAGES" "$ALL_PACKAGES"
+          node ./.github/workflows/publish-package-to-npm/update-dependencies-on-released-packages.js "$RELEASABLE_PACKAGES" "$ALL_PACKAGES"
       - name: Build
         run: |
           npm install

.github/workflows/publish-package-to-npm/update-dependencies-on-released-packages.js

@@ -10,7 +10,7 @@ function main() {
 
     const packageChangesMade = updatePackageDependenciesAndDescribeChanges(packageJsonsToRelease, allPackageJsons);
     if (packageChangesMade.size > 0) {
-        displayMapOfLists('THE FOLLOWING DEPENDENCY CHANGES WERE MADE CHANGES WERE MADE:', packageChangesMade);
+        displayMapOfLists('THE FOLLOWING DEPENDENCY CHANGES WERE MADE:', packageChangesMade);
         persistPackageJsons(allPackages, allPackageJsons);
     } else {
         console.log('NO PACKAGE.JSON CHANGES WERE MADE');

.github/workflows/publish-package-to-npm/update-versions-in-released-packages.js

@@ -0,0 +1,63 @@
+const path = require('path');
+const fs = require('fs');
+
+function main() {
+    const packagesToRelease = process.argv[2].split(" ");
+
+    const packageJsonsToRelease = getPackageJsons(packagesToRelease);
+
+    const packageChangesMade = updatePackageVersionsAndDescribeChanges(packageJsonsToRelease);
+
+    if (packageChangesMade.length > 0) {
+        displayList('THE FOLLOWING VERSION CHANGES WERE MADE:', packageChangesMade);
+        persistPackageJsons(packagesToRelease, packageJsonsToRelease);
+    } else {
+        console.log('NO PACKAGE.JSON CHANGES WERE MADE');
+    }
+}
+
+function displayList(header, list) {
+    console.log(header);
+    for (const listItem of list) {
+        console.log(`* ${listItem}`);
+    }
+    console.log('');
+}
+
+function getPackageJsons(packageNames) {
+    return packageNames.map(getPackageJson);
+}
+
+function getPackageJson(packageName) {
+    const packageJsonPath = path.join('packages', packageName, 'package.json');
+    return JSON.parse(fs.readFileSync(packageJsonPath, 'utf-8'));
+}
+
+function updatePackageVersionsAndDescribeChanges(packageJsons) {
+    const changeDescriptionList = [];
+    for (const packageJson of packageJsons) {
+        const packageName = packageJson.name;
+
+        // The version has already been validated as ending in `-SNAPSHOT`, so just rip that many characters off the end.
+        const oldVersion = packageJson.version;
+        const newVersion = oldVersion.slice(0, oldVersion.length - `-SNAPSHOT`.length);
+        packageJson.version = newVersion;
+
+        changeDescriptionList.push(`${packageName} from ${oldVersion} to ${newVersion}`);
+    }
+    return changeDescriptionList;
+}
+
+function persistPackageJsons(packageNames, packageJsons) {
+    packageNames.forEach((packageName, idx) => {
+        const packageJson = packageJsons[idx];
+        persistPackageJson(packageName, packageJson);
+    });
+}
+
+function persistPackageJson(packageName, packageJson) {
+    const packageJsonPath = path.join('packages', packageName, 'package.json');
+    fs.writeFileSync(packageJsonPath, JSON.stringify(packageJson, null, 2));
+}
+
+main();