Skip to content

Commit 49e6efe

Browse files
jfeingold35jfeingold35
authored
Merge pull request #1556 from forcedotcom/release-4.4.0
RELEASE: @W-16095971@: Conducting v4.4.0 release.
2 parents 1b58848 + 0c65a24 commit 49e6efe

File tree

61 files changed

+1081
-918
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

61 files changed

+1081
-918
lines changed

‎.eslintrc.json‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,8 @@
1313
},
1414
"plugins": [
1515
"@typescript-eslint"
16-
]
16+
],
17+
"rules": {
18+
"sf-plugin/only-extend-SfCommand": "off"
19+
}
1720
}

‎.github/workflows/create-release-branch.yml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,9 @@ jobs:
144144
NEW_VERSION=$(jq -r ".version" package.json)
145145
git checkout -b release-$NEW_VERSION
146146
git push --set-upstream origin release-$NEW_VERSION
147-
# Output the branch name so we can use it in later jobs.
147+
# Now that we're done with the interim branch, delete it.
148+
git push -d origin ${NEW_VERSION}-interim
149+
# Output the release branch name so we can use it in later jobs.
148150
echo "branch_name=release-$NEW_VERSION" >> "$GITHUB_OUTPUT"
149151
# Run all the various tests against the newly created branch.
150152
test-release-branch:

‎cli-messaging/build.gradle.kts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ dependencies {
1818
exclude("junit")
1919
}
2020
implementation("com.google.code.gson:gson:2.10.1")
21-
implementation("com.google.guava:guava:31.1-jre")
21+
implementation("com.google.guava:guava:33.2.1-jre")
2222

2323
testImplementation("org.hamcrest:hamcrest:2.2")
2424
testImplementation("org.junit.jupiter:junit-jupiter-api:5.9.2")

‎html-templates/simple.mustache‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
<script type="text/javascript" language="javascript"
6666
src="https://cdn.datatables.net/1.10.21/js/jquery.dataTables.min.js"></script>
6767
<script type="text/javascript" language="javascript" src="https://cdn.datatables.net/rowgroup/1.1.2/js/dataTables.rowGroup.min.js"></script>
68-
<script type="text/javascript" language="javascript" src="https://cdn.jsdelivr.net/npm/[email protected]/dist/Chart.min.js"></script>
68+
<script type="text/javascript" language="javascript" src="https://cdn.jsdelivr.net/npm/[email protected]/dist/Chart.min.js"></script>
6969
<script type="text/javascript" class="init">
7070
7171
// BEGIN - Placeholders filled in by the scanner
@@ -294,11 +294,12 @@
294294
});
295295
});
296296
</script>
297+
<title>Salesforce Code Analyzer Report</title>
297298
</head>
298299

299300
<body>
300301
<h1 id="reportTitle">Salesforce Code Analyzer Report</h1>
301-
<div id="summaryChart"/></div>
302+
<div id="summaryChart"></div>
302303
<h4 id="summaryFiles"></h4>
303304
<h4 id="summaryViolations"></h4>
304305
<div class="fw-container">
@@ -319,7 +320,7 @@
319320
<th>End Column</th>
320321
</tr>
321322
</thead>
322-
<tbody/>
323+
<tbody></tbody>
323324
</table>
324325
</div>
325326
</div>

‎messages/RetireJsEngine.md‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# error.couldNotGetZipEntries
2+
3+
Failed to get entries from ZIP file %s. Reason: %s.
4+
5+
# error.couldNotReadEntryData
6+
7+
Failed to read contents of entry %s in ZIP file %s. Reason: %s.
8+
9+
# error.couldNotExtractZip
10+
11+
Failed to extract ZIP file %s. Reason: %s.

‎messages/run-common.md‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,10 +74,6 @@ The selected output format doesn't match the output file type. Output format: %s
7474

7575
--projectdir must specify existing paths
7676

77-
# validations.noFilesFoundInTarget
78-
79-
No files were found in the target. --target must contain at least one file.
80-
8177
# info.resolvedTarget
8278

8379
The --target flag wasn't specified so the default target '.' will be used.

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@salesforce/sfdx-scanner",
33
"description": "Static code scanner that applies quality and security rules to Apex code, and provides feedback.",
4-
"version": "4.3.2",
4+
"version": "4.4.0",
55
"author": "Salesforce Code Analyzer Team",
66
"bugs": "https://github.com/forcedotcom/sfdx-scanner/issues",
77
"dependencies": {

‎pmd-appexchange/docs/AvoidCreateElementScriptLinkTag.md‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,9 @@ AvoidCreateElementScriptLinkTag[](#avoidcreateelementscriptlinktag)
1010

1111
**Description:**
1212

13-
Detects dynamic creation of script or link tags
13+
Detects dynamic creation of script or link tags
14+
Note: This rule identifies the `<script>` block where `createElement` is detected; but can only show the line number where the `<script>` tag begins and not the line number for `createElement`.
15+
That means if there are multiple `createElement` calls with `script` as input, you'll see multiple issues reported with the line number of the `<script>` tag. This is a known issue; developers are expected to go through the `<script>` block to identify the use of `createElement`
1416

1517
**Example(s):**
1618

‎pmd-appexchange/docs/AvoidDisableProtocolSecurity.md‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
AvoidDisableProtocolSecurity[](#avoiddisableprotocolsecurity)
2+
------------------------------------------------------------------------------------------------------------------------------------------------------
3+
4+
**Violation:**
5+
6+
Protocol security setting is disabled
7+
8+
9+
**Priority:** Medium (3)
10+
11+
**Description:**
12+
13+
Detects if "Disable Protocol Security" setting is checked/true
14+
15+
**Example(s):**
16+
17+
18+

‎pmd-appexchange/docs/AvoidHardCodedCredentialsInAura.md‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
AvoidHardCodedCredentialsInAura[](#avoidhardcodedcredentialsinaura)
2+
------------------------------------------------------------------------------------------------------------------------------------------------------
3+
4+
**Violation:**
5+
6+
Detected use of hard coded credentials in Aura component
7+
8+
9+
**Priority:** High (2)
10+
11+
**Description:**
12+
13+
Detected use of hard coded credentials in Aura component
14+
15+
**Example(s):**
16+
17+
18+

0 commit comments

Comments
 (0)