Skip to content

Commit 5aef9ee

Browse files
committed
@W-11464344@: Integrating feedback from code review.
1 parent ca61d44 commit 5aef9ee

File tree

2 files changed

+1
-17
lines changed

2 files changed

+1
-17
lines changed

sfge/src/main/java/com/salesforce/rules/unusedmethod/RuleStateTracker.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -218,12 +218,7 @@ List<String> getSubclasses(String... definingTypes) {
218218
return results;
219219
}
220220

221-
/**
222-
* Get any inner classes that reside in {@code definingType}.
223-
*
224-
* @param definingType
225-
* @return
226-
*/
221+
/** Get any inner classes that reside in {@code definingType}. */
227222
List<UserClassVertex> getInnerClasses(String definingType) {
228223
if (!this.innerClassesByDefiningType.containsKey(definingType)) {
229224
this.innerClassesByDefiningType.put(
@@ -246,10 +241,6 @@ boolean classInheritsMatchingMethod(String definingType, String signature) {
246241
/**
247242
* Get all {@link MethodCallExpressionVertex} instances representing invocations of a method
248243
* named {@code methodName} on a thing called {@code referencedType}.
249-
*
250-
* @param referencedType
251-
* @param methodName
252-
* @return
253244
*/
254245
List<MethodCallExpressionVertex> getInvocationsOnType(
255246
String referencedType, String methodName) {

sfge/src/test/java/com/salesforce/rules/unusedmethod/StaticMethodsTest.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -375,13 +375,6 @@ public void externalReferenceSyntaxCollision_expectViolation(String collidingNam
375375
+ " /* sfge-disable-stack UnusedMethodRule */\n"
376376
+ " public boolean causeCollision(InstanceCollider methodParam) {\n"
377377
+ " InstanceCollider variable = new InstanceCollider();\n"
378-
+ " Integer variable2 = 15;\n"
379-
+ " variable2 += 2;\n"
380-
+ " InstanceCollider variable3 = new InstanceCollider();\n"
381-
+ " InstanceCollider variable4 = new InstanceCollider();\n"
382-
+ " InstanceCollider variable5 = new InstanceCollider();\n"
383-
+ " InstanceCollider variable6 = new InstanceCollider();\n"
384-
+ " InstanceCollider variable7 = new InstanceCollider();\n"
385378
+ " return " + collidingName + ".getBoolean();\n"
386379
+ " }\n"
387380
+ "}"

0 commit comments

Comments
 (0)