FIX (RetireJs): @W-16007479@ Stop calling npx. Call command directly to prevent conflicts and to allow linking (#1509)

Author: stephen-carter-at-sf

src/lib/retire-js/RetireJsEngine.ts

@@ -11,6 +11,12 @@ import cspawn = require('cross-spawn');
 import path = require('path');
 import StreamZip = require('node-stream-zip');
 import {CUSTOM_CONFIG} from '../../Constants';
+import * as fs from "node:fs";
+
+// Note that we don't want to call npx retire from this file since we don't want to accidentally have npx pick up
+// another version on the users machine. Instead, we want to call the command directly from the node_modules/.bin
+// folder (which always shows up when you install the retire dependency).
+const RETIRE_JS_COMMAND = findCommand('retire');
 
 // Unlike the other engines we use, RetireJS doesn't really have "rules" per se. So we sorta have to synthesize a
 // "catalog" out of RetireJS's normal behavior and its permutations.
@@ -199,7 +205,7 @@ export class RetireJsEngine extends AbstractRuleEngine {
 
 	private async executeRetireJs(invocation: RetireJsInvocation, verboseViolations: boolean): Promise<RuleResult[]> {
 		return new Promise<RuleResult[]>((res, rej) => {
-			const cp = cspawn('npx', ['retire'].concat(invocation.args));
+			const cp = cspawn(RETIRE_JS_COMMAND, invocation.args);
 
 			// Initialize both stdout and stderr as empty strings to which we can append data as we receive it.
 			let stdout = '';
@@ -543,3 +549,17 @@ export class RetireJsEngine extends AbstractRuleEngine {
 		);
 	}
 }
+
+
+/**
+ * Finds the command location (symlink) for a command that is pulled in from this package's dependencies.
+ * We need to look up the location since the node_modules or .bin can change locations in various scenarios.
+ */
+export function findCommand(commandName: string): string {
+	for (let dir = __dirname; dir !== path.resolve(dir, '..'); dir = path.resolve(dir, '..')) {
+		const commandPath = path.join(dir, 'node_modules', '.bin', commandName);
+		if (fs.existsSync(commandPath)) return commandPath;
+	}
+	/* istanbul ignore next */
+	throw new Error(`Could not find file for command: ${commandName}`);
+}