Skip to content

Commit a132990

Browse files
Merge pull request #1674 from forcedotcom/sc/W-17100389
NEW: @W-17100389@: Add in feedback url to help text and log
2 parents 2bbb76f + 812864d commit a132990

File tree

7 files changed

+15
-3
lines changed

7 files changed

+15
-3
lines changed

messages/config-command.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ Code Analyzer gives you the ability to configure settings that modify Code Analy
88

99
To apply a custom configuration with Code Analyzer, either keep your custom configuration settings in a `code-analyzer.yml` file located in the current folder from which you are executing commands, or specify the location of your custom configuration file to the Code Analyzer commands with the --config-file flag.
1010

11+
We're continually improving Salesforce Code Analyzer. Tell us what you think! Give feedback at http://sfdc.co/CodeAnalyzerFeedback.
12+
1113
# command.examples
1214

1315
- Display the current state of the Code Analyzer configuration using the default behavior: display top level configuration, display the engine and rule override settings associated with all the rules that have a "Recommended" tag; and automatically apply any existing custom configuration settings found in a `code-analyzer.yml` or `code-analyzer.yaml` file in the current folder:

messages/path-start-util.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# error.glob-method-conflict
22

3-
*DRAFT*: Path start point %s is invalid: When specifying a method with the #methodName syntax, glob patterns cannot be used.
3+
Path start point %s is invalid: You can't use glob patterns when specifying a method with the #methodName syntax.
44

55
# error.negative-globs-unsupported
66

7-
*DRAFT*: Path start point %s is invalid: Negative globs are unsupported.
7+
Path start point %s is invalid: Negative globs are unsupported.

messages/rules-command.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ You can also view details about the rules, such as the engine it's associated wi
88

99
Use this command to determine the exact set of rules to analyze your code. The `code-analyzer run` command has similar flags as this command, so once you've determined the flag values for this command that list the rules you want to run, you specify the same values to the `code-analyzer run` command.
1010

11+
We're continually improving Salesforce Code Analyzer. Tell us what you think! Give feedback at http://sfdc.co/CodeAnalyzerFeedback.
12+
1113
# command.examples
1214

1315
- List rules using the default behavior: include rules from all engines that have a "Recommended" tag; display the rules using concise table format; and automatically apply rule or engine overrides if a "code-analyzer.yml" or "code-analyzer.yaml" file exists in the current folder:

messages/run-command.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ You can scan your codebase with the recommended rules. Or use flags to filter th
88

99
If you want to preview the list of rules before you actually run them, use the `code-analyzer rules` command, which also has the "--rules-selector", "--workspace", and "--config-file" flags that together define the list of rules to be run.
1010

11+
We're continually improving Salesforce Code Analyzer. Tell us what you think! Give feedback at http://sfdc.co/CodeAnalyzerFeedback.
12+
1113
# command.examples
1214

1315
- Analyze code using the default behavior: analyze the files in the current folder (default workspace) using the Recommended rules; display the output in the terminal with the concise table view; and automatically apply rule or engine overrides if a "code-analyzer.yml" or "code-analyzer.yaml" file exists in the current folder:

messages/shared.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,7 @@ Developer Preview
55
# warning.command-state
66

77
This command is in %s.
8+
9+
# log.give-us-feedback
10+
11+
We're continually improving Salesforce Code Analyzer. Tell us what you think! Give feedback at http://sfdc.co/CodeAnalyzerFeedback.

messages/workspace-util.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# error.negative-globs-unsupported
22

3-
*DRAFT*: Workspace path %s is invalid: Negative globs are unsupported.
3+
Workspace path %s is invalid: Negative globs are unsupported.

src/lib/listeners/LogEventListener.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import {CodeAnalyzer, EngineLogEvent, EventType, LogEvent, LogLevel} from '@salesforce/code-analyzer-core';
22
import {Display} from '../Display';
33
import {LogWriter} from '../writers/LogWriter';
4+
import {BundleName, getMessage} from "../messages";
45

56
export interface LogEventListener {
67
listen(codeAnalyzer: CodeAnalyzer): void;
@@ -58,6 +59,7 @@ export class LogEventLogger implements LogEventListener {
5859
}
5960

6061
public stopListening(): void {
62+
this.logWriter.writeToLog('\n' + getMessage(BundleName.Shared, 'log.give-us-feedback'));
6163
this.logWriter.closeLog();
6264
}
6365

0 commit comments

Comments
 (0)