Skip to content

Commit ae2f2e7

Browse files
fix: update the pr-checks
1 parent 2759acf commit ae2f2e7

File tree

2 files changed

+14
-22
lines changed

2 files changed

+14
-22
lines changed

.github/workflows/pr-checks.yml

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,18 +16,18 @@ jobs:
1616
runs-on: ubuntu-latest
1717

1818
steps:
19-
- uses: actions/checkout@v3
19+
- uses: actions/checkout@v4
2020
with:
2121
fetch-depth: 0 # Fetch all history for better git operations
2222

2323
- name: Setup Node.js
24-
uses: actions/setup-node@v3
24+
uses: actions/setup-node@v4
2525
with:
2626
node-version: '18'
2727
cache: 'npm'
2828

2929
- name: Cache Jest
30-
uses: actions/cache@v3
30+
uses: actions/cache@v4
3131
with:
3232
path: ~/.cache/jest
3333
key: ${{ runner.os }}-jest-${{ hashFiles('**/package-lock.json') }}
@@ -75,7 +75,7 @@ jobs:
7575
continue-on-error: false
7676

7777
- name: Upload Coverage Report
78-
uses: actions/upload-artifact@v3
78+
uses: actions/upload-artifact@v4
7979
with:
8080
name: coverage-report
8181
path: coverage/
@@ -120,7 +120,7 @@ jobs:
120120
121121
- name: Comment PR with Coverage Report
122122
if: github.event_name == 'pull_request'
123-
uses: actions/github-script@v6
123+
uses: actions/github-script@v7
124124
with:
125125
script: |
126126
const fs = require('fs');
@@ -159,10 +159,10 @@ jobs:
159159
runs-on: ubuntu-latest
160160

161161
steps:
162-
- uses: actions/checkout@v3
162+
- uses: actions/checkout@v4
163163

164164
- name: Setup Node.js
165-
uses: actions/setup-node@v3
165+
uses: actions/setup-node@v4
166166
with:
167167
node-version: '18'
168168
cache: 'npm'
@@ -174,8 +174,9 @@ jobs:
174174
run: |
175175
# Check if all LWC components have required files
176176
for dir in force-app/main/default/lwc/*/; do
177-
if [ ! -f "${dir}${dir%/}.js" ] || [ ! -f "${dir}${dir%/}.html" ]; then
178-
echo "Error: Component ${dir%/} is missing required files"
177+
component_name=$(basename ${dir})
178+
if [ ! -f "${dir}${component_name}.js" ] || [ ! -f "${dir}${component_name}.html" ]; then
179+
echo "Error: Component ${dir} is missing required files (${component_name}.js or ${component_name}.html)"
179180
exit 1
180181
fi
181182
done
@@ -185,10 +186,10 @@ jobs:
185186
runs-on: ubuntu-latest
186187

187188
steps:
188-
- uses: actions/checkout@v3
189+
- uses: actions/checkout@v4
189190

190191
- name: Setup Node.js
191-
uses: actions/setup-node@v3
192+
uses: actions/setup-node@v4
192193
with:
193194
node-version: '18'
194195
cache: 'npm'
@@ -206,12 +207,12 @@ jobs:
206207
name: Commit Message Check
207208
runs-on: ubuntu-latest
208209
steps:
209-
- uses: actions/checkout@v3
210+
- uses: actions/checkout@v4
210211
with:
211212
fetch-depth: 0
212213

213214
- name: Setup Node.js
214-
uses: actions/setup-node@v3
215+
uses: actions/setup-node@v4
215216
with:
216217
node-version: '18'
217218
cache: 'npm'

force-app/main/default/lwc/productVariants/__tests__/productVariants.test.js

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -81,13 +81,4 @@ describe('c-product-variants', () => {
8181
expect(variantButtons[0].classList.contains('selected')).toBe(false);
8282
expect(variantButtons[1].classList.contains('selected')).toBe(true);
8383
});
84-
85-
it('should update selectedVariant property when variant is clicked', async () => {
86-
const variantButton = element.querySelector('.variant-button');
87-
const variantValue = variantButton['data-value'];
88-
89-
variantButton.click();
90-
91-
expect(element.selectedVariant).toBe(variantValue);
92-
});
9384
});

0 commit comments

Comments
 (0)