Skip to content

Commit fe5673e

Browse files
committed
fix: add comment warning about grpc compatibility
1 parent f0e03ea commit fe5673e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

jdbc-core/src/main/java/com/salesforce/datacloud/jdbc/core/DataCloudJdbcManagedChannel.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public HyperServiceGrpc.HyperServiceBlockingStub getStub(Properties properties,
7373

7474
if (!queryTimeout.isZero() && !queryTimeout.isNegative()) {
7575
log.info("Built stub with queryTimeout={}, interceptors={}", queryTimeout, interceptors.length);
76-
stub = stub.withDeadlineAfter(queryTimeout.getSeconds(), TimeUnit.SECONDS);
76+
stub = stub.withDeadlineAfter(queryTimeout.getSeconds(), TimeUnit.SECONDS); // COMPATIBILITY WARNING: do not use Duration overload since older versions of gRPC don't have it
7777
} else {
7878
log.info("Built stub with queryTimeout=none, interceptors={}", interceptors.length);
7979
}

0 commit comments

Comments
 (0)