Merge pull request #109 from haifeng-li-at-salesforce/generateProjectRuntime

Magen: Generate project within GraphNode instead of Tool

Author: haifeng-li-at-salesforce

packages/mobile-native-mcp-server/src/index.ts

@@ -15,7 +15,6 @@ import { UtilsXcodeAddFilesTool } from './tools/utils/utils-xcode-add-files/tool
 import { SFMobileNativeDeploymentTool } from './tools/run/sfmobile-native-deployment/tool.js';
 import { SFMobileNativeBuildTool } from './tools/plan/sfmobile-native-build/tool.js';
 import { SFMobileNativeBuildRecoveryTool } from './tools/plan/sfmobile-native-build-recovery/tool.js';
-import { SFMobileNativeProjectGenerationTool } from './tools/plan/sfmobile-native-project-generation/tool.js';
 import { MobileNativeOrchestrator } from './tools/workflow/sfmobile-native-project-manager/tool.js';
 import { SFMobileNativeCompletionTool } from './tools/workflow/sfmobile-native-completion/tool.js';
 import { SFMobileNativeFailureTool } from './tools/workflow/sfmobile-native-failure/tool.js';
@@ -53,7 +52,6 @@ const orchestrator = new MobileNativeOrchestrator(server);
 const getInputTool = createSFMobileNativeGetInputTool(server);
 const inputExtractionTool = createSFMobileNativeInputExtractionTool(server);
 const templateSelectionTool = new SFMobileNativeTemplateSelectionTool(server);
-const projectGenerationTool = new SFMobileNativeProjectGenerationTool(server);
 const buildTool = new SFMobileNativeBuildTool(server);
 const buildRecoveryTool = new SFMobileNativeBuildRecoveryTool(server);
 const deploymentTool = new SFMobileNativeDeploymentTool(server);
@@ -74,7 +72,6 @@ orchestrator.register(orchestratorAnnotations);
 getInputTool.register(readOnlyAnnotations);
 inputExtractionTool.register(readOnlyAnnotations);
 templateSelectionTool.register(readOnlyAnnotations);
-projectGenerationTool.register(readOnlyAnnotations);
 buildTool.register(readOnlyAnnotations);
 buildRecoveryTool.register(readOnlyAnnotations);
 deploymentTool.register(readOnlyAnnotations);

packages/mobile-native-mcp-server/src/tools/plan/sfmobile-native-project-generation/metadata.ts

@@ -32,6 +32,7 @@ import { CheckAndroidSetupExtractedRouter } from './nodes/checkAndroidSetupExtra
 import { ExtractAndroidSetupNode } from './nodes/extractAndroidSetup.js';
 import { PluginCheckNode } from './nodes/checkPluginSetup.js';
 import { CheckPluginValidatedRouter } from './nodes/checkPluginValidatedRouter.js';
+import { CheckProjectGenerationRouter } from './nodes/checkProjectGenerationRouter.js';
 import {
   createGetUserInputNode,
   createUserInputExtractionNode,
@@ -98,6 +99,11 @@ const checkAndroidSetupExtractedRouter = new CheckAndroidSetupExtractedRouter(
   failureNode.name
 );
 
+const checkProjectGenerationRouter = new CheckProjectGenerationRouter(
+  buildValidationNode.name,
+  failureNode.name
+);
+
 const checkBuildSuccessfulRouter = new CheckBuildSuccessfulRouter(
   deploymentNode.name,
   buildRecoveryNode.name,
@@ -151,7 +157,7 @@ export const mobileNativeWorkflow = new StateGraph(MobileNativeWorkflowState)
     checkTemplatePropertiesFulfilledRouter.execute
   )
   .addEdge(templatePropertiesUserInputNode.name, templatePropertiesExtractionNode.name)
-  .addEdge(projectGenerationNode.name, buildValidationNode.name)
+  .addConditionalEdges(projectGenerationNode.name, checkProjectGenerationRouter.execute)
   // Build validation with recovery loop (similar to user input loop)
   .addConditionalEdges(buildValidationNode.name, checkBuildSuccessfulRouter.execute)
   .addEdge(buildRecoveryNode.name, buildValidationNode.name)

packages/mobile-native-mcp-server/src/tools/plan/sfmobile-native-project-generation/tool.ts

@@ -0,0 +1,54 @@
+/*
+ * Copyright (c) 2025, salesforce.com, inc.
+ * All rights reserved.
+ * SPDX-License-Identifier: MIT
+ * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
+ */
+
+import { State } from '../metadata.js';
+import { createComponentLogger } from '@salesforce/magen-mcp-workflow';
+
+/**
+ * Conditional router edge to check if project generation was successful.
+ * Routes based on whether the projectPath was set and no fatal errors occurred.
+ */
+export class CheckProjectGenerationRouter {
+  private readonly successNodeName: string;
+  private readonly failureNodeName: string;
+  private readonly logger = createComponentLogger('CheckProjectGenerationRouter');
+
+  /**
+   * Creates a new CheckProjectGenerationRouter.
+   *
+   * @param successNodeName - The name of the node to route to if project generation was successful (build validation)
+   * @param failureNodeName - The name of the node to route to if generation failed
+   */
+  constructor(successNodeName: string, failureNodeName: string) {
+    this.successNodeName = successNodeName;
+    this.failureNodeName = failureNodeName;
+  }
+
+  execute = (state: State): string => {
+    // Check if project generation was successful by verifying projectPath exists
+    // and no fatal errors occurred
+    const hasProjectPath = Boolean(state.projectPath);
+    const hasFatalErrors = Boolean(
+      state.workflowFatalErrorMessages && state.workflowFatalErrorMessages.length > 0
+    );
+
+    if (hasProjectPath && !hasFatalErrors) {
+      this.logger.info(
+        `Project generation successful at ${state.projectPath}, routing to build validation`
+      );
+      return this.successNodeName;
+    }
+
+    // If projectPath is missing or there are fatal errors, route to failure
+    const reason = hasFatalErrors
+      ? `Fatal errors occurred: ${state.workflowFatalErrorMessages?.join(', ')}`
+      : 'Project path not set after generation';
+
+    this.logger.warn(`Project generation failed. Reason: ${reason}. Routing to failure.`);
+    return this.failureNodeName;
+  };
+}