NEW: @W-18088088@: Add warning if using v4 still (#197)

Author: stephen-carter-at-sf

src/extension.ts

@@ -330,6 +330,20 @@ export async function activate(context: vscode.ExtensionContext): Promise<SFCAEx
     // =================================================================================================================
     // ==  Finalize activation
     // =================================================================================================================
+
+    if(!settingsManager.getCodeAnalyzerV5Enabled()) {
+        const button1Text: string = "Enable V5";
+        const button2Text: string = "Show 'EnableV5' in Settings";
+        vscode.window.showWarningMessage(messages.stoppingV4SupportSoon, button1Text, button2Text).then(selection => {
+            if (selection === button1Text) {
+                settingsManager.setCodeAnalyzerV5Enabled(true);
+            } else if (selection === button2Text) {
+                const settingUri = vscode.Uri.parse('vscode://settings/codeAnalyzer.enableV5');
+                vscode.commands.executeCommand('vscode.open', settingUri);
+            }
+        });
+    }
+
     telemetryService.sendExtensionActivationEvent(extensionHrStart);
     logger.log('Extension sfdx-code-analyzer-vscode activated.');
     return {

src/lib/messages.ts

@@ -5,6 +5,7 @@
  * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/BSD-3-Clause
  */
 export const messages = {
+    stoppingV4SupportSoon: "We plan to stop supporting v4.x of Code Analyzer in the coming months. We highly recommend that you start using v5.x, which is currently in Beta, by setting 'Code Analyzer: Enable V5' to true. For information on v5.x, see https://developer.salesforce.com/docs/platform/salesforce-code-analyzer/guide/code-analyzer.html.",
     scanProgressReport: {
         identifyingTargets: {
             message: "Code Analyzer is identifying targets.",

src/lib/settings.ts

@@ -41,6 +41,10 @@ export class SettingsManagerImpl implements SettingsManager {
         return vscode.workspace.getConfiguration('codeAnalyzer').get('enableV5');
     }
 
+    public setCodeAnalyzerV5Enabled(value: boolean): void {
+        vscode.workspace.getConfiguration('codeAnalyzer').update('enableV5', value, vscode.ConfigurationTarget.Global);
+    }
+
     public getCodeAnalyzerTags(): string {
         return vscode.workspace.getConfiguration('codeAnalyzer').get('ruleSelectors');
     }