chore: fix warnings

Author: WillieRuemmele

src/client/metadataApiDeploy.ts

@@ -152,7 +152,7 @@ export class MetadataApiDeploy extends MetadataTransfer<
     }
     const connection = await this.getConnection();
     // Recasting to use the project's version of the type
-    return connection.metadata.checkDeployStatus(this.id, true) as unknown as MetadataApiDeployStatus;
+    return (await connection.metadata.checkDeployStatus(this.id, true)) as unknown as MetadataApiDeployStatus;
   }
 
   /**

src/client/metadataApiRetrieve.ts

@@ -41,6 +41,7 @@ export class RetrieveResult implements MetadataTransferResult {
    * @param response The metadata retrieve response from the server
    * @param components The ComponentSet of retrieved source components
    * @param localComponents The ComponentSet used to create the retrieve request
+   * @param partialDeleteFileResponses any partially deleted file responses
    */
   public constructor(
     public readonly response: MetadataApiRetrieveStatus,

src/client/metadataTransfer.ts

@@ -46,7 +46,7 @@ export abstract class MetadataTransfer<
   private transferId: Options['id'];
   private event = new EventEmitter();
   private usernameOrConnection: string | Connection;
-  private apiVersion?: string;
+  private readonly apiVersion?: string;
 
   public constructor({ usernameOrConnection, components, apiVersion, id }: Options) {
     this.usernameOrConnection = usernameOrConnection;

src/convert/metadataConverter.ts

@@ -28,8 +28,7 @@ export class MetadataConverter {
   public static readonly DESTRUCTIVE_CHANGES_POST_XML_FILE = 'destructiveChangesPost.xml';
   public static readonly DESTRUCTIVE_CHANGES_PRE_XML_FILE = 'destructiveChangesPre.xml';
   public static readonly DEFAULT_PACKAGE_PREFIX = 'metadataPackage';
-
-  private registry: RegistryAccess;
+  private readonly registry: RegistryAccess;
 
   public constructor(registry = new RegistryAccess()) {
     this.registry = registry;
@@ -42,9 +41,7 @@ export class MetadataConverter {
   ): Promise<ConvertResult> {
     try {
       const cs = comps instanceof ComponentSet ? comps : new ComponentSet(comps, this.registry);
-      const components = (
-        (comps instanceof ComponentSet ? Array.from(comps.getSourceComponents()) : comps) as SourceComponent[]
-      ).filter((comp) => comp.type.isAddressable !== false);
+      const components = cs.getSourceComponents().filter((comp) => comp.type.isAddressable !== false);
 
       if (output.type !== 'merge' && output.packageName) {
         cs.fullName = output.packageName;

src/convert/streams.ts

@@ -118,7 +118,7 @@ export abstract class ComponentWriter extends Writable {
   protected rootDestination?: SourcePath;
   protected logger: Logger;
 
-  public constructor(rootDestination?: SourcePath) {
+  protected constructor(rootDestination?: SourcePath) {
     super({ objectMode: true });
     this.rootDestination = rootDestination;
     this.logger = Logger.childFromRoot(this.constructor.name);

src/convert/transformers/metadataTransformerFactory.ts

@@ -20,8 +20,8 @@ Messages.importMessagesDirectory(__dirname);
 const messages = Messages.loadMessages('@salesforce/source-deploy-retrieve', 'sdr');
 
 export class MetadataTransformerFactory {
-  private registry: RegistryAccess;
-  private context: ConvertContext;
+  private readonly registry: RegistryAccess;
+  private readonly context: ConvertContext;
 
   public constructor(registry: RegistryAccess, context = new ConvertContext()) {
     this.registry = registry;

src/registry/registryAccess.ts

@@ -17,7 +17,7 @@ Messages.importMessagesDirectory(__dirname);
 const messages = Messages.loadMessages('@salesforce/source-deploy-retrieve', 'sdr');
 
 export class RegistryAccess {
-  private registry: MetadataRegistry;
+  private readonly registry: MetadataRegistry;
   private strictFolderTypes?: MetadataType[];
   private folderContentTypes?: MetadataType[];
   private aliasTypes?: MetadataType[];

src/resolve/adapters/baseSourceAdapter.ts

@@ -94,7 +94,7 @@ export abstract class BaseSourceAdapter implements SourceAdapter {
   protected parseAsRootMetadataXml(path: SourcePath): MetadataXml | undefined {
     const metaXml = this.parseMetadataXml(path);
     if (metaXml) {
-      let isRootMetadataXml = false;
+      let isRootMetadataXml: boolean;
       if (this.type.strictDirectoryName) {
         const parentPath = dirname(path);
         const typeDirName = basename(this.type.inFolder ? dirname(parentPath) : parentPath);
@@ -138,6 +138,7 @@ export abstract class BaseSourceAdapter implements SourceAdapter {
    *
    * @param component Component to populate properties on
    * @param trigger Path that `getComponent` was called with
+   * @param isResolvingSource if you're resolving a local source file
    */
   protected abstract populate(
     trigger: SourcePath,
@@ -153,7 +154,7 @@ export abstract class BaseSourceAdapter implements SourceAdapter {
  *
  * .../tabs/MyTab.tab
  *
- * @param path File path of a metadata component
+ * @param type
  */
 const parseAsContentMetadataXml =
   (type: MetadataType) =>

src/resolve/adapters/decomposedSourceAdapter.ts

@@ -92,6 +92,7 @@ export class DecomposedSourceAdapter extends MixedContentSourceAdapter {
         triggerIsAChild &&
         this.type.children &&
         !this.type.children.types[childTypeId].unaddressableWithoutParent &&
+        // make sure isAddressable is truly set to 'false' not just undefined or omitted
         this.type.children.types[childTypeId].isAddressable !== false
       ) {
         if (strategy === 'folderPerType' || strategy === 'topLevel' || isResolvingSource) {

src/resolve/adapters/mixedContentSourceAdapter.ts

@@ -91,7 +91,6 @@ export class MixedContentSourceAdapter extends BaseSourceAdapter {
    * folder will be returned. Intended to be used exclusively for MixedContent types.
    *
    * @param path Path to trim
-   * @param type MetadataType to determine content for
    */
   protected trimPathToContent(path: SourcePath): SourcePath {
     const pathParts = path.split(sep);