Skip to content

Commit e15fd1f

Browse files
authored
test(deps): bump dev-scripts, adjust decodeableMap test to avoid constructor (#1384)
1 parent c8ef449 commit e15fd1f

File tree

4 files changed

+230
-262
lines changed

4 files changed

+230
-262
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"devDependencies": {
4242
"@jsforce/jsforce-node": "^3.4.0",
4343
"@salesforce/cli-plugins-testkit": "^5.3.20",
44-
"@salesforce/dev-scripts": "^10.2.8",
44+
"@salesforce/dev-scripts": "^10.2.9",
4545
"@types/deep-equal-in-any-order": "^1.0.1",
4646
"@types/fast-levenshtein": "^0.0.4",
4747
"@types/graceful-fs": "^4.1.9",

src/collections/decodeableMap.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ import { isString } from '@salesforce/ts-types';
2222
*
2323
* `decodeableMap.has('layout#Layout__Broker__c-v1%2E1 Broker Layout')` --> returns `true`
2424
* `decodeableMap.has('layout#Layout__Broker__c-v9.2 Broker Layout')` --> returns `true`
25+
*
26+
* DO NOT PASS VALUES to the Constructor. Instantiate the class and use the methods.
2527
*/
2628
export class DecodeableMap<K extends string, V> extends Map<string, V> {
2729
// Internal map of decoded keys to encoded keys.

test/collections/decodeableMap.test.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { DecodeableMap } from '../../src/collections/decodeableMap';
1010

1111
// passes on dev-scripts 10.2.2, fails on 10.2.4. I don't know why.
1212
// possibly mocha or types/node
13-
describe.skip('DecodeableMap', () => {
13+
describe('DecodeableMap', () => {
1414
let dMap: DecodeableMap<string, string>;
1515
const layout1_key_encoded = 'Layout-v1%2E1 Layout';
1616
const layout1_key_decoded = 'Layout-v1.1 Layout';
@@ -28,10 +28,9 @@ describe.skip('DecodeableMap', () => {
2828
let deleteMapSpy: sinon.SinonSpy;
2929

3030
beforeEach(() => {
31-
dMap = new DecodeableMap([
32-
[layout1_key_encoded, layout1_value],
33-
[layout9_key_decoded, layout9_value],
34-
]);
31+
dMap = new DecodeableMap();
32+
dMap.set(layout1_key_encoded, layout1_value);
33+
dMap.set(layout9_key_decoded, layout9_value);
3534
hasMapSpy = sandbox.spy(Map.prototype, 'has');
3635
getMapSpy = sandbox.spy(Map.prototype, 'get');
3736
setMapSpy = sandbox.spy(Map.prototype, 'set');

0 commit comments

Comments
 (0)